• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

pulibrary / allsearch_api / 8cca27ea-0ec0-4546-b1e5-0dc9f1ef05a3

31 Oct 2025 06:27PM UTC coverage: 99.903% (+0.003%) from 99.9%
8cca27ea-0ec0-4546-b1e5-0dc9f1ef05a3

Pull #389

circleci

sandbergja
Replace uses of the Banner ActiveRecord model with Rom-RB

The ActiveRecord model is still used in tests and a database migration,
maybe those could be migrated to Rom-RB in a separate PR?

A Rom Container is created that uses the same database connections as
ActiveRecord.  This allows rom to use the same database transactions
as activerecord, allowing tests (which use db transactions to stay
isolated from one another) to still pass.
Pull Request #389: Replace uses of the Banner ActiveRecord model with Rom-RB

34 of 39 new or added lines in 4 files covered. (87.18%)

57 existing lines in 13 files now uncovered.

1031 of 1032 relevant lines covered (99.9%)

112.35 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0
/app/models/dpul_document.rb
1
# frozen_string_literal: true
2

3
# This class is responsible for getting relevant
4
# metadata from DPUL's JSON
5
class DpulDocument < Document
3✔
6
  include SolrDocument
3✔
7

8
  private
3✔
9

10
  def service
3✔
UNCOV
11
    'dpul'
71✔
12
  end
13

14
  def title
3✔
UNCOV
15
    document[:readonly_title_ssim]&.first
70✔
16
  end
17

18
  def creator
3✔
UNCOV
19
    document[:readonly_creator_ssim]&.first
69✔
20
  end
21

22
  def publisher
3✔
UNCOV
23
    document[:readonly_publisher_ssim]&.first
69✔
24
  end
25

26
  def type
3✔
UNCOV
27
    document[:readonly_format_ssim]&.first
69✔
28
  end
29

30
  def description
3✔
31
    # tbd - nothing in the current json that seems relevant
32
  end
33

34
  def doc_keys
3✔
UNCOV
35
    [:collection]
70✔
36
  end
37

38
  def collection
3✔
UNCOV
39
    document[:readonly_collections_tesim]&.first
70✔
40
  end
41
end
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc