8641f368-b9cd-4dfe-8008-1491081d0ba0

Committed 07 Nov 2025 06:12PM UTC coverage: 72.426% (-18.9%) from 91.357%

Build # 8641f368-b9cd-4dfe-8008-1491081d0ba0

Build Type

Pull #2163

circleci

Committed by

web-flow

Commit Message

Merge branch 'main' into 2157-project-list-error

Pull Request Pull Request #2163: Logs Mediaflux errors when fetching the project list

Run Details

5 of 8 new or added lines in 1 file covered. (62.5%)

170 existing lines in 22 files now uncovered.

2272 of 3137 relevant lines covered (72.43%)

200.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.3

/app/models/request.rb

# frozen_string_literal: true
# rubocop:disable Metrics/ClassLength
class Request < ApplicationRecord
  DRAFT = "draft" # default state set by database
  SUBMITTED = "submitted" # Ready to be approved

  def valid_to_submit?
    errors.clear
    # run all validations and then check for errors otherwise ruby stops at the first error
    valid_title?
    valid_data_sponsor?
    valid_data_manager?
    valid_departments?
    valid_quota?
    valid_project_purpose?
    valid_description?
    # Is parent folder really required?  For Skeletor let's skip it.
    # valid_parent_folder?
    valid_project_folder?
    # For Skeletor we are setting the requestor to the data sponsor
    # valid_requested_by?
    errors.count == 0
  end

  def valid_title?
    check_errors? do
      field_present?(project_title, :project_title)
      valid_length(project_title, 200, :project_title)
      no_quotes(project_title, :project_title)
    end
  end

  def valid_data_sponsor?
    check_errors? { validate_uid(data_sponsor, :data_sponsor) }
  end

  def valid_data_manager?
    check_errors? { validate_uid(data_manager, :data_manager) }
  end

  def valid_departments?
    check_errors? { field_present?(departments, :departments) }
  end

  def valid_project_purpose?
    check_errors? { project_purpose_present?(project_purpose, :project_purpose) }
  end

  def valid_description?
    check_errors? do
      field_present?(description, :description)
      valid_length(description, 1000, :description)
      no_quotes(description, :description)
    end
  end

  def valid_parent_folder?
    check_errors? do
      field_present?(parent_folder, :parent_folder)
      no_quotes(project_title, :parent_folder)
    end
  end

  def valid_project_folder?
    check_errors? do
      field_present?(project_folder, :project_folder)
      no_quotes(project_folder, :project_folder)
    end
  end

  def valid_quota?
    if ((quota == "500 GB") || (quota == "2 TB") || (quota == "10 TB") || (quota == "25 TB")) ||
       (custom_quota? && (storage_size.present? && (storage_size > 0)) && ((storage_unit == "GB") || (storage_unit == "TB")))
      true
    else
      errors.add(:quota, :invalid, message: "must be one of '500 GB', '2 TB', '10 TB', '25 TB', or 'custom'")
      false
    end
  end

  def custom_quota?
    quota == "custom"
  end

  def valid_requested_by?
    check_errors? { field_present?(requested_by, :requested_by) }
  end

  def approve(approver)
    create_project_operation = ProjectCreate.new
    result = create_project_operation.call(request: self, approver: approver)
    if result.success?
      result.value!
    else
      self.error_message = { message: result.failure }
      save!
      cleanup_incomplete_project
      raise ProjectCreate::ProjectCreateError, result.failure
    end
  end

  def approved_quota_size
    if approved_quota.present?
      if approved_quota == "custom"
        approved_storage_size.to_f
      else
        approved_quota.split.first.to_f
      end
    else
      requested_quota_size
    end
  end

  def requested_quota_size
    if custom_quota?
      storage_size.to_f
    else
      quota.split.first.to_f
    end
  end

  def approved_quota_unit
    if approved_quota.present?
      if approved_quota == "custom"
        approved_storage_unit
      else
        approved_quota.split.last
      end
    else
      requested_quota_unit
    end
  end

  def requested_quota_unit
    if custom_quota?
      storage_unit
    else
      quota.split.last
    end
  end

  def submitted?
    state == Request::SUBMITTED
  end

  def project_path
    return project_folder if parent_folder.blank?

    [parent_folder, project_folder].join("/")
  end

  def requestor
    return "missing" if requested_by.blank?
    User.find_by(uid: requested_by).display_name_safe
  end

  def data_manager_name
    user_name(data_manager)
  end

  def data_sponsor_name
    user_name(data_sponsor)
  end

  private

    def user_name(uid)
      return "" if uid.blank?
      user = User.find_by(uid: uid)
      if user.present?
        user.display_name_safe
      else
        uid
      end
    end

    def check_errors?
      original_error_count = errors.count
      yield
      original_error_count == errors.count
    end

    def field_present?(value, name)
      if value.blank?
        errors.add(name, :invalid, message: "cannot be empty")
      end
    end

    def validate_uid(uid, field)
      if uid.blank?
        errors.add(field, :blank, message: "cannot be empty")
      elsif User.where(uid: uid).count == 0
        errors.add(field, :invalid, message: "must be a valid user")
      end
    end

    def project_purpose_present?(project_purpose, field)
      if project_purpose.blank?
        errors.add(field, :blank, message: "select a project purpose")
      end
    end

    def valid_length(value, length, field)
      return if value.blank?
      if value.length > length
        errors.add(field, :invalid, message: "cannot exceed #{length} characters")
      end
    end

    def no_quotes(value, field)
      return if value.blank?
      if value.include?('"')
        errors.add(field, :invalid, message: "cannot include quotes")
      end
    end

    # If a request fails to be a approved we make sure there were not orphan
    # project records left in our Rails database that do not have a matching
    # project in Mediaflux (i.e. collection asset).
    def cleanup_incomplete_project
      project = Project.find_by_id(project_id)
      if project && project.mediaflux_id.nil?
        Rails.logger.warn("Deleting project #{project.id} because the approval for request #{id} failed and it was not created in Mediaflux.")
        project.destroy!
      end
    end
end
# rubocop:enable Metrics/ClassLength

1	# frozen_string_literal: true
2	# rubocop:disable Metrics/ClassLength
3	class Request < ApplicationRecord	1✔
4	DRAFT = "draft" # default state set by database	1✔
5	SUBMITTED = "submitted" # Ready to be approved	1✔
6
7	def valid_to_submit?	1✔
8	errors.clear	25✔
9	# run all validations and then check for errors otherwise ruby stops at the first error
10	valid_title?	25✔
11	valid_data_sponsor?	25✔
12	valid_data_manager?	25✔
13	valid_departments?	25✔
14	valid_quota?	25✔
15	valid_project_purpose?	25✔
16	valid_description?	25✔
17	# Is parent folder really required? For Skeletor let's skip it.
18	# valid_parent_folder?
19	valid_project_folder?	25✔
20	# For Skeletor we are setting the requestor to the data sponsor
21	# valid_requested_by?
22	errors.count == 0	25✔
23	end
24
25	def valid_title?	1✔
26	check_errors? do	25✔
27	field_present?(project_title, :project_title)	25✔
28	valid_length(project_title, 200, :project_title)	25✔
29	no_quotes(project_title, :project_title)	25✔
30	end
31	end
32
33	def valid_data_sponsor?	1✔
34	check_errors? { validate_uid(data_sponsor, :data_sponsor) }	50✔
35	end
36
37	def valid_data_manager?	1✔
38	check_errors? { validate_uid(data_manager, :data_manager) }	50✔
39	end
40
41	def valid_departments?	1✔
42	check_errors? { field_present?(departments, :departments) }	50✔
43	end
44
45	def valid_project_purpose?	1✔
46	check_errors? { project_purpose_present?(project_purpose, :project_purpose) }	50✔
47	end
48
49	def valid_description?	1✔
50	check_errors? do	25✔
51	field_present?(description, :description)	25✔
52	valid_length(description, 1000, :description)	25✔
53	no_quotes(description, :description)	25✔
54	end
55	end
56
57	def valid_parent_folder?	1✔
UNCOV 58	check_errors? do	×
UNCOV 59	field_present?(parent_folder, :parent_folder)	×
UNCOV 60	no_quotes(project_title, :parent_folder)	×
61	end
62	end
63
64	def valid_project_folder?	1✔
65	check_errors? do	25✔
66	field_present?(project_folder, :project_folder)	25✔
67	no_quotes(project_folder, :project_folder)	25✔
68	end
69	end
70
71	def valid_quota?	1✔
72	if ((quota == "500 GB") \|\| (quota == "2 TB") \|\| (quota == "10 TB") \|\| (quota == "25 TB")) \|\|	25✔
73	(custom_quota? && (storage_size.present? && (storage_size > 0)) && ((storage_unit == "GB") \|\| (storage_unit == "TB")))	2✔
74	true	24✔
75	else
76	errors.add(:quota, :invalid, message: "must be one of '500 GB', '2 TB', '10 TB', '25 TB', or 'custom'")	1✔
77	false	1✔
78	end
79	end
80
81	def custom_quota?	1✔
82	quota == "custom"	258✔
83	end
84
85	def valid_requested_by?	1✔
UNCOV 86	check_errors? { field_present?(requested_by, :requested_by) }	×
87	end
88
89	def approve(approver)	1✔
90	create_project_operation = ProjectCreate.new	111✔
91	result = create_project_operation.call(request: self, approver: approver)	111✔
92	if result.success?	111✔
93	result.value!	111✔
94	else
UNCOV 95	self.error_message = { message: result.failure }	×
UNCOV 96	save!	×
UNCOV 97	cleanup_incomplete_project	×
UNCOV 98	raise ProjectCreate::ProjectCreateError, result.failure	×
99	end
100	end
101
102	def approved_quota_size	1✔
103	if approved_quota.present?	125✔
104	if approved_quota == "custom"	108✔
105	approved_storage_size.to_f	107✔
106	else
107	approved_quota.split.first.to_f	1✔
108	end
109	else
110	requested_quota_size	17✔
111	end
112	end
113
114	def requested_quota_size	1✔
115	if custom_quota?	128✔
116	storage_size.to_f	108✔
117	else
118	quota.split.first.to_f	20✔
119	end
120	end
121
122	def approved_quota_unit	1✔
123	if approved_quota.present?	125✔
124	if approved_quota == "custom"	108✔
125	approved_storage_unit	107✔
126	else
127	approved_quota.split.last	1✔
128	end
129	else
130	requested_quota_unit	17✔
131	end
132	end
133
134	def requested_quota_unit	1✔
135	if custom_quota?	128✔
136	storage_unit	108✔
137	else
138	quota.split.last	20✔
139	end
140	end
141
142	def submitted?	1✔
143	state == Request::SUBMITTED	162✔
144	end
145
146	def project_path	1✔
147	return project_folder if parent_folder.blank?	2✔
148
UNCOV 149	[parent_folder, project_folder].join("/")	×
150	end
151
152	def requestor	1✔
153	return "missing" if requested_by.blank?	1✔
154	User.find_by(uid: requested_by).display_name_safe	1✔
155	end
156
157	def data_manager_name	1✔
158	user_name(data_manager)	22✔
159	end
160
161	def data_sponsor_name	1✔
162	user_name(data_sponsor)	22✔
163	end
164
165	private	1✔
166
167	def user_name(uid)	1✔
168	return "" if uid.blank?	44✔
169	user = User.find_by(uid: uid)	12✔
170	if user.present?	12✔
171	user.display_name_safe	12✔
172	else
173	uid	×
174	end
175	end
176
177	def check_errors?	1✔
178	original_error_count = errors.count	175✔
179	yield	175✔
180	original_error_count == errors.count	175✔
181	end
182
183	def field_present?(value, name)	1✔
184	if value.blank?	100✔
185	errors.add(name, :invalid, message: "cannot be empty")	34✔
186	end
187	end
188
189	def validate_uid(uid, field)	1✔
190	if uid.blank?	50✔
191	errors.add(field, :blank, message: "cannot be empty")	18✔
192	elsif User.where(uid: uid).count == 0	32✔
UNCOV 193	errors.add(field, :invalid, message: "must be a valid user")	×
194	end
195	end
196
197	def project_purpose_present?(project_purpose, field)	1✔
198	if project_purpose.blank?	25✔
199	errors.add(field, :blank, message: "select a project purpose")	9✔
200	end
201	end
202
203	def valid_length(value, length, field)	1✔
204	return if value.blank?	50✔
205	if value.length > length	34✔
206	errors.add(field, :invalid, message: "cannot exceed #{length} characters")	4✔
207	end
208	end
209
210	def no_quotes(value, field)	1✔
211	return if value.blank?	75✔
212	if value.include?('"')	50✔
UNCOV 213	errors.add(field, :invalid, message: "cannot include quotes")	×
214	end
215	end
216
217	# If a request fails to be a approved we make sure there were not orphan
218	# project records left in our Rails database that do not have a matching
219	# project in Mediaflux (i.e. collection asset).
220	def cleanup_incomplete_project	1✔
UNCOV 221	project = Project.find_by_id(project_id)	×
UNCOV 222	if project && project.mediaflux_id.nil?	×
UNCOV 223	Rails.logger.warn("Deleting project #{project.id} because the approval for request #{id} failed and it was not created in Mediaflux.")	×
UNCOV 224	project.destroy!	×
225	end
226	end
227	end
228	# rubocop:enable Metrics/ClassLength

pulibrary / tigerdata-app / 8641f368-b9cd-4dfe-8008-1491081d0ba0

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous