34dcbd97-a3da-420a-b11e-066310a63dda

Committed 01 Dec 2025 07:52PM UTC coverage: 87.656% (-3.7%) from 91.374%

Build # 34dcbd97-a3da-420a-b11e-066310a63dda

Build Type

push

circleci

Committed by

web-flow

Commit Message

Fixed quota display bug on dashboard (#2256)

Closes #2255 

## Local screenshot

<img width="1262" height="488" alt="Screenshot 2025-12-01 at 2 24 43 PM"
src="https://github.com/user-attachments/assets/c339863e-6d08-48f5-90c4-7a8d994fdc92"
/>

Run Details

2805 of 3200 relevant lines covered (87.66%)

359.65 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

92.68

/app/services/project_import.rb

require "csv"

class ProjectImport

    attr_accessor :csv_data, :test_run

    def initialize(csv_data, test_run: false)
        @csv_data = csv_data
        @test_run = test_run
    end

    def self.run_with_report(mediaflux_session:)
      report = Mediaflux::ProjectReport.new(session_token: mediaflux_session)
      return [report.response_error[:message]] if report.error?

      importer = self.new(report.csv_data.gsub("\r\n",""))
      importer.run
    end

    def run
        output = []
        mediaflux_projects = CSV.new(csv_data, headers: true, liberal_parsing: true)
        mediaflux_projects.each do |project_metadata|
          project_id = project_metadata["projectID"]
          existing_project = Project.where("metadata_json @> ?", JSON.dump(project_id:))
          if existing_project.count > 0
            output << "Skipping project #{project_id}.  There are already #{existing_project.count} version of that project in the system"
          else
            metadata = convert_csv(project_metadata:, project_id:)
            if test_run
              output << metadata.to_json
            else
              if metadata.data_user_read_only.first == "n/a" && metadata.data_user_read_only.count == 1
                metadata.data_user_read_only = []
              end
              # Create the Rails record for the project
              project = Project.create(metadata:, mediaflux_id: project_metadata["asset"])
              if (project.valid?)
                output << "Created project for #{project_id}"
              else
                output << "Error creating project for #{project_metadata["asset"]}: #{project.errors.to_a.join(";")}"
              end
            end
          end
        end
        output
    rescue CSV::MalformedCSVError => error
      ["Error parsing response #{ csv_data.to_s.slice(0,200) } error: #{error}"]
    end

    private
        def convert_csv(project_metadata:, project_id:)
            data_user = parse_multiple(project_metadata, "dataUser")
            department_names = parse_multiple(project_metadata,"department")
            departments = department_names.map {|name| Affiliation.find_fuzzy_by_name(name)&.code || name }

            storage_size_gb = project_metadata["quota"].downcase.to_f/1000000000.0
            ProjectMetadata.new_from_hash({
              project_id:,
              title: project_metadata["title"],
              description: project_metadata["description"],
              status: Project::ACTIVE_STATUS,
              data_sponsor: project_metadata["dataSponsor"],
              data_manager: project_metadata["dataManager"],
              departments: departments,
              data_user_read_only: data_user,
              project_directory: project_metadata["path"],
              storage_capacity: {size: { approved: storage_size_gb, requested: storage_size_gb}, unit: {approved: "GB", requested: "GB"}},
              storage_performance_expectations: { requested: "Standard", approved: "Standard" },
              created_by: project_metadata["creatorUser"],
              created_on: project_metadata["createdOn"]
            })
        end

        def parse_multiple(project_metadata, key)
            if project_metadata[key].blank?
            []
            else
            project_metadata[key].split(",").map(&:strip)
            end
        end
end

1	require "csv"	2✔
2
3	class ProjectImport	2✔
4
5	attr_accessor :csv_data, :test_run	2✔
6
7	def initialize(csv_data, test_run: false)	2✔
8	@csv_data = csv_data	7✔
9	@test_run = test_run	7✔
10	end
11
12	def self.run_with_report(mediaflux_session:)	2✔
13	report = Mediaflux::ProjectReport.new(session_token: mediaflux_session)	3✔
14	return [report.response_error[:message]] if report.error?	3✔
15
16	importer = self.new(report.csv_data.gsub("\r\n",""))	3✔
17	importer.run	3✔
18	end
19
20	def run	2✔
21	output = []	8✔
22	mediaflux_projects = CSV.new(csv_data, headers: true, liberal_parsing: true)	8✔
23	mediaflux_projects.each do \|project_metadata\|	8✔
24	project_id = project_metadata["projectID"]	77✔
25	existing_project = Project.where("metadata_json @> ?", JSON.dump(project_id:))	77✔
26	if existing_project.count > 0	77✔
27	output << "Skipping project #{project_id}. There are already #{existing_project.count} version of that project in the system"	55✔
28	else
29	metadata = convert_csv(project_metadata:, project_id:)	22✔
30	if test_run	22✔
31	output << metadata.to_json	×
32	else
33	if metadata.data_user_read_only.first == "n/a" && metadata.data_user_read_only.count == 1	22✔
34	metadata.data_user_read_only = []	×
35	end
36	# Create the Rails record for the project
37	project = Project.create(metadata:, mediaflux_id: project_metadata["asset"])	22✔
38	if (project.valid?)	22✔
39	output << "Created project for #{project_id}"	12✔
40	else
41	output << "Error creating project for #{project_metadata["asset"]}: #{project.errors.to_a.join(";")}"	10✔
42	end
43	end
44	end
45	end
46	output	8✔
47	rescue CSV::MalformedCSVError => error
48	["Error parsing response #{ csv_data.to_s.slice(0,200) } error: #{error}"]	×
49	end
50
51	private	2✔
52	def convert_csv(project_metadata:, project_id:)	2✔
53	data_user = parse_multiple(project_metadata, "dataUser")	22✔
54	department_names = parse_multiple(project_metadata,"department")	22✔
55	departments = department_names.map {\|name\| Affiliation.find_fuzzy_by_name(name)&.code \|\| name }	55✔
56
57	storage_size_gb = project_metadata["quota"].downcase.to_f/1000000000.0	22✔
58	ProjectMetadata.new_from_hash({	22✔
59	project_id:,
60	title: project_metadata["title"],
61	description: project_metadata["description"],
62	status: Project::ACTIVE_STATUS,
63	data_sponsor: project_metadata["dataSponsor"],
64	data_manager: project_metadata["dataManager"],
65	departments: departments,
66	data_user_read_only: data_user,
67	project_directory: project_metadata["path"],
68	storage_capacity: {size: { approved: storage_size_gb, requested: storage_size_gb}, unit: {approved: "GB", requested: "GB"}},
69	storage_performance_expectations: { requested: "Standard", approved: "Standard" },
70	created_by: project_metadata["creatorUser"],
71	created_on: project_metadata["createdOn"]
72	})
73	end
74
75	def parse_multiple(project_metadata, key)	2✔
76	if project_metadata[key].blank?	44✔
77	[]	13✔
78	else
79	project_metadata[key].split(",").map(&:strip)	31✔
80	end
81	end
82	end

pulibrary / tigerdata-app / 34dcbd97-a3da-420a-b11e-066310a63dda

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous