mozilla / blurts-server / 233

pending completion

Build # 233

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge pull request #83 from mozilla/verify-ui

Use confirm template for /user/verify success response

Run Details

7 of 3960 branches covered (0.18%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

55 of 3932 relevant lines covered (1.4%)

0.04 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/routes/user.js

"use strict";

const AppConstants = require("../app-constants");

const express = require("express");
const bodyParser = require("body-parser");

const models = require("../db/models");
const EmailUtils = require("../email-utils");

const ResponseCodes = Object.freeze({
  InternalError: 999,
  EmailNotProvided: 100,
  EmailNotFound: 101,
  TokenMismatch: 102,
});

const router = express.Router();
const jsonParser = bodyParser.json();
const urlEncodedParser = bodyParser.urlencoded({ extended: false });

router.post("/add", urlEncodedParser, async (req, res) => {
  const user = await models.Subscriber.create({ email: req.body.email });
  const url = `${AppConstants.SERVER_URL}/user/verify?state=${encodeURIComponent(user.verificationToken)}&email=${encodeURIComponent(user.email)}`;

  try {
    await EmailUtils.sendEmail(user.email, "Firefox Breach Alert",
      `Visit this link to subscribe: ${url}`);

    res.render("add", {
      title: "Verify email",
      email: user.email,
    });
  } catch (e) {
    console.log(e);
    res.status(500).json({
      error_code: ResponseCodes.InternalError,
      info: "SMTP error.",
    });
  }
});

router.get("/verify", jsonParser, async (req, res) => {
  const email = req.query.email;
  const user = await models.Subscriber.findOne({ where: { email, verificationToken: req.query.state } });

  if (user === null) {
    res.status(400).json({
      error_code: ResponseCodes.EmailNotFound,
      info: "Email not found or verification token does not match.",
    });
    return;
  }

  // TODO: make a better user "verified" status than implicit presence of
  // SHA1 hash value
  user.saveSha1();

  res.render("confirm", {
    title: "Firefox Breach Alerts: Subscribed",
    email: email,
    user: user,
  });
});

router.post("/remove", jsonParser, async (req, res) => {
  models.Subscriber.destroy({ where: { email: req.query.email } });
  res.status(200).json({
    info: "Deleted user.",
  });
});

module.exports = router;

1	"use strict";
2
3	const AppConstants = require("../app-constants");	×
4
5	const express = require("express");	×
6	const bodyParser = require("body-parser");	×
7
8	const models = require("../db/models");	×
9	const EmailUtils = require("../email-utils");	×
10
11	const ResponseCodes = Object.freeze({	×
12	InternalError: 999,
13	EmailNotProvided: 100,
14	EmailNotFound: 101,
15	TokenMismatch: 102,
16	});
17
18	const router = express.Router();	×
19	const jsonParser = bodyParser.json();	×
20	const urlEncodedParser = bodyParser.urlencoded({ extended: false });	×
21
22	router.post("/add", urlEncodedParser, async (req, res) => {	×
23	const user = await models.Subscriber.create({ email: req.body.email });	×
24	const url = `${AppConstants.SERVER_URL}/user/verify?state=${encodeURIComponent(user.verificationToken)}&email=${encodeURIComponent(user.email)}`;	×
25
26	try {	×
27	await EmailUtils.sendEmail(user.email, "Firefox Breach Alert",	×
28	`Visit this link to subscribe: ${url}`);
29
30	res.render("add", {	×
31	title: "Verify email",
32	email: user.email,
33	});
34	} catch (e) {
35	console.log(e);	×
36	res.status(500).json({	×
37	error_code: ResponseCodes.InternalError,
38	info: "SMTP error.",
39	});
40	}
41	});
42
43	router.get("/verify", jsonParser, async (req, res) => {	×
44	const email = req.query.email;	×
45	const user = await models.Subscriber.findOne({ where: { email, verificationToken: req.query.state } });	×
46
47	if (user === null) {	×
48	res.status(400).json({	×
49	error_code: ResponseCodes.EmailNotFound,
50	info: "Email not found or verification token does not match.",
51	});
52	return;	×
53	}
54
55	// TODO: make a better user "verified" status than implicit presence of
56	// SHA1 hash value
57	user.saveSha1();	×
58
59	res.render("confirm", {	×
60	title: "Firefox Breach Alerts: Subscribed",
61	email: email,
62	user: user,
63	});
64	});
65
66	router.post("/remove", jsonParser, async (req, res) => {	×
67	models.Subscriber.destroy({ where: { email: req.query.email } });	×
68	res.status(200).json({	×
69	info: "Deleted user.",
70	});
71	});
72
73	module.exports = router;	×

mozilla / blurts-server / 233

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous