#11467

pending completion

Build # #11467

Build Type

push

circleci

Committed by

web-flow

Commit Message

Merge pull request #2714 from mozilla/fix-page-not-found

Fix "page not found" error in Refresh build

Run Details

278 of 1059 branches covered (26.25%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

948 of 2868 relevant lines covered (33.05%)

2.61 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/middleware/error.js

import { MethodNotAllowedError, NotFoundError } from '../utils/error.js'
import mozlog from '../utils/log.js'
const log = mozlog('middleware')

/**
 * Generic error handling function that takes in an error with
 *
 * message: error message
 *
 * statusCode: http status code
 *
 * and returns a json response
 * @param {object} err error object [ message, statusCode ]
 * @param {object} req request object
 * @param {object} res response object
 * @param {object} next middleware callback
 */
function errorHandler (err, req, res, next) {
  log.error('error', { stack: err.stack })
  const errStatus = err.statusCode || 500
  const errMsg = err.message || 'Empty error message'
  res.status(errStatus).json({
    success: false,
    status: errStatus,
    message: process.env.NODE_ENV !== 'production' ? errMsg : 'Something went wrong', // hide error message when in production
    stack: process.env.NODE_ENV === 'dev' ? err.stack : {} // hide stack when not in dev
  })
}

/**
 * Used as a 404 default for routes
 */
function notFound (req) {
  // TODO: when there's a 404 page to be rendered here,
  // replace the json return with html
  throw new NotFoundError(`Page not found! ${req.method} ${req.originalUrl}`)
}

function methodNotAllowed (req) {
  throw new MethodNotAllowedError(`Method not allowed: ${req.method} ${req.originalUrl}`)
}

export {
  errorHandler,
  notFound,
  methodNotAllowed
}

1	import { MethodNotAllowedError, NotFoundError } from '../utils/error.js'
2	import mozlog from '../utils/log.js'
3	const log = mozlog('middleware')	×
4
5	/**
6	* Generic error handling function that takes in an error with
7	*
8	* message: error message
9	*
10	* statusCode: http status code
11	*
12	* and returns a json response
13	* @param {object} err error object [ message, statusCode ]
14	* @param {object} req request object
15	* @param {object} res response object
16	* @param {object} next middleware callback
17	*/
18	function errorHandler (err, req, res, next) {
19	log.error('error', { stack: err.stack })	×
20	const errStatus = err.statusCode \|\| 500	×
21	const errMsg = err.message \|\| 'Empty error message'	×
22	res.status(errStatus).json({	×
23	success: false,
24	status: errStatus,
25	message: process.env.NODE_ENV !== 'production' ? errMsg : 'Something went wrong', // hide error message when in production	×
26	stack: process.env.NODE_ENV === 'dev' ? err.stack : {} // hide stack when not in dev	×
27	})
28	}
29
30	/**
31	* Used as a 404 default for routes
32	*/
33	function notFound (req) {
34	// TODO: when there's a 404 page to be rendered here,
35	// replace the json return with html
36	throw new NotFoundError(`Page not found! ${req.method} ${req.originalUrl}`)	×
37	}
38
39	function methodNotAllowed (req) {
40	throw new MethodNotAllowedError(`Method not allowed: ${req.method} ${req.originalUrl}`)	×
41	}
42
43	export {
44	errorHandler,
45	notFound,
46	methodNotAllowed
47	}

mozilla / blurts-server / #11467

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous