#13117

pending completion

Build # #13117

Build Type

push

circleci

Committed by

Vinnl

Commit Message

Pretend HTMLElement.shadowRoot is always set

We generally only tend to access it after having called
this.attachShadow({ mode: 'open' }), and the error message about it
potentially being undefined at every location we access
this.shadowRoot is more noisy than helpful.

See also
https://github.com/mozilla/blurts-server/pull/2959#discussion_r1154023113
and
https://github.com/mozilla/blurts-server/pull/2959#discussion_r1154960095

Run Details

282 of 1629 branches covered (17.31%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

959 of 4374 relevant lines covered (21.93%)

1.83 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/controllers/auth.js

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

import { URL } from 'url'
import { randomBytes } from 'crypto'

import AppConstants from '../app-constants.js'
import {
  getSubscriberByEmail,
  removeFxAData,
  updateFxAData
} from '../db/tables/subscribers.js'
import { addSubscriber } from '../db/tables/email_addresses.js'

import { getTemplate } from '../views/emails/email-2022.js'
import {
  signupReportEmailPartial
} from '../views/emails/email-signup-report.js'

import { getBreachesForEmail } from '../utils/hibp.js'
import { getMessage } from '../utils/fluent.js'
import { getProfileData, FxAOAuthClient, getSha1 } from '../utils/fxa.js'
import { getEmailCtaHref, sendEmail } from '../utils/email.js'
import { UnauthorizedError } from '../utils/error.js'
import mozlog from '../utils/log.js'

const { SERVER_URL } = AppConstants

const log = mozlog('controllers.auth')

function init (req, res, next, client = FxAOAuthClient) {
  // Set a random state string in a cookie so that we can verify
  // the user when they're redirected back to us after auth.
  const state = randomBytes(40).toString('hex')
  req.session.state = state
  const url = new URL(client.code.getUri({ state }))
  const fxaParams = new URL(req.url, SERVER_URL)

  req.session.utmContents = {}
  url.searchParams.append('prompt', 'login')
  url.searchParams.append('max_age', 0)
  url.searchParams.append('access_type', 'offline')
  url.searchParams.append('action', 'email')

  for (const param of fxaParams.searchParams.keys()) {
    url.searchParams.append(param, fxaParams.searchParams.get(param))
  }

  res.redirect(url)
}

async function confirmed (req, res, next, client = FxAOAuthClient) {
  if (!req.session.state) {
    log.error('oauth-invalid-session', 'req.session.state missing')
    throw new UnauthorizedError(getMessage('oauth-invalid-session'))
  }

  if (req.session.state !== req.query.state) {
    log.error('oauth-invalid-session', 'req.session does not match req.query')
    throw new UnauthorizedError(getMessage('oauth-invalid-session'))
  }

  const fxaUser = await client.code.getToken(req.originalUrl, {
    state: req.session.state
  })
  // Clear the session.state to clean up and avoid any replays
  req.session.state = null
  log.debug('fxa-confirmed-fxaUser', fxaUser)
  const fxaProfileData = await getProfileData(fxaUser.accessToken)
  log.debug('fxa-confirmed-profile-data', fxaProfileData)
  const email = JSON.parse(fxaProfileData).email

  const existingUser = await getSubscriberByEmail(email)
  req.session.user = existingUser

  const returnURL = new URL('user/breaches', SERVER_URL)
  const originalURL = new URL(req.originalUrl, SERVER_URL)

  for (const [key, value] of originalURL.searchParams.entries()) {
    if (key.startsWith('utm_')) returnURL.searchParams.append(key, value)
  }

  // Check if user is signing up or signing in,
  // then add new users to db and send email.
  if (!existingUser) {
    // req.session.newUser determines whether or not we show `fxa_new_user_bar`
    // in template
    req.session.newUser = true
    const signupLanguage = req.locale
    const verifiedSubscriber = await addSubscriber(
      email,
      signupLanguage,
      fxaUser.accessToken,
      fxaUser.refreshToken,
      fxaProfileData
    )

    // Get breaches for email the user signed-up with
    const allBreaches = req.app.locals.breaches
    const unsafeBreachesForEmail = await getBreachesForEmail(
      getSha1(email),
      allBreaches,
      true
    )

    // Send report email
    const utmCampaignId = 'report'
    const subject = unsafeBreachesForEmail?.length
      ? getMessage('email-subject-found-breaches')
      : getMessage('email-subject-no-breaches')

    const data = {
      breachedEmail: email,
      breachLogos: req.app.locals.breachLogoMap,
      ctaHref: getEmailCtaHref(utmCampaignId, 'dashboard-cta'),
      heading: getMessage('email-breach-summary'),
      recipientEmail: email,
      subscriberId: verifiedSubscriber,
      unsafeBreachesForEmail,
      utmCampaign: utmCampaignId
    }
    const emailTemplate = getTemplate(data, signupReportEmailPartial)

    await sendEmail(data.recipientEmail, subject, emailTemplate)

    req.session.user = verifiedSubscriber

    return res.redirect(returnURL.pathname + returnURL.search)
  }
  // Update existing user's FxA data
  const { accessToken, refreshToken } = fxaUser
  await updateFxAData(existingUser, accessToken, refreshToken, fxaProfileData)

  res.redirect(returnURL.pathname + returnURL.search)
}

/**
 * Controller to trigger a logout for user
 *
 * @param {object} req Contains session.user
 * @param {object} res Redirects to homepage
 */
async function logout (req, res) {
  const subscriber = req.session?.user
  log.info('logout', subscriber?.primary_email)

  // delete oauth session info in database
  await removeFxAData(subscriber)

  // clear session cache
  req.session.destroy(s => {
    delete req.session
    res.redirect('/')
  })
}

export { init, confirmed, logout }

1	/* This Source Code Form is subject to the terms of the Mozilla Public
2	* License, v. 2.0. If a copy of the MPL was not distributed with this
3	* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
4
5	import { URL } from 'url'
6	import { randomBytes } from 'crypto'
7
8	import AppConstants from '../app-constants.js'
9	import {
10	getSubscriberByEmail,
11	removeFxAData,
12	updateFxAData
13	} from '../db/tables/subscribers.js'
14	import { addSubscriber } from '../db/tables/email_addresses.js'
15
16	import { getTemplate } from '../views/emails/email-2022.js'
17	import {
18	signupReportEmailPartial
19	} from '../views/emails/email-signup-report.js'
20
21	import { getBreachesForEmail } from '../utils/hibp.js'
22	import { getMessage } from '../utils/fluent.js'
23	import { getProfileData, FxAOAuthClient, getSha1 } from '../utils/fxa.js'
24	import { getEmailCtaHref, sendEmail } from '../utils/email.js'
25	import { UnauthorizedError } from '../utils/error.js'
26	import mozlog from '../utils/log.js'
27
28	const { SERVER_URL } = AppConstants	×
29
30	const log = mozlog('controllers.auth')	×
31
32	function init (req, res, next, client = FxAOAuthClient) {	×
33	// Set a random state string in a cookie so that we can verify
34	// the user when they're redirected back to us after auth.
35	const state = randomBytes(40).toString('hex')	×
36	req.session.state = state	×
37	const url = new URL(client.code.getUri({ state }))	×
38	const fxaParams = new URL(req.url, SERVER_URL)	×
39
40	req.session.utmContents = {}	×
41	url.searchParams.append('prompt', 'login')	×
42	url.searchParams.append('max_age', 0)	×
43	url.searchParams.append('access_type', 'offline')	×
44	url.searchParams.append('action', 'email')	×
45
46	for (const param of fxaParams.searchParams.keys()) {	×
47	url.searchParams.append(param, fxaParams.searchParams.get(param))	×
48	}
49
50	res.redirect(url)	×
51	}
52
53	async function confirmed (req, res, next, client = FxAOAuthClient) {	×
54	if (!req.session.state) {	×
55	log.error('oauth-invalid-session', 'req.session.state missing')	×
56	throw new UnauthorizedError(getMessage('oauth-invalid-session'))	×
57	}
58
59	if (req.session.state !== req.query.state) {	×
60	log.error('oauth-invalid-session', 'req.session does not match req.query')	×
61	throw new UnauthorizedError(getMessage('oauth-invalid-session'))	×
62	}
63
64	const fxaUser = await client.code.getToken(req.originalUrl, {	×
65	state: req.session.state
66	})
67	// Clear the session.state to clean up and avoid any replays
68	req.session.state = null	×
69	log.debug('fxa-confirmed-fxaUser', fxaUser)	×
70	const fxaProfileData = await getProfileData(fxaUser.accessToken)	×
71	log.debug('fxa-confirmed-profile-data', fxaProfileData)	×
72	const email = JSON.parse(fxaProfileData).email	×
73
74	const existingUser = await getSubscriberByEmail(email)	×
75	req.session.user = existingUser	×
76
77	const returnURL = new URL('user/breaches', SERVER_URL)	×
78	const originalURL = new URL(req.originalUrl, SERVER_URL)	×
79
80	for (const [key, value] of originalURL.searchParams.entries()) {	×
81	if (key.startsWith('utm_')) returnURL.searchParams.append(key, value)	×
82	}
83
84	// Check if user is signing up or signing in,
85	// then add new users to db and send email.
86	if (!existingUser) {	×
87	// req.session.newUser determines whether or not we show `fxa_new_user_bar`
88	// in template
89	req.session.newUser = true	×
90	const signupLanguage = req.locale	×
91	const verifiedSubscriber = await addSubscriber(	×
92	email,
93	signupLanguage,
94	fxaUser.accessToken,
95	fxaUser.refreshToken,
96	fxaProfileData
97	)
98
99	// Get breaches for email the user signed-up with
100	const allBreaches = req.app.locals.breaches	×
101	const unsafeBreachesForEmail = await getBreachesForEmail(	×
102	getSha1(email),
103	allBreaches,
104	true
105	)
106
107	// Send report email
108	const utmCampaignId = 'report'	×
109	const subject = unsafeBreachesForEmail?.length	×
110	? getMessage('email-subject-found-breaches')
111	: getMessage('email-subject-no-breaches')
112
113	const data = {	×
114	breachedEmail: email,
115	breachLogos: req.app.locals.breachLogoMap,
116	ctaHref: getEmailCtaHref(utmCampaignId, 'dashboard-cta'),
117	heading: getMessage('email-breach-summary'),
118	recipientEmail: email,
119	subscriberId: verifiedSubscriber,
120	unsafeBreachesForEmail,
121	utmCampaign: utmCampaignId
122	}
123	const emailTemplate = getTemplate(data, signupReportEmailPartial)	×
124
125	await sendEmail(data.recipientEmail, subject, emailTemplate)	×
126
127	req.session.user = verifiedSubscriber	×
128
129	return res.redirect(returnURL.pathname + returnURL.search)	×
130	}
131	// Update existing user's FxA data
132	const { accessToken, refreshToken } = fxaUser	×
133	await updateFxAData(existingUser, accessToken, refreshToken, fxaProfileData)	×
134
135	res.redirect(returnURL.pathname + returnURL.search)	×
136	}
137
138	/**
139	* Controller to trigger a logout for user
140	*
141	* @param {object} req Contains session.user
142	* @param {object} res Redirects to homepage
143	*/
144	async function logout (req, res) {
145	const subscriber = req.session?.user	×
146	log.info('logout', subscriber?.primary_email)	×
147
148	// delete oauth session info in database
149	await removeFxAData(subscriber)	×
150
151	// clear session cache
152	req.session.destroy(s => {	×
153	delete req.session	×
154	res.redirect('/')	×
155	})
156	}
157
158	export { init, confirmed, logout }

mozilla / blurts-server / #13117

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous