1aaf6302-d8cf-4943-bb96-5e86951c32a3

Build # 1aaf6302-d8cf-4943-bb96-5e86951c32a3

Build Type

circleci

Committed by Bess Sadler

Commit Message

Nil safe doi gsub

Pull Request Pull Request #1079: Nil safe collection title

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

1777 of 2063 relevant lines covered (86.14%)

100.37 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

73.42

/app/controllers/works_controller.rb

# frozen_string_literal: true

require "nokogiri"
require "open-uri"

# rubocop:disable Metrics/ClassLength
class WorksController < ApplicationController
  include ERB::Util
  around_action :rescue_aasm_error, only: [:approve, :withdraw, :resubmit, :validate, :create]

  skip_before_action :authenticate_user!
  before_action :authenticate_user!, unless: :public_request?

  ##
  # Public requests are requests that do not require authentication.
  # This is to enable PDC Discovery to index approved content via the RSS feed and
  # .json calls to individual works without needing to log in as a user.
  # Note that only approved works can be fetched for indexing.
  def public_request?
    return true if action_name == "index" && request.format.symbol == :rss
    return true if action_name == "show" && request.format.symbol == :json && Work.find(params[:id]).state == "approved"
    false
  end

  def index
    @works = Work.all
    respond_to do |format|
      format.html
      format.rss { render layout: false }
    end
  end

  # Renders the "step 0" information page before creating a new dataset
  def new
    if wizard_mode?
      render "new_submission"
    else
      @work = Work.new(created_by_user_id: current_user.id, collection: current_user.default_collection)
    end
  end

  def create
    # TODO: We need to process files submitted by the user in this method.
    # We currently do not and therefore there are not saved to the work.
    # See https://github.com/pulibrary/pdc_describe/issues/1041
    @work = Work.new(created_by_user_id: current_user.id, collection_id: params_collection_id, user_entered_doi: params["doi"].present?)
    @work.resource = FormToResourceService.convert(params, @work)
    if @work.valid?
      @work.draft!(current_user)
      redirect_to work_url(@work), notice: "Work was successfully created."
    else
      render :new, status: :unprocessable_entity
    end
  end

  # Creates the new dataset
  def new_submission
    default_collection_id = current_user.default_collection.id
    work = Work.new(created_by_user_id: current_user.id, collection_id: default_collection_id)
    work.resource = FormToResourceService.convert(params, work)
    work.draft!(current_user)
    redirect_to edit_work_path(work, wizard: true)
  end

  ##
  # Show the information for the dataset with the given id
  # When requested as .json, return the internal json resource
  def show
    @work = Work.find(params[:id])
    @changes =  WorkActivity.changes_for_work(@work.id)
    @messages = WorkActivity.messages_for_work(@work.id)

    respond_to do |format|
      format.html do
        # Ensure that the Work belongs to a Collection
        @collection = @work.collection
        raise(Work::InvalidCollectionError, "The Work #{@work.id} does not belong to any Collection") unless @collection

        @can_curate = current_user.can_admin?(@collection)
        @work.mark_new_notifications_as_read(current_user.id)
      end
      format.json { render json: @work.to_json }
    end
  end

  def file_list
    if params[:id] == "NONE"
      # This is a special case when we render the file list for a work being created
      # (i.e. it does not have an id just yet)
      render json: []
    else
      @work = Work.find(params[:id])
      render json: @work.uploads
    end
  end

  def resolve_doi
    @work = Work.find_by_doi(params[:doi])
    redirect_to @work
  end

  def resolve_ark
    @work = Work.find_by_ark(params[:ark])
    redirect_to @work
  end

  # GET /works/1/edit
  def edit
    @work = Work.find(params[:id])
    if current_user && @work.editable_by?(current_user)
      if @work.approved? && !@work.administered_by?(current_user)
        Honeybadger.notify("Can not edit work: #{@work.id} is approved but #{current_user} is not admin")
        redirect_to root_path, notice: I18n.t("works.uneditable.approved")
      else
        @uploads = @work.uploads
        @wizard_mode = wizard_mode?
        render "edit"
      end
    else
      Honeybadger.notify("Can not edit work: #{@work.id} is not editable by #{current_user}")
      redirect_to root_path, notice: I18n.t("works.uneditable.privs")
    end
  end

  def update
    @work = Work.find(params[:id])
    if current_user.blank? || !@work.editable_by?(current_user)
      Honeybadger.notify("Can not update work: #{@work.id} is not editable by #{current_user}")
      redirect_to root_path, notice: I18n.t("works.uneditable.privs")
    elsif !@work.editable_in_current_state?(current_user)
      Honeybadger.notify("Can not update work: #{@work.id} is not editable in current state by #{current_user}")
      redirect_to root_path, notice: I18n.t("works.uneditable.approved")
    else
      update_work
    end
  end

  # Prompt to select how to submit their files
  def attachment_select
    @work = Work.find(params[:id])
    @wizard_mode = true
  end

  # User selected a specific way to submit their files
  def attachment_selected
    @work = Work.find(params[:id])
    @wizard_mode = true
    @work.files_location = params["attachment_type"]
    @work.save!

    # create a directory for the work if the curator will need to move files by hand
    @work.s3_query_service.create_directory if @work.files_location != "file_upload"

    next_url = case @work.files_location
               when "file_upload"
                 work_file_upload_url(@work)
               when "file_cluster"
                 work_file_cluster_url(@work)
               else
                 work_file_other_url(@work)
               end
    redirect_to next_url
  end

  # Allow user to upload files directly
  def file_upload
    @work = Work.find(params[:id])
  end

  def file_uploaded
    @work = Work.find(params[:id])
    if pre_curation_uploads_param
      @work.pre_curation_uploads.attach(pre_curation_uploads_param)
      @work.save!
    end

    redirect_to(work_review_path)
  rescue StandardError => active_storage_error
    Rails.logger.error("Failed to attach the file uploads for the work #{@work.doi}: #{active_storage_error}")
    flash[:notice] = "Failed to attach the file uploads for the work #{@work.doi}: #{active_storage_error}. Please contact rdss@princeton.edu for assistance."

    redirect_to work_file_upload_path(@work)
  end

  # Allow user to indicate where their files are located in the PUL Research Cluster
  def file_cluster
    @work = Work.find(params[:id])
  end

  # Allow user to indicate where their files are located in the WWW
  def file_other
    @work = Work.find(params[:id])
  end

  def review
    @work = Work.find(params[:id])
    if request.method == "POST"
      @work.location_notes = params["location_notes"]
      @work.save!
    end
  end

  def validate
    @work = Work.find(params[:id])
    @work.submission_notes = params["submission_notes"]
    @uploads = @work.uploads
    @wizard_mode = true
    @work.complete_submission!(current_user)
    redirect_to user_url(current_user)
  end

  def approve
    @work = Work.find(params[:id])
    @work.approve!(current_user)
    redirect_to work_path(@work)
  end

  def withdraw
    @work = Work.find(params[:id])
    @work.withdraw!(current_user)
    redirect_to work_path(@work)
  end

  def resubmit
    @work = Work.find(params[:id])
    @work.resubmit!(current_user)
    redirect_to work_path(@work)
  end

  def assign_curator
    work = Work.find(params[:id])
    work.change_curator(params[:uid], current_user)
    if work.errors.count > 0
      render json: { errors: work.errors.map(&:type) }, status: :bad_request
    else
      render json: {}
    end
  rescue => ex
    Rails.logger.error("Error changing curator for work: #{work.id}. Exception: #{ex.message}")
    render json: { errors: ["Cannot save dataset"] }, status: :bad_request
  end

  def add_message
    work = Work.find(params[:id])
    if params["new-message"].present?
      new_message_param = params["new-message"]
      sanitized_new_message = html_escape(new_message_param)

      work.add_message(sanitized_new_message, current_user.id)
    end
    redirect_to work_path(id: params[:id])
  end

  def add_provenance_note
    work = Work.find(params[:id])
    if params["new-provenance-note"].present?
      new_date = params["new-provenance-date"]
      new_note = html_escape(params["new-provenance-note"])

      work.add_provenance_note(new_date, new_note, current_user.id)
    end
    redirect_to work_path(id: params[:id])
  end

  # Outputs the Datacite XML representation of the work
  def datacite
    work = Work.find(params[:id])
    render xml: work.to_xml
  end

  def datacite_validate
    @errors = []
    @work = Work.find(params[:id])
    datacite_xml = Nokogiri::XML(@work.to_xml)
    schema_location = Rails.root.join("config", "schema")
    Dir.chdir(schema_location) do
      xsd = Nokogiri::XML::Schema(File.read("datacite_4_4.xsd"))
      xsd.validate(datacite_xml).each do |error|
        @errors << error
      end
    end
  end

  def readme_select
    @work = Work.find(params[:id])
    readme = Readme.new(@work)
    @readme = readme.file_name
    @wizard = true
  end

  def readme_uploaded
    @work = Work.find(params[:id])
    @wizard = true
    readme = Readme.new(@work)
    readme_error = readme.attach(readme_file_param)
    if readme_error.nil?
      redirect_to work_attachment_select_url(@work)
    else
      flash[:notice] = readme_error
      redirect_to work_readme_select_url(@work)
    end
  end

  private

    def work_params
      params[:work] || params
    end

    def patch_params
      return {} unless params.key?(:patch)

      params[:patch]
    end

    def pre_curation_uploads_param
      return if patch_params.nil?

      patch_params[:pre_curation_uploads_added]
    end

    def readme_file_param
      return if patch_params.nil?

      patch_params[:readme_file]
    end

    def rescue_aasm_error
      yield
    rescue AASM::InvalidTransition => error
      message = error.message
      if @work.errors.count > 0
        message = @work.errors.to_a.join(", ")
      end
      Honeybadger.notify("Invalid #{@work.current_transition}: #{error.message} errors: #{message}")
      @errors = ["Cannot #{@work.current_transition}: #{message}"]
      render error_action, status: :unprocessable_entity
    end

    def error_action
      if action_name == "create"
        :new
      elsif action_name == "validate"
        :edit
      else
        :show
      end
    end

    def wizard_mode?
      params[:wizard] == "true"
    end

    def update_work
      @wizard_mode = wizard_mode?
      upload_service = WorkUploadsEditService.new(@work, current_user)
      if @work.approved?
        upload_keys = work_params[:deleted_uploads] || []
        deleted_uploads = upload_service.find_post_curation_uploads(upload_keys: upload_keys)

        return head(:forbidden) unless deleted_uploads.empty?
      else
        @work = upload_service.update_precurated_file_list(added_files_param, deleted_files_param)
      end

      process_updates
    end

    def update_params
      {
        collection_id: params_collection_id,
        resource: FormToResourceService.convert(params, @work)
      }
    end

    def added_files_param
      Array(work_params[:pre_curation_uploads_added])
    end

    def deleted_files_param
      deleted_count = (work_params["deleted_files_count"] || "0").to_i
      (1..deleted_count).map { |i| work_params["deleted_file_#{i}"] }.select(&:present?)
    end

    def process_updates
      resource_before = @work.resource
      if @work.update(update_params)

        resource_compare = ResourceCompareService.new(resource_before, update_params[:resource])
        @work.log_changes(resource_compare, current_user.id)

        if @wizard_mode
          redirect_to work_readme_select_url(@work)
        else
          redirect_to work_url(@work), notice: "Work was successfully updated."
        end
      else
        @uploads = @work.uploads
        render :edit, status: :unprocessable_entity
      end
    end

    def params_collection_id
      # Do not allow a nil for the collection id
      @params_collection_id ||= begin
        collection_id = params[:collection_id]
        if collection_id.blank?
          collection_id = current_user.default_collection.id
          Honeybadger.notify("We got a nil collection as part of the parameters #{params} #{request}")
        end
        collection_id
      end
    end
end
# rubocop:enable Metrics/ClassLength

1	# frozen_string_literal: true
2
3	require "nokogiri"	1✔
4	require "open-uri"	1✔
5
6	# rubocop:disable Metrics/ClassLength
7	class WorksController < ApplicationController	1✔
8	include ERB::Util	1✔
9	around_action :rescue_aasm_error, only: [:approve, :withdraw, :resubmit, :validate, :create]	1✔
10
11	skip_before_action :authenticate_user!	1✔
12	before_action :authenticate_user!, unless: :public_request?	1✔
13
14	##
15	# Public requests are requests that do not require authentication.
16	# This is to enable PDC Discovery to index approved content via the RSS feed and
17	# .json calls to individual works without needing to log in as a user.
18	# Note that only approved works can be fetched for indexing.
19	def public_request?	1✔
20	return true if action_name == "index" && request.format.symbol == :rss	236✔
21	return true if action_name == "show" && request.format.symbol == :json && Work.find(params[:id]).state == "approved"	235✔
22	false	234✔
23	end
24
25	def index	1✔
26	@works = Work.all	2✔
27	respond_to do \|format\|	2✔
28	format.html	2✔
29	format.rss { render layout: false }	3✔
30	end
31	end
32
33	# Renders the "step 0" information page before creating a new dataset
34	def new	1✔
35	if wizard_mode?	19✔
36	render "new_submission"	4✔
37	else
38	@work = Work.new(created_by_user_id: current_user.id, collection: current_user.default_collection)	15✔
39	end
40	end
41
42	def create	1✔
43	# TODO: We need to process files submitted by the user in this method.
44	# We currently do not and therefore there are not saved to the work.
45	# See https://github.com/pulibrary/pdc_describe/issues/1041
46	@work = Work.new(created_by_user_id: current_user.id, collection_id: params_collection_id, user_entered_doi: params["doi"].present?)	17✔
47	@work.resource = FormToResourceService.convert(params, @work)	17✔
48	if @work.valid?	17✔
49	@work.draft!(current_user)	15✔
50	redirect_to work_url(@work), notice: "Work was successfully created."	15✔
51	else
52	render :new, status: :unprocessable_entity	2✔
53	end
54	end
55
56	# Creates the new dataset
57	def new_submission	1✔
58	default_collection_id = current_user.default_collection.id	4✔
59	work = Work.new(created_by_user_id: current_user.id, collection_id: default_collection_id)	4✔
60	work.resource = FormToResourceService.convert(params, work)	4✔
61	work.draft!(current_user)	4✔
62	redirect_to edit_work_path(work, wizard: true)	4✔
63	end
64
65	##
66	# Show the information for the dataset with the given id
67	# When requested as .json, return the internal json resource
68	def show	1✔
69	@work = Work.find(params[:id])	42✔
70	@changes = WorkActivity.changes_for_work(@work.id)	42✔
71	@messages = WorkActivity.messages_for_work(@work.id)	42✔
72
73	respond_to do \|format\|	42✔
74	format.html do	42✔
75	# Ensure that the Work belongs to a Collection
76	@collection = @work.collection	41✔
77	raise(Work::InvalidCollectionError, "The Work #{@work.id} does not belong to any Collection") unless @collection	41✔
78
79	@can_curate = current_user.can_admin?(@collection)	40✔
80	@work.mark_new_notifications_as_read(current_user.id)	40✔
81	end
82	format.json { render json: @work.to_json }	43✔
83	end
84	end
85
86	def file_list	1✔
87	if params[:id] == "NONE"	65✔
88	# This is a special case when we render the file list for a work being created
89	# (i.e. it does not have an id just yet)
90	render json: []	17✔
91	else
92	@work = Work.find(params[:id])	48✔
93	render json: @work.uploads	48✔
94	end
95	end
96
97	def resolve_doi	1✔
98	@work = Work.find_by_doi(params[:doi])	×
99	redirect_to @work	×
100	end
101
102	def resolve_ark	1✔
103	@work = Work.find_by_ark(params[:ark])	×
104	redirect_to @work	×
105	end
106
107	# GET /works/1/edit
108	def edit	1✔
109	@work = Work.find(params[:id])	16✔
110	if current_user && @work.editable_by?(current_user)	16✔
111	if @work.approved? && !@work.administered_by?(current_user)	14✔
112	Honeybadger.notify("Can not edit work: #{@work.id} is approved but #{current_user} is not admin")	×
113	redirect_to root_path, notice: I18n.t("works.uneditable.approved")	×
114	else
115	@uploads = @work.uploads	14✔
116	@wizard_mode = wizard_mode?	14✔
117	render "edit"	14✔
118	end
119	else
120	Honeybadger.notify("Can not edit work: #{@work.id} is not editable by #{current_user}")	2✔
121	redirect_to root_path, notice: I18n.t("works.uneditable.privs")	2✔
122	end
123	end
124
125	def update	1✔
126	@work = Work.find(params[:id])	10✔
127	if current_user.blank? \|\| !@work.editable_by?(current_user)	10✔
128	Honeybadger.notify("Can not update work: #{@work.id} is not editable by #{current_user}")	×
129	redirect_to root_path, notice: I18n.t("works.uneditable.privs")	×
130	elsif !@work.editable_in_current_state?(current_user)	10✔
131	Honeybadger.notify("Can not update work: #{@work.id} is not editable in current state by #{current_user}")	×
132	redirect_to root_path, notice: I18n.t("works.uneditable.approved")	×
133	else
134	update_work	10✔
135	end
136	end
137
138	# Prompt to select how to submit their files
139	def attachment_select	1✔
140	@work = Work.find(params[:id])	6✔
141	@wizard_mode = true	6✔
142	end
143
144	# User selected a specific way to submit their files
145	def attachment_selected	1✔
146	@work = Work.find(params[:id])	5✔
147	@wizard_mode = true	5✔
148	@work.files_location = params["attachment_type"]	5✔
149	@work.save!	5✔
150
151	# create a directory for the work if the curator will need to move files by hand
152	@work.s3_query_service.create_directory if @work.files_location != "file_upload"	5✔
153
154	next_url = case @work.files_location	5✔
155	when "file_upload"
156	work_file_upload_url(@work)	1✔
157	when "file_cluster"
158	work_file_cluster_url(@work)	×
159	else
160	work_file_other_url(@work)	4✔
161	end
162	redirect_to next_url	5✔
163	end
164
165	# Allow user to upload files directly
166	def file_upload	1✔
167	@work = Work.find(params[:id])	1✔
168	end
169
170	def file_uploaded	1✔
171	@work = Work.find(params[:id])	1✔
172	if pre_curation_uploads_param	1✔
173	@work.pre_curation_uploads.attach(pre_curation_uploads_param)	×
174	@work.save!	×
175	end
176
177	redirect_to(work_review_path)	1✔
178	rescue StandardError => active_storage_error
179	Rails.logger.error("Failed to attach the file uploads for the work #{@work.doi}: #{active_storage_error}")	×
180	flash[:notice] = "Failed to attach the file uploads for the work #{@work.doi}: #{active_storage_error}. Please contact rdss@princeton.edu for assistance."	×
181
182	redirect_to work_file_upload_path(@work)	×
183	end
184
185	# Allow user to indicate where their files are located in the PUL Research Cluster
186	def file_cluster	1✔
187	@work = Work.find(params[:id])	×
188	end
189
190	# Allow user to indicate where their files are located in the WWW
191	def file_other	1✔
192	@work = Work.find(params[:id])	4✔
193	end
194
195	def review	1✔
196	@work = Work.find(params[:id])	5✔
197	if request.method == "POST"	5✔
198	@work.location_notes = params["location_notes"]	4✔
199	@work.save!	4✔
200	end
201	end
202
203	def validate	1✔
204	@work = Work.find(params[:id])	20✔
205	@work.submission_notes = params["submission_notes"]	20✔
206	@uploads = @work.uploads	20✔
207	@wizard_mode = true	20✔
208	@work.complete_submission!(current_user)	20✔
209	redirect_to user_url(current_user)	19✔
210	end
211
212	def approve	1✔
213	@work = Work.find(params[:id])	4✔
214	@work.approve!(current_user)	4✔
215	redirect_to work_path(@work)	4✔
216	end
217
218	def withdraw	1✔
219	@work = Work.find(params[:id])	×
220	@work.withdraw!(current_user)	×
221	redirect_to work_path(@work)	×
222	end
223
224	def resubmit	1✔
225	@work = Work.find(params[:id])	×
226	@work.resubmit!(current_user)	×
227	redirect_to work_path(@work)	×
228	end
229
230	def assign_curator	1✔
231	work = Work.find(params[:id])	×
232	work.change_curator(params[:uid], current_user)	×
233	if work.errors.count > 0	×
234	render json: { errors: work.errors.map(&:type) }, status: :bad_request	×
235	else
236	render json: {}	×
237	end
238	rescue => ex
239	Rails.logger.error("Error changing curator for work: #{work.id}. Exception: #{ex.message}")	×
240	render json: { errors: ["Cannot save dataset"] }, status: :bad_request	×
241	end
242
243	def add_message	1✔
244	work = Work.find(params[:id])	×
245	if params["new-message"].present?	×
246	new_message_param = params["new-message"]	×
247	sanitized_new_message = html_escape(new_message_param)	×
248
249	work.add_message(sanitized_new_message, current_user.id)	×
250	end
251	redirect_to work_path(id: params[:id])	×
252	end
253
254	def add_provenance_note	1✔
255	work = Work.find(params[:id])	×
256	if params["new-provenance-note"].present?	×
257	new_date = params["new-provenance-date"]	×
258	new_note = html_escape(params["new-provenance-note"])	×
259
260	work.add_provenance_note(new_date, new_note, current_user.id)	×
261	end
262	redirect_to work_path(id: params[:id])	×
263	end
264
265	# Outputs the Datacite XML representation of the work
266	def datacite	1✔
267	work = Work.find(params[:id])	×
268	render xml: work.to_xml	×
269	end
270
271	def datacite_validate	1✔
272	@errors = []	×
273	@work = Work.find(params[:id])	×
274	datacite_xml = Nokogiri::XML(@work.to_xml)	×
275	schema_location = Rails.root.join("config", "schema")	×
276	Dir.chdir(schema_location) do	×
277	xsd = Nokogiri::XML::Schema(File.read("datacite_4_4.xsd"))	×
278	xsd.validate(datacite_xml).each do \|error\|	×
279	@errors << error	×
280	end
281	end
282	end
283
284	def readme_select	1✔
285	@work = Work.find(params[:id])	7✔
286	readme = Readme.new(@work)	7✔
287	@readme = readme.file_name	7✔
288	@wizard = true	7✔
289	end
290
291	def readme_uploaded	1✔
292	@work = Work.find(params[:id])	6✔
293	@wizard = true	6✔
294	readme = Readme.new(@work)	6✔
295	readme_error = readme.attach(readme_file_param)	6✔
296	if readme_error.nil?	6✔
297	redirect_to work_attachment_select_url(@work)	6✔
298	else
299	flash[:notice] = readme_error	×
300	redirect_to work_readme_select_url(@work)	×
301	end
302	end
303
304	private	1✔
305
306	def work_params	1✔
307	params[:work] \|\| params	20✔
308	end
309
310	def patch_params	1✔
311	return {} unless params.key?(:patch)	14✔
312
313	params[:patch]	8✔
314	end
315
316	def pre_curation_uploads_param	1✔
317	return if patch_params.nil?	1✔
318
319	patch_params[:pre_curation_uploads_added]	1✔
320	end
321
322	def readme_file_param	1✔
323	return if patch_params.nil?	6✔
324
325	patch_params[:readme_file]	6✔
326	end
327
328	def rescue_aasm_error	1✔
329	yield	41✔
330	rescue AASM::InvalidTransition => error
331	message = error.message	1✔
332	if @work.errors.count > 0	1✔
333	message = @work.errors.to_a.join(", ")	1✔
334	end
335	Honeybadger.notify("Invalid #{@work.current_transition}: #{error.message} errors: #{message}")	1✔
336	@errors = ["Cannot #{@work.current_transition}: #{message}"]	1✔
337	render error_action, status: :unprocessable_entity	1✔
338	end
339
340	def error_action	1✔
341	if action_name == "create"	1✔
342	:new	×
343	elsif action_name == "validate"	1✔
344	:edit	1✔
345	else
346	:show	×
347	end
348	end
349
350	def wizard_mode?	1✔
351	params[:wizard] == "true"	43✔
352	end
353
354	def update_work	1✔
355	@wizard_mode = wizard_mode?	10✔
356	upload_service = WorkUploadsEditService.new(@work, current_user)	10✔
357	if @work.approved?	10✔
358	upload_keys = work_params[:deleted_uploads] \|\| []	×
359	deleted_uploads = upload_service.find_post_curation_uploads(upload_keys: upload_keys)	×
360
361	return head(:forbidden) unless deleted_uploads.empty?	×
362	else
363	@work = upload_service.update_precurated_file_list(added_files_param, deleted_files_param)	10✔
364	end
365
366	process_updates	10✔
367	end
368
369	def update_params	1✔
370	{
371	collection_id: params_collection_id,	20✔
372	resource: FormToResourceService.convert(params, @work)
373	}
374	end
375
376	def added_files_param	1✔
377	Array(work_params[:pre_curation_uploads_added])	10✔
378	end
379
380	def deleted_files_param	1✔
381	deleted_count = (work_params["deleted_files_count"] \|\| "0").to_i	10✔
382	(1..deleted_count).map { \|i\| work_params["deleted_file_#{i}"] }.select(&:present?)	10✔
383	end
384
385	def process_updates	1✔
386	resource_before = @work.resource	10✔
387	if @work.update(update_params)	10✔
388
389	resource_compare = ResourceCompareService.new(resource_before, update_params[:resource])	10✔
390	@work.log_changes(resource_compare, current_user.id)	10✔
391
392	if @wizard_mode	10✔
393	redirect_to work_readme_select_url(@work)	6✔
394	else
395	redirect_to work_url(@work), notice: "Work was successfully updated."	4✔
396	end
397	else
398	@uploads = @work.uploads	×
399	render :edit, status: :unprocessable_entity	×
400	end
401	end
402
403	def params_collection_id	1✔
404	# Do not allow a nil for the collection id
405	@params_collection_id \|\|= begin	37✔
406	collection_id = params[:collection_id]	27✔
407	if collection_id.blank?	27✔
408	collection_id = current_user.default_collection.id	×
409	Honeybadger.notify("We got a nil collection as part of the parameters #{params} #{request}")	×
410	end
411	collection_id	27✔
412	end
413	end
414	end
415	# rubocop:enable Metrics/ClassLength

pulibrary / pdc_describe / 1aaf6302-d8cf-4943-bb96-5e86951c32a3

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous