#4519

pending completion

Build # #4519

Build Type

push

coveralls-python

Committed by

web-flow

Commit Message

[no_severity] Drop constraint on very old bugs (#2066)

Run Details

641 of 3228 branches covered (19.86%)

1817 of 8043 relevant lines covered (22.59%)

0.23 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/bugbot/rules/workflow/no_severity.py

# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this file,
# You can obtain one at http://mozilla.org/MPL/2.0/.

import numpy
from libmozdata import utils as lmdutils

from bugbot import utils
from bugbot.bzcleaner import BzCleaner
from bugbot.escalation import Escalation
from bugbot.nag_me import Nag
from bugbot.round_robin import RoundRobin


class NoSeverity(BzCleaner, Nag):
    def __init__(self, typ, inactivity_days: int = 4):
        """Constructor

        Args:
            typ: the mode that the rule should run with (first or second). Nag
                emails will be sent only if `typ` is second.
            inactivity_days: number of days that a bug should be inactive before
                being considered.
        """
        super(NoSeverity, self).__init__()
        assert typ in {"first", "second"}
        self.typ = typ
        self.lookup_first = utils.get_config(self.name(), "first-step", 2)
        self.lookup_second = utils.get_config(self.name(), "second-step", 4)
        self.escalation = Escalation(
            self.people,
            data=utils.get_config(self.name(), "escalation-{}".format(typ)),
            skiplist=utils.get_config("workflow", "supervisor_skiplist", []),
        )
        self.round_robin = RoundRobin.get_instance()
        self.components_skiplist = utils.get_config("workflow", "components_skiplist")
        self.activity_date = str(
            numpy.busday_offset(lmdutils.get_date("today"), -inactivity_days)
        )

    def description(self):
        return "Bugs without a severity or statuses set"

    def nag_template(self):
        return self.template()

    def nag_preamble(self):
        return """<p>
  <ul>
    <li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/policies/triage-bugzilla.html#why-triage">Why triage?</a></li>
    <li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/policies/triage-bugzilla.html#what-do-you-triage">What do you triage?</a></li>
    <li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/guides/priority.html">Priority definitions</a></li>
    <li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/guides/severity.html">Severty definitions</a></li>
  </ul>
</p>"""

    def get_extra_for_template(self):
        return {
            "nweeks": self.lookup_first if self.typ == "first" else self.lookup_second
        }

    def get_extra_for_needinfo_template(self):
        return self.get_extra_for_template()

    def get_extra_for_nag_template(self):
        return self.get_extra_for_template()

    def has_product_component(self):
        return True

    def ignore_meta(self):
        return True

    def columns(self):
        return ["component", "id", "summary"]

    def handle_bug(self, bug, data):
        if (
            # check if the product::component is in the list
            utils.check_product_component(self.components_skiplist, bug)
            or utils.get_last_no_bot_comment_date(bug) > self.activity_date
        ):
            return None
        return bug

    def get_mail_to_auto_ni(self, bug):
        if self.typ == "second":
            return None

        mail, nick = self.round_robin.get(bug, self.date)
        if mail and nick:
            return {"mail": mail, "nickname": nick}

        return None

    def set_people_to_nag(self, bug, buginfo):
        priority = "default"
        if not self.filter_bug(priority):
            return None

        # don't nag in the first step (just a ni is enough)
        if self.typ == "first":
            return bug

        owners = self.round_robin.get(bug, self.date, only_one=False, has_nick=False)
        real_owner = bug["triage_owner"]
        self.add_triage_owner(owners, real_owner=real_owner)
        if not self.add(owners, buginfo, priority=priority):
            self.add_no_manager(buginfo["id"])
        return bug

    def get_bz_params(self, date):
        fields = [
            "triage_owner",
            "flags",
            "comments.creator",
            "comments.creation_time",
        ]
        params = {
            "include_fields": fields,
            "keywords": "intermittent-failure",
            "keywords_type": "nowords",
            "email2": "wptsync@mozilla.bugs",
            "emailreporter2": "1",
            "emailtype2": "notequals",
            "resolution": "---",
            "f31": "bug_type",
            "o31": "equals",
            "v31": "defect",
            "f32": "flagtypes.name",
            "o32": "notsubstring",
            "v32": "needinfo?",
            "f33": "bug_severity",
            "o33": "anyexact",
            "v33": "--, n/a",
            # This is temporary, it should be removed, see: https://github.com/mozilla/bugbot/issues/1889
            "n34": "1",
            "f34": "longdesc",
            "o34": "substring",
            "v34": "Change performed by the [Move to Bugzilla add-on](https://addons.mozilla.org/en-US/firefox/addon/move-to-bugzilla/).",
        }
        self.date = lmdutils.get_date_ymd(date)
        first = f"-{self.lookup_first * 7}d"
        second = f"-{self.lookup_second * 7}d"
        if self.typ == "first":
            # TODO: change this when https://bugzilla.mozilla.org/1543984 will be fixed
            # Here we have to get bugs where product/component have been set (bug has been triaged)
            # between 4 and 2 weeks
            # If the product/component never changed after bug creation, we need to get them too
            # (second < p < first && c < first) ||
            # (second < c < first && p < first) ||
            # ((second < creation < first) && pc never changed)
            params.update(
                {
                    "f2": "flagtypes.name",
                    "o2": "notequals",
                    "v2": "needinfo?",
                    "j3": "OR",
                    "f3": "OP",
                    "j4": "AND",
                    "f4": "OP",
                    "n5": 1,  # we use a negation here to be sure that no change after first
                    "f5": "product",
                    "o5": "changedafter",
                    "v5": first,
                    "f6": "product",  # here the bug has changed
                    "o6": "changedafter",
                    "v6": second,
                    "n7": 1,
                    "f7": "component",
                    "o7": "changedafter",
                    "v7": first,
                    "f8": "CP",
                    "j9": "AND",
                    "f9": "OP",
                    "n10": 1,
                    "f10": "component",
                    "o10": "changedafter",
                    "v10": first,
                    "f11": "component",
                    "o11": "changedafter",
                    "v11": second,
                    "n12": 1,
                    "f12": "product",
                    "o12": "changedafter",
                    "v12": first,
                    "f13": "CP",
                    "j14": "AND",
                    "f14": "OP",
                    "f15": "creation_ts",
                    "o15": "lessthaneq",
                    "v15": first,
                    "f16": "creation_ts",
                    "o16": "greaterthan",
                    "v16": second,
                    "n17": 1,
                    "f17": "product",
                    "o17": "everchanged",
                    "n18": 1,
                    "f18": "component",
                    "o18": "everchanged",
                    "f19": "CP",
                    "j20": "OR",
                    "f20": "OP",
                    "f21": "bug_severity",
                    "o21": "changedfrom",
                    "v21": "critical",
                    "f22": "bug_severity",
                    "o22": "changedfrom",
                    "v22": "major",
                    "f23": "bug_severity",
                    "o23": "changedfrom",
                    "v23": "blocker",
                    "f24": "CP",
                    "f30": "CP",
                }
            )
        else:
            params.update(
                {
                    "j2": "OR",
                    "f2": "OP",
                    "j3": "AND",
                    "f3": "OP",
                    "f4": "product",
                    "o4": "changedbefore",
                    "v4": second,
                    "n5": 1,
                    "f5": "product",
                    "o5": "changedafter",
                    "v5": second,
                    "n6": 1,
                    "f6": "component",
                    "o6": "changedafter",
                    "v6": second,
                    "f7": "CP",
                    "j8": "AND",
                    "f8": "OP",
                    "f9": "component",
                    "o9": "changedbefore",
                    "v9": second,
                    "n10": 1,
                    "f10": "product",
                    "o10": "changedafter",
                    "v10": second,
                    "n11": 1,
                    "f11": "component",
                    "o11": "changedafter",
                    "v11": second,
                    "f12": "CP",
                    "j13": "AND",
                    "f13": "OP",
                    "f14": "creation_ts",
                    "o14": "lessthaneq",
                    "v14": second,
                    "n15": 1,
                    "f15": "product",
                    "o15": "everchanged",
                    "n16": 1,
                    "f16": "component",
                    "o16": "everchanged",
                    "f17": "CP",
                    "f18": "CP",
                    "n20": 1,
                    "j20": "OR",
                    "f20": "OP",
                    "f21": "bug_severity",
                    "o21": "changedfrom",
                    "v21": "critical",
                    "f22": "bug_severity",
                    "o22": "changedfrom",
                    "v22": "major",
                    "f23": "bug_severity",
                    "o23": "changedfrom",
                    "v23": "blocker",
                    "f30": "CP",
                }
            )

        return params


if __name__ == "__main__":
    NoSeverity("first").run()
    NoSeverity("second").run()

1	# This Source Code Form is subject to the terms of the Mozilla Public
2	# License, v. 2.0. If a copy of the MPL was not distributed with this file,
3	# You can obtain one at http://mozilla.org/MPL/2.0/.
4
5	import numpy	×
6	from libmozdata import utils as lmdutils	×
7
8	from bugbot import utils	×
9	from bugbot.bzcleaner import BzCleaner	×
10	from bugbot.escalation import Escalation	×
11	from bugbot.nag_me import Nag	×
12	from bugbot.round_robin import RoundRobin	×
13
14
15	class NoSeverity(BzCleaner, Nag):	×
16	def __init__(self, typ, inactivity_days: int = 4):	×
17	"""Constructor
18
19	Args:
20	typ: the mode that the rule should run with (first or second). Nag
21	emails will be sent only if `typ` is second.
22	inactivity_days: number of days that a bug should be inactive before
23	being considered.
24	"""
25	super(NoSeverity, self).__init__()	×
26	assert typ in {"first", "second"}	×
27	self.typ = typ	×
28	self.lookup_first = utils.get_config(self.name(), "first-step", 2)	×
29	self.lookup_second = utils.get_config(self.name(), "second-step", 4)	×
30	self.escalation = Escalation(	×
31	self.people,
32	data=utils.get_config(self.name(), "escalation-{}".format(typ)),
33	skiplist=utils.get_config("workflow", "supervisor_skiplist", []),
34	)
35	self.round_robin = RoundRobin.get_instance()	×
36	self.components_skiplist = utils.get_config("workflow", "components_skiplist")	×
37	self.activity_date = str(	×
38	numpy.busday_offset(lmdutils.get_date("today"), -inactivity_days)
39	)
40
41	def description(self):	×
42	return "Bugs without a severity or statuses set"	×
43
44	def nag_template(self):	×
45	return self.template()	×
46
47	def nag_preamble(self):	×
48	return """<p>	×
49	<ul>
50	<li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/policies/triage-bugzilla.html#why-triage">Why triage?</a></li>
51	<li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/policies/triage-bugzilla.html#what-do-you-triage">What do you triage?</a></li>
52	<li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/guides/priority.html">Priority definitions</a></li>
53	<li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/guides/severity.html">Severty definitions</a></li>
54	</ul>
55	</p>"""
56
57	def get_extra_for_template(self):	×
58	return {	×
59	"nweeks": self.lookup_first if self.typ == "first" else self.lookup_second
60	}
61
62	def get_extra_for_needinfo_template(self):	×
63	return self.get_extra_for_template()	×
64
65	def get_extra_for_nag_template(self):	×
66	return self.get_extra_for_template()	×
67
68	def has_product_component(self):	×
69	return True	×
70
71	def ignore_meta(self):	×
72	return True	×
73
74	def columns(self):	×
75	return ["component", "id", "summary"]	×
76
77	def handle_bug(self, bug, data):	×
78	if (	×
79	# check if the product::component is in the list
80	utils.check_product_component(self.components_skiplist, bug)
81	or utils.get_last_no_bot_comment_date(bug) > self.activity_date
82	):
83	return None	×
84	return bug	×
85
86	def get_mail_to_auto_ni(self, bug):	×
87	if self.typ == "second":	×
88	return None	×
89
90	mail, nick = self.round_robin.get(bug, self.date)	×
91	if mail and nick:	×
92	return {"mail": mail, "nickname": nick}	×
93
94	return None	×
95
96	def set_people_to_nag(self, bug, buginfo):	×
97	priority = "default"	×
98	if not self.filter_bug(priority):	×
99	return None	×
100
101	# don't nag in the first step (just a ni is enough)
102	if self.typ == "first":	×
103	return bug	×
104
105	owners = self.round_robin.get(bug, self.date, only_one=False, has_nick=False)	×
106	real_owner = bug["triage_owner"]	×
107	self.add_triage_owner(owners, real_owner=real_owner)	×
108	if not self.add(owners, buginfo, priority=priority):	×
109	self.add_no_manager(buginfo["id"])	×
110	return bug	×
111
112	def get_bz_params(self, date):	×
113	fields = [	×
114	"triage_owner",
115	"flags",
116	"comments.creator",
117	"comments.creation_time",
118	]
119	params = {	×
120	"include_fields": fields,
121	"keywords": "intermittent-failure",
122	"keywords_type": "nowords",
123	"email2": "wptsync@mozilla.bugs",
124	"emailreporter2": "1",
125	"emailtype2": "notequals",
126	"resolution": "---",
127	"f31": "bug_type",
128	"o31": "equals",
129	"v31": "defect",
130	"f32": "flagtypes.name",
131	"o32": "notsubstring",
132	"v32": "needinfo?",
133	"f33": "bug_severity",
134	"o33": "anyexact",
135	"v33": "--, n/a",
136	# This is temporary, it should be removed, see: https://github.com/mozilla/bugbot/issues/1889
137	"n34": "1",
138	"f34": "longdesc",
139	"o34": "substring",
140	"v34": "Change performed by the [Move to Bugzilla add-on](https://addons.mozilla.org/en-US/firefox/addon/move-to-bugzilla/).",
141	}
142	self.date = lmdutils.get_date_ymd(date)	×
143	first = f"-{self.lookup_first * 7}d"	×
144	second = f"-{self.lookup_second * 7}d"	×
145	if self.typ == "first":	×
146	# TODO: change this when https://bugzilla.mozilla.org/1543984 will be fixed
147	# Here we have to get bugs where product/component have been set (bug has been triaged)
148	# between 4 and 2 weeks
149	# If the product/component never changed after bug creation, we need to get them too
150	# (second < p < first && c < first) \|\|
151	# (second < c < first && p < first) \|\|
152	# ((second < creation < first) && pc never changed)
153	params.update(	×
154	{
155	"f2": "flagtypes.name",
156	"o2": "notequals",
157	"v2": "needinfo?",
158	"j3": "OR",
159	"f3": "OP",
160	"j4": "AND",
161	"f4": "OP",
162	"n5": 1, # we use a negation here to be sure that no change after first
163	"f5": "product",
164	"o5": "changedafter",
165	"v5": first,
166	"f6": "product", # here the bug has changed
167	"o6": "changedafter",
168	"v6": second,
169	"n7": 1,
170	"f7": "component",
171	"o7": "changedafter",
172	"v7": first,
173	"f8": "CP",
174	"j9": "AND",
175	"f9": "OP",
176	"n10": 1,
177	"f10": "component",
178	"o10": "changedafter",
179	"v10": first,
180	"f11": "component",
181	"o11": "changedafter",
182	"v11": second,
183	"n12": 1,
184	"f12": "product",
185	"o12": "changedafter",
186	"v12": first,
187	"f13": "CP",
188	"j14": "AND",
189	"f14": "OP",
190	"f15": "creation_ts",
191	"o15": "lessthaneq",
192	"v15": first,
193	"f16": "creation_ts",
194	"o16": "greaterthan",
195	"v16": second,
196	"n17": 1,
197	"f17": "product",
198	"o17": "everchanged",
199	"n18": 1,
200	"f18": "component",
201	"o18": "everchanged",
202	"f19": "CP",
203	"j20": "OR",
204	"f20": "OP",
205	"f21": "bug_severity",
206	"o21": "changedfrom",
207	"v21": "critical",
208	"f22": "bug_severity",
209	"o22": "changedfrom",
210	"v22": "major",
211	"f23": "bug_severity",
212	"o23": "changedfrom",
213	"v23": "blocker",
214	"f24": "CP",
215	"f30": "CP",
216	}
217	)
218	else:
219	params.update(	×
220	{
221	"j2": "OR",
222	"f2": "OP",
223	"j3": "AND",
224	"f3": "OP",
225	"f4": "product",
226	"o4": "changedbefore",
227	"v4": second,
228	"n5": 1,
229	"f5": "product",
230	"o5": "changedafter",
231	"v5": second,
232	"n6": 1,
233	"f6": "component",
234	"o6": "changedafter",
235	"v6": second,
236	"f7": "CP",
237	"j8": "AND",
238	"f8": "OP",
239	"f9": "component",
240	"o9": "changedbefore",
241	"v9": second,
242	"n10": 1,
243	"f10": "product",
244	"o10": "changedafter",
245	"v10": second,
246	"n11": 1,
247	"f11": "component",
248	"o11": "changedafter",
249	"v11": second,
250	"f12": "CP",
251	"j13": "AND",
252	"f13": "OP",
253	"f14": "creation_ts",
254	"o14": "lessthaneq",
255	"v14": second,
256	"n15": 1,
257	"f15": "product",
258	"o15": "everchanged",
259	"n16": 1,
260	"f16": "component",
261	"o16": "everchanged",
262	"f17": "CP",
263	"f18": "CP",
264	"n20": 1,
265	"j20": "OR",
266	"f20": "OP",
267	"f21": "bug_severity",
268	"o21": "changedfrom",
269	"v21": "critical",
270	"f22": "bug_severity",
271	"o22": "changedfrom",
272	"v22": "major",
273	"f23": "bug_severity",
274	"o23": "changedfrom",
275	"v23": "blocker",
276	"f30": "CP",
277	}
278	)
279
280	return params	×
281
282
283	if __name__ == "__main__":	×
284	NoSeverity("first").run()	×
285	NoSeverity("second").run()	×

mozilla / relman-auto-nag / #4519

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous