901187442

pending completion

Build # 901187442

Build Type

Pull #3795

gitlab-ci

Committed by

mzedel

Commit Message

feat: increased chances of adopting our intended navigation patterns instead of unsupported browser navigation

Ticket: None
Changelog: None
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>

Pull Request Pull Request #3795: feat: increased chances of adopting our intended navigation patterns instead of unsupported browser navigation

Run Details

4389 of 6365 branches covered (68.96%)

5 of 5 new or added lines in 1 file covered. (100.0%)

1729 existing lines in 165 files now uncovered.

8274 of 10019 relevant lines covered (82.58%)

144.86 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

75.86

/src/js/components/auditlogs/eventdetails/deviceconfiguration.js

// Copyright 2021 Northern.tech AS
//
//    Licensed under the Apache License, Version 2.0 (the "License");
//    you may not use this file except in compliance with the License.
//    You may obtain a copy of the License at
//
//        http://www.apache.org/licenses/LICENSE-2.0
//
//    Unless required by applicable law or agreed to in writing, software
//    distributed under the License is distributed on an "AS IS" BASIS,
//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//    See the License for the specific language governing permissions and
//    limitations under the License.
import React, { useEffect } from 'react';
import { useDispatch, useSelector } from 'react-redux';

import { useTheme } from '@mui/material/styles';

import { getDeviceById } from '../../../actions/deviceActions';
import { getIdAttribute, getUserCapabilities } from '../../../selectors';
import Loader from '../../common/loader';
import DeviceDetails, { DetailInformation } from './devicedetails';

export const DeviceConfiguration = ({ item, onClose }) => {
  const { object = {} } = item;
  const { canReadDevices } = useSelector(getUserCapabilities);
  const device = useSelector(state => state.devices.byId[object.id]);
  const { attribute: idAttribute } = useSelector(getIdAttribute);
  const dispatch = useDispatch();

  const theme = useTheme();
  useEffect(() => {
    const { object } = item;
    if (!device && canReadDevices) {
      dispatch(getDeviceById(object.id));
    }
  }, []);

  if (canReadDevices && !device) {
    return <Loader show={true} />;
  }

  const { actor, change } = item;

  let config;
  try {
    config = JSON.parse(change);
  } catch (error) {
    config = { error: `An error occurred processing the changed config:\n${error}` };
  }

  return (
    <div className="flexbox column" style={{ margin: theme.spacing(3), minWidth: 'min-content' }}>
      {canReadDevices && <DeviceDetails device={device} idAttribute={idAttribute} onClose={onClose} />}
      <DetailInformation title="changed configuration" details={config} />
      <DetailInformation title="change" details={{ User: actor.email }} />
    </div>
  );
};

export default DeviceConfiguration;

1	// Copyright 2021 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14	import React, { useEffect } from 'react';
15	import { useDispatch, useSelector } from 'react-redux';
16
17	import { useTheme } from '@mui/material/styles';
18
19	import { getDeviceById } from '../../../actions/deviceActions';
20	import { getIdAttribute, getUserCapabilities } from '../../../selectors';
21	import Loader from '../../common/loader';
22	import DeviceDetails, { DetailInformation } from './devicedetails';
23
24	export const DeviceConfiguration = ({ item, onClose }) => {	7✔
25	const { object = {} } = item;	1!
26	const { canReadDevices } = useSelector(getUserCapabilities);	1✔
27	const device = useSelector(state => state.devices.byId[object.id]);	1✔
28	const { attribute: idAttribute } = useSelector(getIdAttribute);	1✔
29	const dispatch = useDispatch();	1✔
30
31	const theme = useTheme();	1✔
32	useEffect(() => {	1✔
33	const { object } = item;	1✔
34	if (!device && canReadDevices) {	1!
UNCOV 35	dispatch(getDeviceById(object.id));	×
36	}
37	}, []);
38
39	if (canReadDevices && !device) {	1!
UNCOV 40	return <Loader show={true} />;	×
41	}
42
43	const { actor, change } = item;	1✔
44
45	let config;
46	try {	1✔
47	config = JSON.parse(change);	1✔
48	} catch (error) {
UNCOV 49	config = { error: `An error occurred processing the changed config:\n${error}` };	×
50	}
51
52	return (	1✔
53	<div className="flexbox column" style={{ margin: theme.spacing(3), minWidth: 'min-content' }}>
54	{canReadDevices && <DeviceDetails device={device} idAttribute={idAttribute} onClose={onClose} />}	2✔
55	<DetailInformation title="changed configuration" details={config} />
56	<DetailInformation title="change" details={{ User: actor.email }} />
57	</div>
58	);
59	};
60
61	export default DeviceConfiguration;

mendersoftware / gui / 901187442

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous