901187442

pending completion

Build # 901187442

Build Type

Pull #3795

gitlab-ci

Committed by

mzedel

Commit Message

feat: increased chances of adopting our intended navigation patterns instead of unsupported browser navigation

Ticket: None
Changelog: None
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>

Pull Request Pull Request #3795: feat: increased chances of adopting our intended navigation patterns instead of unsupported browser navigation

Run Details

4389 of 6365 branches covered (68.96%)

5 of 5 new or added lines in 1 file covered. (100.0%)

1729 existing lines in 165 files now uncovered.

8274 of 10019 relevant lines covered (82.58%)

144.86 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

79.07

/src/js/components/common/asyncautocomplete.js

// Copyright 2021 Northern.tech AS
//
//    Licensed under the Apache License, Version 2.0 (the "License");
//    you may not use this file except in compliance with the License.
//    You may obtain a copy of the License at
//
//        http://www.apache.org/licenses/LICENSE-2.0
//
//    Unless required by applicable law or agreed to in writing, software
//    distributed under the License is distributed on an "AS IS" BASIS,
//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//    See the License for the specific language governing permissions and
//    limitations under the License.
import React, { useEffect, useState } from 'react';

import { Autocomplete, TextField } from '@mui/material';
import { useTheme } from '@mui/material/styles';

import { TIMEOUTS } from '../../constants/appConstants';
import { useDebounce } from '../../utils/debouncehook';
import Loader from './loader';

export const AsyncAutocomplete = ({
  id,
  initialValue,
  isLoading,
  label,
  placeholder,
  styles,
  selectionAttribute,
  labelAttribute,
  onChange,
  onChangeSelection,
  options
}) => {
  const theme = useTheme();
  const [open, setOpen] = useState(false);
  const [inputValue, setInputValue] = useState(initialValue);
  const loading = open && isLoading;

  const debouncedValue = useDebounce(inputValue, TIMEOUTS.debounceShort);

  useEffect(() => {
    if (debouncedValue === undefined) {
      return;
    }
    const selection = options.find(option => option[selectionAttribute] === debouncedValue);
    if (selection) {
      onChangeSelection(selection);
    } else {
      onChange(debouncedValue);
    }
  }, [debouncedValue, JSON.stringify(options), selectionAttribute]);

  const onInputChange = (e, value, reason) => {
    if (reason === 'clear') {
      setInputValue('');
      return onChangeSelection();
    } else if ((reason === 'reset' && !e) || reason === 'blur') {
      return;
    }
    setInputValue(value);
  };

  return (
    <Autocomplete
      autoHighlight
      freeSolo
      getOptionLabel={option => option[labelAttribute]}
      isOptionEqualToValue={(option, value) => option[selectionAttribute] === value[selectionAttribute]}
      id={id}
      inputValue={inputValue || ''}
      loading={loading}
      onClose={() => setOpen(false)}
      onInputChange={onInputChange}
      onOpen={() => setOpen(true)}
      open={open}
      openOnFocus
      options={options}
      renderInput={params => (
        <TextField
          {...params}
          label={label}
          placeholder={placeholder}
          style={styles.textField}
          InputProps={{
            ...params.InputProps,
            endAdornment: (
              <>
                {loading && <Loader show small table style={{ marginTop: theme.spacing(-4) }} />}
                {params.InputProps.endAdornment}
              </>
            )
          }}
        />
      )}
    />
  );
};

export default AsyncAutocomplete;

1	// Copyright 2021 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14	import React, { useEffect, useState } from 'react';
15
16	import { Autocomplete, TextField } from '@mui/material';
17	import { useTheme } from '@mui/material/styles';
18
19	import { TIMEOUTS } from '../../constants/appConstants';
20	import { useDebounce } from '../../utils/debouncehook';
21	import Loader from './loader';
22
23	export const AsyncAutocomplete = ({	17✔
24	id,
25	initialValue,
26	isLoading,
27	label,
28	placeholder,
29	styles,
30	selectionAttribute,
31	labelAttribute,
32	onChange,
33	onChangeSelection,
34	options
35	}) => {
36	const theme = useTheme();	164✔
37	const [open, setOpen] = useState(false);	164✔
38	const [inputValue, setInputValue] = useState(initialValue);	164✔
39	const loading = open && isLoading;	164✔
40
41	const debouncedValue = useDebounce(inputValue, TIMEOUTS.debounceShort);	164✔
42
43	useEffect(() => {	164✔
44	if (debouncedValue === undefined) {	11✔
45	return;	9✔
46	}
47	const selection = options.find(option => option[selectionAttribute] === debouncedValue);	4✔
48	if (selection) {	2!
49	onChangeSelection(selection);	2✔
50	} else {
UNCOV 51	onChange(debouncedValue);	×
52	}
53	}, [debouncedValue, JSON.stringify(options), selectionAttribute]);
54
55	const onInputChange = (e, value, reason) => {	164✔
56	if (reason === 'clear') {	2!
UNCOV 57	setInputValue('');	×
UNCOV 58	return onChangeSelection();	×
59	} else if ((reason === 'reset' && !e) \|\| reason === 'blur') {	2!
UNCOV 60	return;	×
61	}
62	setInputValue(value);	2✔
63	};
64
65	return (	164✔
66	<Autocomplete
67	autoHighlight
68	freeSolo
69	getOptionLabel={option => option[labelAttribute]}	810✔
UNCOV 70	isOptionEqualToValue={(option, value) => option[selectionAttribute] === value[selectionAttribute]}	×
71	id={id}
72	inputValue={inputValue \|\| ''}	322✔
73	loading={loading}
74	onClose={() => setOpen(false)}	2✔
75	onInputChange={onInputChange}
76	onOpen={() => setOpen(true)}	2✔
77	open={open}
78	openOnFocus
79	options={options}
80	renderInput={params => (
81	<TextField	169✔
82	{...params}
83	label={label}
84	placeholder={placeholder}
85	style={styles.textField}
86	InputProps={{
87	...params.InputProps,
88	endAdornment: (
89	<>
90	{loading && <Loader show small table style={{ marginTop: theme.spacing(-4) }} />}	169!
91	{params.InputProps.endAdornment}
92	</>
93	)
94	}}
95	/>
96	)}
97	/>
98	);
99	};
100
101	export default AsyncAutocomplete;

mendersoftware / gui / 901187442

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous