901187442

pending completion

Build # 901187442

Build Type

Pull #3795

gitlab-ci

Committed by

mzedel

Commit Message

feat: increased chances of adopting our intended navigation patterns instead of unsupported browser navigation

Ticket: None
Changelog: None
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>

Pull Request Pull Request #3795: feat: increased chances of adopting our intended navigation patterns instead of unsupported browser navigation

Run Details

4389 of 6365 branches covered (68.96%)

5 of 5 new or added lines in 1 file covered. (100.0%)

1729 existing lines in 165 files now uncovered.

8274 of 10019 relevant lines covered (82.58%)

144.86 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

71.43

/src/js/components/devices/device-details/devicetags.js

// Copyright 2021 Northern.tech AS
//
//    Licensed under the Apache License, Version 2.0 (the "License");
//    you may not use this file except in compliance with the License.
//    You may obtain a copy of the License at
//
//        http://www.apache.org/licenses/LICENSE-2.0
//
//    Unless required by applicable law or agreed to in writing, software
//    distributed under the License is distributed on an "AS IS" BASIS,
//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//    See the License for the specific language governing permissions and
//    limitations under the License.
import React, { useEffect, useState } from 'react';

import { Edit as EditIcon } from '@mui/icons-material';
import { Button } from '@mui/material';
import { useTheme } from '@mui/material/styles';

import { toggle } from '../../../helpers';
import Tracking from '../../../tracking';
import ConfigurationObject from '../../common/configurationobject';
import KeyValueEditor from '../../common/forms/keyvalueeditor';
import { NameTagTip } from '../../helptips/helptooltips';
import DeviceDataCollapse from './devicedatacollapse';

const configHelpTipsMap = {
  name: {
    position: 'right',
    component: NameTagTip
  }
};

export const DeviceTags = ({ device, setDeviceTags, setSnackbar, showHelptips, userCapabilities }) => {
  const { canWriteDevices } = userCapabilities;
  const theme = useTheme();
  const [changedTags, setChangedTags] = useState({});
  const [isEditDisabled, setIsEditDisabled] = useState(!canWriteDevices);
  const [isEditing, setIsEditing] = useState(false);
  const [shouldUpdateEditor, setShouldUpdateEditor] = useState(false);

  const { tags = {} } = device;
  const hasTags = !!Object.keys(tags).length;

  useEffect(() => {
    setShouldUpdateEditor(toggle);
  }, [isEditing]);

  useEffect(() => {
    if (canWriteDevices) {
      setIsEditing(!hasTags);
    }
  }, [hasTags, canWriteDevices]);

  const onCancel = () => {
    setIsEditing(false);
    setChangedTags(tags);
  };

  const onStartEdit = e => {
    e.stopPropagation();
    setChangedTags(tags);
    setIsEditing(true);
  };

  const onSubmit = () => {
    Tracking.event({ category: 'devices', action: 'modify_tags' });
    setIsEditDisabled(true);
    return setDeviceTags(device.id, changedTags)
      .then(() => setIsEditing(false))
      .finally(() => setIsEditDisabled(false));
  };

  const helpTipsMap = Object.entries(configHelpTipsMap).reduce((accu, [key, value]) => {
    accu[key] = {
      ...value,
      props: { deviceId: device.id }
    };
    return accu;
  }, {});
  return (
    <DeviceDataCollapse
      title={
        <div className="two-columns">
          <div className="flexbox center-aligned">
            <h4 className="margin-right">Tags</h4>
            {!isEditing && canWriteDevices && (
              <Button onClick={onStartEdit} startIcon={<EditIcon />} size="small">
                Edit
              </Button>
            )}
          </div>
        </div>
      }
    >
      <div className="relative" style={{ maxWidth: 700 }}>
        {isEditing ? (
          <>
            <KeyValueEditor
              disabled={isEditDisabled}
              errortext=""
              input={changedTags}
              inputHelpTipsMap={helpTipsMap}
              onInputChange={setChangedTags}
              reset={shouldUpdateEditor}
              showHelptips={showHelptips}
            />
            <div className="flexbox center-aligned margin-bottom-small" style={{ justifyContent: 'flex-end' }}>
              <Button color="primary" onClick={onSubmit} variant="contained" style={{ marginRight: theme.spacing(2) }}>
                Save
              </Button>
              <Button onClick={onCancel}>Cancel</Button>
            </div>
          </>
        ) : (
          hasTags && <ConfigurationObject config={tags} setSnackbar={setSnackbar} />
        )}
      </div>
    </DeviceDataCollapse>
  );
};

export default DeviceTags;

1	// Copyright 2021 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14	import React, { useEffect, useState } from 'react';
15
16	import { Edit as EditIcon } from '@mui/icons-material';
17	import { Button } from '@mui/material';
18	import { useTheme } from '@mui/material/styles';
19
20	import { toggle } from '../../../helpers';
21	import Tracking from '../../../tracking';
22	import ConfigurationObject from '../../common/configurationobject';
23	import KeyValueEditor from '../../common/forms/keyvalueeditor';
24	import { NameTagTip } from '../../helptips/helptooltips';
25	import DeviceDataCollapse from './devicedatacollapse';
26
27	const configHelpTipsMap = {	11✔
28	name: {
29	position: 'right',
30	component: NameTagTip
31	}
32	};
33
34	export const DeviceTags = ({ device, setDeviceTags, setSnackbar, showHelptips, userCapabilities }) => {	11✔
35	const { canWriteDevices } = userCapabilities;	6✔
36	const theme = useTheme();	6✔
37	const [changedTags, setChangedTags] = useState({});	6✔
38	const [isEditDisabled, setIsEditDisabled] = useState(!canWriteDevices);	6✔
39	const [isEditing, setIsEditing] = useState(false);	6✔
40	const [shouldUpdateEditor, setShouldUpdateEditor] = useState(false);	6✔
41
42	const { tags = {} } = device;	6✔
43	const hasTags = !!Object.keys(tags).length;	6✔
44
45	useEffect(() => {	6✔
46	setShouldUpdateEditor(toggle);	4✔
47	}, [isEditing]);
48
49	useEffect(() => {	6✔
50	if (canWriteDevices) {	2!
51	setIsEditing(!hasTags);	2✔
52	}
53	}, [hasTags, canWriteDevices]);
54
55	const onCancel = () => {	6✔
UNCOV 56	setIsEditing(false);	×
UNCOV 57	setChangedTags(tags);	×
58	};
59
60	const onStartEdit = e => {	6✔
UNCOV 61	e.stopPropagation();	×
UNCOV 62	setChangedTags(tags);	×
UNCOV 63	setIsEditing(true);	×
64	};
65
66	const onSubmit = () => {	6✔
UNCOV 67	Tracking.event({ category: 'devices', action: 'modify_tags' });	×
UNCOV 68	setIsEditDisabled(true);	×
UNCOV 69	return setDeviceTags(device.id, changedTags)	×
UNCOV 70	.then(() => setIsEditing(false))	×
UNCOV 71	.finally(() => setIsEditDisabled(false));	×
72	};
73
74	const helpTipsMap = Object.entries(configHelpTipsMap).reduce((accu, [key, value]) => {	6✔
75	accu[key] = {	6✔
76	...value,
77	props: { deviceId: device.id }
78	};
79	return accu;	6✔
80	}, {});
81	return (	6✔
82	<DeviceDataCollapse
83	title={
84	<div className="two-columns">
85	<div className="flexbox center-aligned">
86	<h4 className="margin-right">Tags</h4>
87	{!isEditing && canWriteDevices && (	10✔
88	<Button onClick={onStartEdit} startIcon={<EditIcon />} size="small">
89	Edit
90	</Button>
91	)}
92	</div>
93	</div>
94	}
95	>
96	<div className="relative" style={{ maxWidth: 700 }}>
97	{isEditing ? (	6✔
98	<>
99	<KeyValueEditor
100	disabled={isEditDisabled}
101	errortext=""
102	input={changedTags}
103	inputHelpTipsMap={helpTipsMap}
104	onInputChange={setChangedTags}
105	reset={shouldUpdateEditor}
106	showHelptips={showHelptips}
107	/>
108	<div className="flexbox center-aligned margin-bottom-small" style={{ justifyContent: 'flex-end' }}>
109	<Button color="primary" onClick={onSubmit} variant="contained" style={{ marginRight: theme.spacing(2) }}>
110	Save
111	</Button>
112	<Button onClick={onCancel}>Cancel</Button>
113	</div>
114	</>
115	) : (
116	hasTags && <ConfigurationObject config={tags} setSnackbar={setSnackbar} />	2!
117	)}
118	</div>
119	</DeviceDataCollapse>
120	);
121	};
122
123	export default DeviceTags;

mendersoftware / gui / 901187442

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous