901187442

pending completion

Build # 901187442

Build Type

Pull #3795

gitlab-ci

Committed by

mzedel

Commit Message

feat: increased chances of adopting our intended navigation patterns instead of unsupported browser navigation

Ticket: None
Changelog: None
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>

Pull Request Pull Request #3795: feat: increased chances of adopting our intended navigation patterns instead of unsupported browser navigation

Run Details

4389 of 6365 branches covered (68.96%)

5 of 5 new or added lines in 1 file covered. (100.0%)

1729 existing lines in 165 files now uncovered.

8274 of 10019 relevant lines covered (82.58%)

144.86 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

70.0

/src/js/components/devices/widgets/deviceadditionwidget.js

// Copyright 2021 Northern.tech AS
//
//    Licensed under the Apache License, Version 2.0 (the "License");
//    you may not use this file except in compliance with the License.
//    You may obtain a copy of the License at
//
//        http://www.apache.org/licenses/LICENSE-2.0
//
//    Unless required by applicable law or agreed to in writing, software
//    distributed under the License is distributed on an "AS IS" BASIS,
//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//    See the License for the specific language governing permissions and
//    limitations under the License.
import React, { useState } from 'react';

import { ArrowDropDown as ArrowDropDownIcon, Launch as LaunchIcon } from '@mui/icons-material';
import { Button, ButtonGroup, Menu, MenuItem } from '@mui/material';
import { makeStyles } from 'tss-react/mui';

import { canAccess } from '../../../constants/appConstants';

const useStyles = makeStyles()(() => ({
  buttonStyle: { textTransform: 'none' }
}));

export const DeviceAdditionWidget = ({ docsVersion, features, onConnectClick, onMakeGatewayClick, onPreauthClick, tenantCapabilities }) => {
  const [anchorEl, setAnchorEl] = useState();
  const [selectedIndex, setSelectedIndex] = useState(0);
  const { classes } = useStyles();

  const options = [
    { action: onConnectClick, title: 'Connect a new device', value: 'connect', canAccess },
    { action: onPreauthClick, title: 'Preauthorize a device', value: 'preauth', canAccess },
    {
      action: onMakeGatewayClick,
      title: 'Promote a device to gateway',
      value: 'makegateway',
      canAccess: ({ features, tenantCapabilities }) => features.isHosted && tenantCapabilities.isEnterprise
    },
    {
      href: `https://docs.mender.io/${docsVersion}client-installation/overview`,
      rel: 'noopener noreferrer',
      target: '_blank',
      title: 'Learn how to connect devices',
      value: 'learntoconnect',
      canAccess
    }
  ];

  const handleToggle = event => {
    const anchor = anchorEl ? null : event?.currentTarget.parentElement;
    setAnchorEl(anchor);
  };

  const handleSelection = index => {
    setSelectedIndex(index);
    handleToggle();
    options[index].action(true);
  };

  return (
    <>
      <ButtonGroup className="muted device-addition-widget">
        <Button className={classes.buttonStyle} onClick={options[selectedIndex].action} variant="text">
          {options[selectedIndex].title}
        </Button>
        <Button className={classes.buttonStyle} size="small" onClick={handleToggle} variant="text">
          <ArrowDropDownIcon />
        </Button>
      </ButtonGroup>
      <Menu id="device-connection-menu" anchorEl={anchorEl} keepMounted open={Boolean(anchorEl)} onClose={handleToggle} variant="menu">
        {options.reduce((accu, option, index) => {
          if (!option.canAccess({ features, tenantCapabilities })) {
            return accu;
          }
          // eslint-disable-next-line no-unused-vars
          const { canAccess, href, title, value, ...optionProps } = option;
          const item = href ? (
            <MenuItem {...optionProps} key={value} href={href} component="a">
              {title}
              <LaunchIcon style={{ fontSize: '10pt' }} />
            </MenuItem>
          ) : (
            <MenuItem className={classes.buttonStyle} key={value} onClick={() => handleSelection(index)}>
              {title}
            </MenuItem>
          );
          accu.push(item);
          return accu;
        }, [])}
      </Menu>
    </>
  );
};

export default DeviceAdditionWidget;

1	// Copyright 2021 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14	import React, { useState } from 'react';
15
16	import { ArrowDropDown as ArrowDropDownIcon, Launch as LaunchIcon } from '@mui/icons-material';
17	import { Button, ButtonGroup, Menu, MenuItem } from '@mui/material';
18	import { makeStyles } from 'tss-react/mui';
19
20	import { canAccess } from '../../../constants/appConstants';
21
22	const useStyles = makeStyles()(() => ({	5✔
23	buttonStyle: { textTransform: 'none' }
24	}));
25
26	export const DeviceAdditionWidget = ({ docsVersion, features, onConnectClick, onMakeGatewayClick, onPreauthClick, tenantCapabilities }) => {	5✔
27	const [anchorEl, setAnchorEl] = useState();	3✔
28	const [selectedIndex, setSelectedIndex] = useState(0);	3✔
29	const { classes } = useStyles();	3✔
30
31	const options = [	3✔
32	{ action: onConnectClick, title: 'Connect a new device', value: 'connect', canAccess },
33	{ action: onPreauthClick, title: 'Preauthorize a device', value: 'preauth', canAccess },
34	{
35	action: onMakeGatewayClick,
36	title: 'Promote a device to gateway',
37	value: 'makegateway',
38	canAccess: ({ features, tenantCapabilities }) => features.isHosted && tenantCapabilities.isEnterprise	3!
39	},
40	{
41	href: `https://docs.mender.io/${docsVersion}client-installation/overview`,
42	rel: 'noopener noreferrer',
43	target: '_blank',
44	title: 'Learn how to connect devices',
45	value: 'learntoconnect',
46	canAccess
47	}
48	];
49
50	const handleToggle = event => {	3✔
UNCOV 51	const anchor = anchorEl ? null : event?.currentTarget.parentElement;	×
UNCOV 52	setAnchorEl(anchor);	×
53	};
54
55	const handleSelection = index => {	3✔
UNCOV 56	setSelectedIndex(index);	×
UNCOV 57	handleToggle();	×
UNCOV 58	options[index].action(true);	×
59	};
60
61	return (	3✔
62	<>
63	<ButtonGroup className="muted device-addition-widget">
64	<Button className={classes.buttonStyle} onClick={options[selectedIndex].action} variant="text">
65	{options[selectedIndex].title}
66	</Button>
67	<Button className={classes.buttonStyle} size="small" onClick={handleToggle} variant="text">
68	<ArrowDropDownIcon />
69	</Button>
70	</ButtonGroup>
71	<Menu id="device-connection-menu" anchorEl={anchorEl} keepMounted open={Boolean(anchorEl)} onClose={handleToggle} variant="menu">
72	{options.reduce((accu, option, index) => {
73	if (!option.canAccess({ features, tenantCapabilities })) {	12✔
74	return accu;	3✔
75	}
76	// eslint-disable-next-line no-unused-vars
77	const { canAccess, href, title, value, ...optionProps } = option;	9✔
78	const item = href ? (	9✔
79	<MenuItem {...optionProps} key={value} href={href} component="a">
80	{title}
81	<LaunchIcon style={{ fontSize: '10pt' }} />
82	</MenuItem>
83	) : (
UNCOV 84	<MenuItem className={classes.buttonStyle} key={value} onClick={() => handleSelection(index)}>	×
85	{title}
86	</MenuItem>
87	);
88	accu.push(item);	9✔
89	return accu;	9✔
90	}, [])}
91	</Menu>
92	</>
93	);
94	};
95
96	export default DeviceAdditionWidget;

mendersoftware / gui / 901187442

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous