#4666

pending completion

Build # #4666

Build Type

push

coveralls-python

Committed by

suhaibmujahid

Commit Message

Revert "[patch_closed_bug] Re-enable the rule"

This reverts commit 50095e869.

Run Details

716 of 3562 branches covered (20.1%)

1924 of 8713 relevant lines covered (22.08%)

0.22 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/bugbot/rules/uplift_beta.py

# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this file,
# You can obtain one at http://mozilla.org/MPL/2.0/.

from libmozdata import utils as lmdutils
from libmozdata.bugzilla import Bugzilla

from bugbot import utils
from bugbot.bzcleaner import BzCleaner


class UpliftBeta(BzCleaner):
    def __init__(self):
        super(UpliftBeta, self).__init__()
        if not self.init_versions():
            return

        self.beta = self.versions["beta"]
        self.status_central = utils.get_flag(
            self.versions["central"], "status", "central"
        )
        self.status_beta = utils.get_flag(self.beta, "status", "beta")

        # Bugs will be added to `extra_ni` later after being fetched
        self.extra_ni = {"status_beta": f"status-firefox{self.beta}"}

    def description(self):
        return "Bugs fixed in nightly but still affecting beta"

    def has_assignee(self):
        return True

    def get_extra_for_needinfo_template(self):
        return self.extra_ni

    def columns(self):
        return ["id", "summary", "assignee"]

    def handle_bug(self, bug, data):
        # XXX: This is a temporary workaround, should be dropped after
        # fixing https://github.com/mozilla/bugbot/issues/1953
        if self._has_patch_after_closed(bug):
            return

        bugid = str(bug["id"])

        assignee = bug.get("assigned_to", "")
        if utils.is_no_assignee(assignee):
            assignee = ""
            nickname = ""
        else:
            nickname = bug["assigned_to_detail"]["nick"]

        data[bugid] = {
            "id": bugid,
            "mail": assignee,
            "nickname": nickname,
            "summary": self.get_summary(bug),
            "regressions": bug["regressions"],
        }
        return bug

    def filter_by_regr(self, bugs):
        # Filter the bugs which don't have any regression or where the regressions are all closed
        def bug_handler(bug, data):
            if bug["status"] in {"RESOLVED", "VERIFIED", "CLOSED"}:
                data.add(bug["id"])

        bugids = {r for info in bugs.values() for r in info["regressions"]}
        if not bugids:
            return bugs

        fixed_bugs = set()
        Bugzilla(
            bugids=list(bugids),
            include_fields=["id", "status"],
            bughandler=bug_handler,
            bugdata=fixed_bugs,
        ).get_data().wait()

        bugs_without_regr = {}
        for bugid, info in bugs.items():
            regs = set(info["regressions"])
            regs = regs - fixed_bugs
            if not regs:
                bugs_without_regr[bugid] = info

        return bugs_without_regr

    def get_bz_params(self, date):
        self.date = lmdutils.get_date_ymd(date)
        fields = [
            self.status_beta,
            "regressions",
            "attachments.creation_time",
            "attachments.is_obsolete",
            "attachments.content_type",
            "cf_last_resolved",
        ]
        params = {
            "include_fields": fields,
            "bug_type": "defect",
            "resolution": ["---", "FIXED"],
            "f1": self.status_central,
            "o1": "anyexact",
            "v1": ",".join(["fixed", "verified"]),
            "f2": self.status_beta,
            "o2": "anyexact",
            "v2": ["affected", "fix-optional"],
            "f3": "flagtypes.name",
            "o3": "notsubstring",
            "v3": "approval-mozilla-beta",
            "f4": "flagtypes.name",
            "o4": "notsubstring",
            "v4": "needinfo",
            # Don't nag several times
            "n5": 1,
            "f5": "longdesc",
            "o5": "casesubstring",
            # this a part of the comment we've in templates/uplift_beta_needinfo.txt
            "v5": ", is this bug important enough to require an uplift?",
            # Check if have at least one attachment which is a Phabricator request
            "f6": "attachments.mimetype",
            "o6": "anyexact",
            "v6": ["text/x-phabricator-request", "text/x-github-pull-request"],
            # skip if whiteboard contains checkin-needed-beta (e.g. test-only uplift)
            "f7": "status_whiteboard",
            "o7": "notsubstring",
            "v7": "[checkin-needed-beta]",
        }

        return params

    def _has_patch_after_closed(self, bug):
        patches = [
            attachment["creation_time"]
            for attachment in bug["attachments"]
            if attachment["content_type"] == "text/x-phabricator-request"
            and not attachment["is_obsolete"]
        ]
        if len(patches) == 0:
            return False

        latest_patch_at = max(patches)
        resolved_at = bug["cf_last_resolved"]

        return latest_patch_at > resolved_at

    def get_bugs(self, date="today", bug_ids=[]):
        bugs = super(UpliftBeta, self).get_bugs(date=date, bug_ids=bug_ids)
        bugs = self.filter_by_regr(bugs)

        for bugid, data in bugs.items():
            if data["mail"] and data["nickname"]:
                self.extra_ni[bugid] = {"regression": len(data["regressions"])}
                self.add_auto_ni(
                    bugid, {"mail": data["mail"], "nickname": data["nickname"]}
                )

        return bugs


if __name__ == "__main__":
    UpliftBeta().run()

1	# This Source Code Form is subject to the terms of the Mozilla Public
2	# License, v. 2.0. If a copy of the MPL was not distributed with this file,
3	# You can obtain one at http://mozilla.org/MPL/2.0/.
4
5	from libmozdata import utils as lmdutils	×
6	from libmozdata.bugzilla import Bugzilla	×
7
8	from bugbot import utils	×
9	from bugbot.bzcleaner import BzCleaner	×
10
11
12	class UpliftBeta(BzCleaner):	×
13	def __init__(self):	×
14	super(UpliftBeta, self).__init__()	×
15	if not self.init_versions():	×
16	return	×
17
18	self.beta = self.versions["beta"]	×
19	self.status_central = utils.get_flag(	×
20	self.versions["central"], "status", "central"
21	)
22	self.status_beta = utils.get_flag(self.beta, "status", "beta")	×
23
24	# Bugs will be added to `extra_ni` later after being fetched
25	self.extra_ni = {"status_beta": f"status-firefox{self.beta}"}	×
26
27	def description(self):	×
28	return "Bugs fixed in nightly but still affecting beta"	×
29
30	def has_assignee(self):	×
31	return True	×
32
33	def get_extra_for_needinfo_template(self):	×
34	return self.extra_ni	×
35
36	def columns(self):	×
37	return ["id", "summary", "assignee"]	×
38
39	def handle_bug(self, bug, data):	×
40	# XXX: This is a temporary workaround, should be dropped after
41	# fixing https://github.com/mozilla/bugbot/issues/1953
42	if self._has_patch_after_closed(bug):	×
43	return	×
44
45	bugid = str(bug["id"])	×
46
47	assignee = bug.get("assigned_to", "")	×
48	if utils.is_no_assignee(assignee):	×
49	assignee = ""	×
50	nickname = ""	×
51	else:
52	nickname = bug["assigned_to_detail"]["nick"]	×
53
54	data[bugid] = {	×
55	"id": bugid,
56	"mail": assignee,
57	"nickname": nickname,
58	"summary": self.get_summary(bug),
59	"regressions": bug["regressions"],
60	}
61	return bug	×
62
63	def filter_by_regr(self, bugs):	×
64	# Filter the bugs which don't have any regression or where the regressions are all closed
65	def bug_handler(bug, data):	×
66	if bug["status"] in {"RESOLVED", "VERIFIED", "CLOSED"}:	×
67	data.add(bug["id"])	×
68
69	bugids = {r for info in bugs.values() for r in info["regressions"]}	×
70	if not bugids:	×
71	return bugs	×
72
73	fixed_bugs = set()	×
74	Bugzilla(	×
75	bugids=list(bugids),
76	include_fields=["id", "status"],
77	bughandler=bug_handler,
78	bugdata=fixed_bugs,
79	).get_data().wait()
80
81	bugs_without_regr = {}	×
82	for bugid, info in bugs.items():	×
83	regs = set(info["regressions"])	×
84	regs = regs - fixed_bugs	×
85	if not regs:	×
86	bugs_without_regr[bugid] = info	×
87
88	return bugs_without_regr	×
89
90	def get_bz_params(self, date):	×
91	self.date = lmdutils.get_date_ymd(date)	×
92	fields = [	×
93	self.status_beta,
94	"regressions",
95	"attachments.creation_time",
96	"attachments.is_obsolete",
97	"attachments.content_type",
98	"cf_last_resolved",
99	]
100	params = {	×
101	"include_fields": fields,
102	"bug_type": "defect",
103	"resolution": ["---", "FIXED"],
104	"f1": self.status_central,
105	"o1": "anyexact",
106	"v1": ",".join(["fixed", "verified"]),
107	"f2": self.status_beta,
108	"o2": "anyexact",
109	"v2": ["affected", "fix-optional"],
110	"f3": "flagtypes.name",
111	"o3": "notsubstring",
112	"v3": "approval-mozilla-beta",
113	"f4": "flagtypes.name",
114	"o4": "notsubstring",
115	"v4": "needinfo",
116	# Don't nag several times
117	"n5": 1,
118	"f5": "longdesc",
119	"o5": "casesubstring",
120	# this a part of the comment we've in templates/uplift_beta_needinfo.txt
121	"v5": ", is this bug important enough to require an uplift?",
122	# Check if have at least one attachment which is a Phabricator request
123	"f6": "attachments.mimetype",
124	"o6": "anyexact",
125	"v6": ["text/x-phabricator-request", "text/x-github-pull-request"],
126	# skip if whiteboard contains checkin-needed-beta (e.g. test-only uplift)
127	"f7": "status_whiteboard",
128	"o7": "notsubstring",
129	"v7": "[checkin-needed-beta]",
130	}
131
132	return params	×
133
134	def _has_patch_after_closed(self, bug):	×
135	patches = [	×
136	attachment["creation_time"]
137	for attachment in bug["attachments"]
138	if attachment["content_type"] == "text/x-phabricator-request"
139	and not attachment["is_obsolete"]
140	]
141	if len(patches) == 0:	×
142	return False	×
143
144	latest_patch_at = max(patches)	×
145	resolved_at = bug["cf_last_resolved"]	×
146
147	return latest_patch_at > resolved_at	×
148
149	def get_bugs(self, date="today", bug_ids=[]):	×
150	bugs = super(UpliftBeta, self).get_bugs(date=date, bug_ids=bug_ids)	×
151	bugs = self.filter_by_regr(bugs)	×
152
153	for bugid, data in bugs.items():	×
154	if data["mail"] and data["nickname"]:	×
155	self.extra_ni[bugid] = {"regression": len(data["regressions"])}	×
156	self.add_auto_ni(	×
157	bugid, {"mail": data["mail"], "nickname": data["nickname"]}
158	)
159
160	return bugs	×
161
162
163	if __name__ == "__main__":	×
164	UpliftBeta().run()	×

mozilla / relman-auto-nag / #4666

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous