947394036

pending completion

Build # 947394036

Build Type

push

gitlab-ci

Committed by

kacf

Commit Message

chore: Treat events with no state transitions as fatal.

This was discussed with the team members. Since an unhandled event is
almost guaranteed to hang the state machine, then it's better to
terminate and let systemd try to restart us, in the hopes that
recovery will still work.

Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

4268 of 5997 relevant lines covered (71.17%)

148.52 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/mender-update/daemon/state_machine.cpp

// Copyright 2023 Northern.tech AS
//
//    Licensed under the Apache License, Version 2.0 (the "License");
//    you may not use this file except in compliance with the License.
//    You may obtain a copy of the License at
//
//        http://www.apache.org/licenses/LICENSE-2.0
//
//    Unless required by applicable law or agreed to in writing, software
//    distributed under the License is distributed on an "AS IS" BASIS,
//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//    See the License for the specific language governing permissions and
//    limitations under the License.

#include <common/log.hpp>
#include <mender-update/daemon/states.hpp>
#include <mender-update/daemon/state_machine.hpp>

namespace mender {
namespace update {
namespace daemon {

namespace log = mender::common::log;

StateMachine::StateMachine(Context &ctx, events::EventLoop &event_loop) :
        event_loop_(event_loop),
        submit_inventory_state_(event_loop),
        poll_for_deployment_state_(event_loop),
        main_states_(idle_state_),
        runner_(ctx) {
        runner_.AddStateMachine(main_states_);

        using se = StateEvent;
        using tf = sm::TransitionFlag;

        // clang-format off
        main_states_.AddTransition(idle_state_,                          se::DeploymentPollingTriggered, poll_for_deployment_state_,           tf::Deferred );

        main_states_.AddTransition(idle_state_,                          se::InventoryPollingTriggered,  submit_inventory_state_,              tf::Deferred );

        main_states_.AddTransition(poll_for_deployment_state_,           se::Success,                    update_download_state_,               tf::Immediate);
        main_states_.AddTransition(poll_for_deployment_state_,           se::NothingToDo,                idle_state_,                          tf::Immediate);
        main_states_.AddTransition(poll_for_deployment_state_,           se::Failure,                    idle_state_,                          tf::Immediate);

        main_states_.AddTransition(update_download_state_,               se::Success,                    update_install_state_,                tf::Immediate);
        main_states_.AddTransition(update_download_state_,               se::Failure,                    update_cleanup_state_,                tf::Immediate);
        // Empty payload
        main_states_.AddTransition(update_download_state_,               se::NothingToDo,                update_save_artifact_data_state_,     tf::Immediate);

        main_states_.AddTransition(update_install_state_,                se::Success,                    update_check_reboot_state_,           tf::Immediate);
        main_states_.AddTransition(update_install_state_,                se::Failure,                    update_check_rollback_state_,         tf::Immediate);

        main_states_.AddTransition(update_check_reboot_state_,           se::Success,                    update_reboot_state_,                 tf::Immediate);
        main_states_.AddTransition(update_check_reboot_state_,           se::NothingToDo,                update_commit_state_,                 tf::Immediate);
        main_states_.AddTransition(update_check_reboot_state_,           se::Failure,                    update_check_rollback_state_,         tf::Immediate);

        main_states_.AddTransition(update_reboot_state_,                 se::Success,                    update_verify_reboot_state_,          tf::Immediate);
        main_states_.AddTransition(update_reboot_state_,                 se::Failure,                    update_check_rollback_state_,         tf::Immediate);

        main_states_.AddTransition(update_verify_reboot_state_,          se::Success,                    update_commit_state_,                 tf::Immediate);
        main_states_.AddTransition(update_verify_reboot_state_,          se::Failure,                    update_check_rollback_state_,         tf::Immediate);

        main_states_.AddTransition(update_commit_state_,                 se::Success,                    update_save_artifact_data_state_,     tf::Immediate);
        main_states_.AddTransition(update_commit_state_,                 se::Failure,                    update_check_rollback_state_,         tf::Immediate);

        main_states_.AddTransition(update_check_rollback_state_,         se::Success,                    update_rollback_state_,               tf::Immediate);
        main_states_.AddTransition(update_check_rollback_state_,         se::NothingToDo,                update_failure_state_,                tf::Immediate);
        main_states_.AddTransition(update_check_rollback_state_,         se::Failure,                    update_failure_state_,                tf::Immediate);

        main_states_.AddTransition(update_rollback_state_,               se::Success,                    update_check_rollback_reboot_state_,  tf::Immediate);
        main_states_.AddTransition(update_rollback_state_,               se::Failure,                    update_failure_state_,                tf::Immediate);

        main_states_.AddTransition(update_check_rollback_reboot_state_,  se::Success,                    update_rollback_reboot_state_,        tf::Immediate);
        main_states_.AddTransition(update_check_rollback_reboot_state_,  se::NothingToDo,                update_failure_state_,                tf::Immediate);
        main_states_.AddTransition(update_check_rollback_reboot_state_,  se::Failure,                    update_failure_state_,                tf::Immediate);

        main_states_.AddTransition(update_rollback_reboot_state_,        se::Success,                    update_verify_rollback_reboot_state_, tf::Immediate);
        main_states_.AddTransition(update_rollback_reboot_state_,        se::Failure,                    update_failure_state_,                tf::Immediate);

        main_states_.AddTransition(update_verify_rollback_reboot_state_, se::Success,                    update_failure_state_,                tf::Immediate);
        main_states_.AddTransition(update_verify_rollback_reboot_state_, se::Failure,                    update_rollback_reboot_state_,        tf::Immediate);

        main_states_.AddTransition(update_failure_state_,                se::Success,                    update_save_artifact_data_state_,     tf::Immediate);
        main_states_.AddTransition(update_failure_state_,                se::Failure,                    update_save_artifact_data_state_,     tf::Immediate);

        main_states_.AddTransition(update_save_artifact_data_state_,     se::Success,                    update_cleanup_state_,                tf::Immediate);
        // Even if this fails, there is nothing we can do at this point.
        main_states_.AddTransition(update_save_artifact_data_state_,     se::Failure,                    update_cleanup_state_,                tf::Immediate);

        main_states_.AddTransition(update_cleanup_state_,                se::Success,                    idle_state_,                          tf::Immediate);
        main_states_.AddTransition(update_cleanup_state_,                se::Failure,                    idle_state_,                          tf::Immediate);
        // clang-format on
}

error::Error StateMachine::Run() {
        runner_.AttachToEventLoop(event_loop_);

        // Client is supposed to do one handling of each on startup.
        runner_.PostEvent(StateEvent::InventoryPollingTriggered);
        runner_.PostEvent(StateEvent::DeploymentPollingTriggered);

        event_loop_.Run();
        return error::NoError;
}

} // namespace daemon
} // namespace update
} // namespace mender

1	// Copyright 2023 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14
15	#include <common/log.hpp>
16	#include <mender-update/daemon/states.hpp>
17	#include <mender-update/daemon/state_machine.hpp>
18
19	namespace mender {
20	namespace update {
21	namespace daemon {
22
23	namespace log = mender::common::log;
24
25	StateMachine::StateMachine(Context &ctx, events::EventLoop &event_loop) :	×
26	event_loop_(event_loop),
27	submit_inventory_state_(event_loop),
28	poll_for_deployment_state_(event_loop),
29	main_states_(idle_state_),
30	runner_(ctx) {	×
31	runner_.AddStateMachine(main_states_);	×
32
33	using se = StateEvent;
34	using tf = sm::TransitionFlag;
35
36	// clang-format off
37	main_states_.AddTransition(idle_state_, se::DeploymentPollingTriggered, poll_for_deployment_state_, tf::Deferred );	×
38
39	main_states_.AddTransition(idle_state_, se::InventoryPollingTriggered, submit_inventory_state_, tf::Deferred );	×
40
41	main_states_.AddTransition(poll_for_deployment_state_, se::Success, update_download_state_, tf::Immediate);	×
42	main_states_.AddTransition(poll_for_deployment_state_, se::NothingToDo, idle_state_, tf::Immediate);	×
43	main_states_.AddTransition(poll_for_deployment_state_, se::Failure, idle_state_, tf::Immediate);	×
44
45	main_states_.AddTransition(update_download_state_, se::Success, update_install_state_, tf::Immediate);	×
46	main_states_.AddTransition(update_download_state_, se::Failure, update_cleanup_state_, tf::Immediate);	×
47	// Empty payload
48	main_states_.AddTransition(update_download_state_, se::NothingToDo, update_save_artifact_data_state_, tf::Immediate);	×
49
50	main_states_.AddTransition(update_install_state_, se::Success, update_check_reboot_state_, tf::Immediate);	×
51	main_states_.AddTransition(update_install_state_, se::Failure, update_check_rollback_state_, tf::Immediate);	×
52
53	main_states_.AddTransition(update_check_reboot_state_, se::Success, update_reboot_state_, tf::Immediate);	×
54	main_states_.AddTransition(update_check_reboot_state_, se::NothingToDo, update_commit_state_, tf::Immediate);	×
55	main_states_.AddTransition(update_check_reboot_state_, se::Failure, update_check_rollback_state_, tf::Immediate);	×
56
57	main_states_.AddTransition(update_reboot_state_, se::Success, update_verify_reboot_state_, tf::Immediate);	×
58	main_states_.AddTransition(update_reboot_state_, se::Failure, update_check_rollback_state_, tf::Immediate);	×
59
60	main_states_.AddTransition(update_verify_reboot_state_, se::Success, update_commit_state_, tf::Immediate);	×
61	main_states_.AddTransition(update_verify_reboot_state_, se::Failure, update_check_rollback_state_, tf::Immediate);	×
62
63	main_states_.AddTransition(update_commit_state_, se::Success, update_save_artifact_data_state_, tf::Immediate);	×
64	main_states_.AddTransition(update_commit_state_, se::Failure, update_check_rollback_state_, tf::Immediate);	×
65
66	main_states_.AddTransition(update_check_rollback_state_, se::Success, update_rollback_state_, tf::Immediate);	×
67	main_states_.AddTransition(update_check_rollback_state_, se::NothingToDo, update_failure_state_, tf::Immediate);	×
68	main_states_.AddTransition(update_check_rollback_state_, se::Failure, update_failure_state_, tf::Immediate);	×
69
70	main_states_.AddTransition(update_rollback_state_, se::Success, update_check_rollback_reboot_state_, tf::Immediate);	×
71	main_states_.AddTransition(update_rollback_state_, se::Failure, update_failure_state_, tf::Immediate);	×
72
73	main_states_.AddTransition(update_check_rollback_reboot_state_, se::Success, update_rollback_reboot_state_, tf::Immediate);	×
74	main_states_.AddTransition(update_check_rollback_reboot_state_, se::NothingToDo, update_failure_state_, tf::Immediate);	×
75	main_states_.AddTransition(update_check_rollback_reboot_state_, se::Failure, update_failure_state_, tf::Immediate);	×
76
77	main_states_.AddTransition(update_rollback_reboot_state_, se::Success, update_verify_rollback_reboot_state_, tf::Immediate);	×
78	main_states_.AddTransition(update_rollback_reboot_state_, se::Failure, update_failure_state_, tf::Immediate);	×
79
80	main_states_.AddTransition(update_verify_rollback_reboot_state_, se::Success, update_failure_state_, tf::Immediate);	×
81	main_states_.AddTransition(update_verify_rollback_reboot_state_, se::Failure, update_rollback_reboot_state_, tf::Immediate);	×
82
83	main_states_.AddTransition(update_failure_state_, se::Success, update_save_artifact_data_state_, tf::Immediate);	×
84	main_states_.AddTransition(update_failure_state_, se::Failure, update_save_artifact_data_state_, tf::Immediate);	×
85
86	main_states_.AddTransition(update_save_artifact_data_state_, se::Success, update_cleanup_state_, tf::Immediate);	×
87	// Even if this fails, there is nothing we can do at this point.
88	main_states_.AddTransition(update_save_artifact_data_state_, se::Failure, update_cleanup_state_, tf::Immediate);	×
89
90	main_states_.AddTransition(update_cleanup_state_, se::Success, idle_state_, tf::Immediate);	×
91	main_states_.AddTransition(update_cleanup_state_, se::Failure, idle_state_, tf::Immediate);	×
92	// clang-format on
93	}	×
94
95	error::Error StateMachine::Run() {	×
96	runner_.AttachToEventLoop(event_loop_);	×
97
98	// Client is supposed to do one handling of each on startup.
99	runner_.PostEvent(StateEvent::InventoryPollingTriggered);	×
100	runner_.PostEvent(StateEvent::DeploymentPollingTriggered);	×
101
102	event_loop_.Run();	×
103	return error::NoError;	×
104	}
105
106	} // namespace daemon
107	} // namespace update
108	} // namespace mender

mendersoftware / mender / 947394036

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous