a127fe22-c660-46bf-898d-03a7863fa8fb

pending completion

Build # a127fe22-c660-46bf-898d-03a7863fa8fb

Build Type

Pull #466

circleci

Committed by

hectorcorrea

Commit Message

Adjust the test to account for the new author formatting

Pull Request Pull Request #466: Display author affiliation (for PDC Describe records)

Run Details

49 of 49 new or added lines in 5 files covered. (100.0%)

2265 of 2353 relevant lines covered (96.26%)

187.04 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

81.25

/app/models/authors_citation.rb

# frozen_string_literal: true

class AuthorsCitation
  attr_reader :authors

  def initialize(authors)
    @authors = authors
    set_affiliation_index
  end

  # Set the index affiliation for the set of authors
  def set_affiliation_index
    orgs = @authors.map(&:affiliation_name).compact.uniq
    indexed_orgs = []
    orgs.each_with_index do |name, index|
      indexed_orgs << { name: name, index: index + 1 }
    end

    @authors.each do |author|
      author_org = author.affiliation_name
      if author_org
        indexed_org = indexed_orgs.find { |org| org[:name] == author_org }
        author.affiliation_index = indexed_org[:index]
      else
        author.affiliation_index = 0
      end
    end
  end
end

1	# frozen_string_literal: true
2
3	class AuthorsCitation	1✔
4	attr_reader :authors	1✔
5
6	def initialize(authors)	1✔
7	@authors = authors	15✔
8	set_affiliation_index	15✔
9	end
10
11	# Set the index affiliation for the set of authors
12	def set_affiliation_index	1✔
13	orgs = @authors.map(&:affiliation_name).compact.uniq	15✔
14	indexed_orgs = []	15✔
15	orgs.each_with_index do \|name, index\|	15✔
16	indexed_orgs << { name: name, index: index + 1 }	×
17	end
18
19	@authors.each do \|author\|	15✔
20	author_org = author.affiliation_name	83✔
21	if author_org	83✔
22	indexed_org = indexed_orgs.find { \|org\| org[:name] == author_org }	×
23	author.affiliation_index = indexed_org[:index]	×
24	else
25	author.affiliation_index = 0	83✔
26	end
27	end
28	end
29	end

pulibrary / pdc_discovery / a127fe22-c660-46bf-898d-03a7863fa8fb

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous