fa8448dd-0600-47e7-8889-1dfa562d11f0

Committed 05 Sep 2023 08:01PM UTC coverage: 86.172% (-4.9%) from 91.048%

Build # fa8448dd-0600-47e7-8889-1dfa562d11f0

Build Type

push

circleci

Committed by

sandbergja

Commit Message

i2239: Use SRU instead of Alma API for bib record retrieval

Run Details

8 of 8 new or added lines in 2 files covered. (100.0%)

3309 of 3840 relevant lines covered (86.17%)

326.63 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/app/adapters/alma_adapter/recap_alma_holding.rb

class AlmaAdapter
  # Handle the differences in holding enrichments done for ReCAP only.
  class RecapAlmaHolding < AlmaHolding
    # ReCAP can't handle a call number with both an 'h' and an 'i' subfield, so
    # combine them both into 'h'
    def enriched_852
      super.map do |original_field|
        original_field.tap do |field|
          call_no = callno_from_852(field)
          field.subfields.delete_if { |s| ['h', 'i'].include? s.code }
          field.append(MARC::Subfield.new('h', call_no))
          combine_location(field)
        end
      end
    end

    private

      # We need to combine 852 b/c for recap.
      def combine_location(field)
        return if field["b"].to_s.include?("$")
        b_code = "#{field['b']}$#{field['c']}"
        field.subfields.delete_if { |s| s.code == 'b' }
        field.append(MARC::Subfield.new('b', b_code))
      end

      # Copied from VoyagerHelpers. Combines h and i into one callnumber.
      def callno_from_852(field)
        call_no = field['h']
        return call_no if call_no.nil?
        call_no << ' ' + field['i'] if field['i']
        call_no.gsub!(/^[[:blank:]]+(.*)$/, '\1')
        call_no
      end
  end
end

1	class AlmaAdapter	×
2	# Handle the differences in holding enrichments done for ReCAP only.
3	class RecapAlmaHolding < AlmaHolding	×
4	# ReCAP can't handle a call number with both an 'h' and an 'i' subfield, so
5	# combine them both into 'h'
6	def enriched_852	×
7	super.map do \|original_field\|	×
8	original_field.tap do \|field\|	×
9	call_no = callno_from_852(field)	×
10	field.subfields.delete_if { \|s\| ['h', 'i'].include? s.code }	×
11	field.append(MARC::Subfield.new('h', call_no))	×
12	combine_location(field)	×
13	end	×
14	end	×
15	end	×
16
17	private	×
18
19	# We need to combine 852 b/c for recap.
20	def combine_location(field)	×
21	return if field["b"].to_s.include?("$")	×
22	b_code = "#{field['b']}$#{field['c']}"	×
23	field.subfields.delete_if { \|s\| s.code == 'b' }	×
24	field.append(MARC::Subfield.new('b', b_code))	×
25	end	×
26
27	# Copied from VoyagerHelpers. Combines h and i into one callnumber.
28	def callno_from_852(field)	×
29	call_no = field['h']	×
30	return call_no if call_no.nil?	×
31	call_no << ' ' + field['i'] if field['i']	×
32	call_no.gsub!(/^[[:blank:]]+(.*)$/, '\1')	×
33	call_no	×
34	end	×
35	end	×
36	end	×

pulibrary / bibdata / fa8448dd-0600-47e7-8889-1dfa562d11f0

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous