1208803966

Committed 11 Mar 2024 12:50PM UTC coverage: 83.61% (-16.4%) from 99.964%

Build # 1208803966

Build Type

Pull #4352

gitlab-ci

Committed by

aleksandrychev

Commit Message

chore: fixed abnormal connection close notification

Moved check before checking socketInitialized, because it can be not initialized in this case.

Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>

Pull Request Pull Request #4352: MEN-7081: fixed terminal closure made by exit command

Run Details

4431 of 6319 branches covered (70.12%)

3 of 16 new or added lines in 2 files covered. (18.75%)

1620 existing lines in 162 files now uncovered.

8407 of 10055 relevant lines covered (83.61%)

140.74 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.91

/src/js/utils/deploymentdevicehook.js

// Copyright 2023 Northern.tech AS
//
//    Licensed under the Apache License, Version 2.0 (the "License");
//    you may not use this file except in compliance with the License.
//    You may obtain a copy of the License at
//
//        http://www.apache.org/licenses/LICENSE-2.0
//
//    Unless required by applicable law or agreed to in writing, software
//    distributed under the License is distributed on an "AS IS" BASIS,
//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//    See the License for the specific language governing permissions and
//    limitations under the License.
import { useEffect, useRef } from 'react';
import { useDispatch, useSelector } from 'react-redux';

import isUUID from 'validator/lib/isUUID';

import { getDeviceById } from '../actions/deviceActions';
import { getDevicesById } from '../selectors';

export const useDeploymentDevice = deploymentName => {
  const isLoading = useRef(false);
  const dispatch = useDispatch();
  const devicesById = useSelector(getDevicesById);
  const hasDeviceInfo = !!devicesById[deploymentName];

  useEffect(() => {
    if (isLoading.current) {
      return;
    }
    isLoading.current = true;
    if (isUUID(deploymentName) && !hasDeviceInfo) {
      dispatch(getDeviceById(deploymentName)).then(() => (isLoading.current = false));
    }
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [deploymentName, dispatch, hasDeviceInfo]);
};

1	// Copyright 2023 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14	import { useEffect, useRef } from 'react';
15	import { useDispatch, useSelector } from 'react-redux';
16
17	import isUUID from 'validator/lib/isUUID';
18
19	import { getDeviceById } from '../actions/deviceActions';
20	import { getDevicesById } from '../selectors';
21
22	export const useDeploymentDevice = deploymentName => {	11✔
23	const isLoading = useRef(false);	411✔
24	const dispatch = useDispatch();	411✔
25	const devicesById = useSelector(getDevicesById);	411✔
26	const hasDeviceInfo = !!devicesById[deploymentName];	411✔
27
28	useEffect(() => {	411✔
29	if (isLoading.current) {	79✔
30	return;	6✔
31	}
32	isLoading.current = true;	73✔
33	if (isUUID(deploymentName) && !hasDeviceInfo) {	73!
UNCOV 34	dispatch(getDeviceById(deploymentName)).then(() => (isLoading.current = false));	×
35	}
36	// eslint-disable-next-line react-hooks/exhaustive-deps
37	}, [deploymentName, dispatch, hasDeviceInfo]);
38	};

mendersoftware / gui / 1208803966

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous