1301920191

Committed 23 May 2024 07:13AM UTC coverage: 83.42% (-16.5%) from 99.964%

Build # 1301920191

Build Type

Pull #4421

gitlab-ci

Committed by

mzedel

Commit Message

fix: fixed an issue that sometimes prevented reopening paginated auditlog links

Ticket: None
Changelog: Title
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>

Pull Request Pull Request #4421: MEN-7034 - device information in auditlog entries

Run Details

4456 of 6367 branches covered (69.99%)

34 of 35 new or added lines in 7 files covered. (97.14%)

1668 existing lines in 162 files now uncovered.

8473 of 10157 relevant lines covered (83.42%)

140.52 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.44

/src/js/components/settings/roles.js

// Copyright 2020 Northern.tech AS
//
//    Licensed under the Apache License, Version 2.0 (the "License");
//    you may not use this file except in compliance with the License.
//    You may obtain a copy of the License at
//
//        http://www.apache.org/licenses/LICENSE-2.0
//
//    Unless required by applicable law or agreed to in writing, software
//    distributed under the License is distributed on an "AS IS" BASIS,
//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//    See the License for the specific language governing permissions and
//    limitations under the License.
import React, { useEffect, useMemo, useState } from 'react';
import { useDispatch, useSelector } from 'react-redux';

// material ui
import { Add as AddIcon, ArrowRightAlt as ArrowRightAltIcon } from '@mui/icons-material';
import { Chip } from '@mui/material';

import { getDynamicGroups, getGroups } from '../../actions/deviceActions';
import { getExistingReleaseTags } from '../../actions/releaseActions.js';
import { createRole, editRole, getRoles, removeRole } from '../../actions/userActions';
import { BENEFITS } from '../../constants/appConstants';
import { emptyRole, rolesById } from '../../constants/userConstants';
import { getFeatures, getGroupsByIdWithoutUngrouped, getIsEnterprise, getReleaseTagsById, getRolesList } from '../../selectors';
import DetailsTable from '../common/detailstable';
import { DocsTooltip } from '../common/docslink';
import EnterpriseNotification from '../common/enterpriseNotification';
import { InfoHintContainer } from '../common/info-hint';
import RoleDefinition from './roledefinition';

const columns = [
  { key: 'name', title: 'Role', render: ({ name }) => name },
  { key: 'description', title: 'Description', render: ({ description }) => description || '-' },
  {
    key: 'manage',
    title: 'Manage',
    render: () => (
      <div className="bold flexbox center-aligned link-color margin-right-small uppercased" style={{ whiteSpace: 'nowrap' }}>
        view details <ArrowRightAltIcon />
      </div>
    )
  }
];

export const RoleManagement = () => {
  const [adding, setAdding] = useState(false);
  const [editing, setEditing] = useState(false);
  const [role, setRole] = useState({ ...emptyRole });
  const dispatch = useDispatch();
  const features = useSelector(getFeatures);
  const groups = useSelector(getGroupsByIdWithoutUngrouped);
  const releaseTags = useSelector(getReleaseTagsById);
  const roles = useSelector(getRolesList);
  const isEnterprise = useSelector(getIsEnterprise);

  useEffect(() => {
    dispatch(getExistingReleaseTags());
  }, [dispatch]);

  useEffect(() => {
    if (Object.keys(groups).length) {
      return;
    }
    dispatch(getDynamicGroups());
    dispatch(getGroups());
    dispatch(getRoles());
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [dispatch, JSON.stringify(groups)]);

  const addRole = () => {
    setAdding(true);
    setEditing(false);
    setRole({ ...emptyRole });
  };

  const onEditRole = editedRole => {
    setAdding(false);
    setEditing(true);
    setRole(editedRole);
  };

  const onCancel = () => {
    setAdding(false);
    setEditing(false);
  };

  const onSubmit = submittedRole => {
    if (adding) {
      dispatch(createRole(submittedRole));
    } else {
      dispatch(editRole(submittedRole));
    }
    onCancel();
  };

  const items = useMemo(
    () =>
      Object.keys(rolesById)
        .reverse()
        .reduce((accu, key) => {
          const index = accu.findIndex(({ id }) => id === key);
          accu = [accu[index], ...accu.filter((item, itemIndex) => index !== itemIndex)];
          return accu;
        }, roles),
    // eslint-disable-next-line react-hooks/exhaustive-deps
    [JSON.stringify(roles)]
  );

  return (
    <div>
      <div className="flexbox center-aligned">
        <h2 style={{ marginLeft: 20 }}>Roles</h2>
        <InfoHintContainer>
          <EnterpriseNotification id={BENEFITS.rbac.id} />
          <DocsTooltip />
        </InfoHintContainer>
      </div>
      <DetailsTable columns={columns} items={items} onItemClick={onEditRole} />
      <Chip color="primary" icon={<AddIcon />} label="Add a role" onClick={addRole} disabled={!isEnterprise} />
      <RoleDefinition
        adding={adding}
        editing={editing}
        features={features}
        onCancel={onCancel}
        onSubmit={onSubmit}
        removeRole={name => dispatch(removeRole(name))}
        selectedRole={role}
        stateGroups={groups}
        stateReleaseTags={releaseTags}
      />
    </div>
  );
};

export default RoleManagement;

1	// Copyright 2020 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14	import React, { useEffect, useMemo, useState } from 'react';
15	import { useDispatch, useSelector } from 'react-redux';
16
17	// material ui
18	import { Add as AddIcon, ArrowRightAlt as ArrowRightAltIcon } from '@mui/icons-material';
19	import { Chip } from '@mui/material';
20
21	import { getDynamicGroups, getGroups } from '../../actions/deviceActions';
22	import { getExistingReleaseTags } from '../../actions/releaseActions.js';
23	import { createRole, editRole, getRoles, removeRole } from '../../actions/userActions';
24	import { BENEFITS } from '../../constants/appConstants';
25	import { emptyRole, rolesById } from '../../constants/userConstants';
26	import { getFeatures, getGroupsByIdWithoutUngrouped, getIsEnterprise, getReleaseTagsById, getRolesList } from '../../selectors';
27	import DetailsTable from '../common/detailstable';
28	import { DocsTooltip } from '../common/docslink';
29	import EnterpriseNotification from '../common/enterpriseNotification';
30	import { InfoHintContainer } from '../common/info-hint';
31	import RoleDefinition from './roledefinition';
32
33	const columns = [	4✔
34	{ key: 'name', title: 'Role', render: ({ name }) => name },	67✔
35	{ key: 'description', title: 'Description', render: ({ description }) => description \|\| '-' },	67✔
36	{
37	key: 'manage',
38	title: 'Manage',
39	render: () => (
40	<div className="bold flexbox center-aligned link-color margin-right-small uppercased" style={{ whiteSpace: 'nowrap' }}>	67✔
41	view details <ArrowRightAltIcon />
42	</div>
43	)
44	}
45	];
46
47	export const RoleManagement = () => {	4✔
48	const [adding, setAdding] = useState(false);	8✔
49	const [editing, setEditing] = useState(false);	8✔
50	const [role, setRole] = useState({ ...emptyRole });	8✔
51	const dispatch = useDispatch();	8✔
52	const features = useSelector(getFeatures);	8✔
53	const groups = useSelector(getGroupsByIdWithoutUngrouped);	8✔
54	const releaseTags = useSelector(getReleaseTagsById);	8✔
55	const roles = useSelector(getRolesList);	8✔
56	const isEnterprise = useSelector(getIsEnterprise);	8✔
57
58	useEffect(() => {	8✔
59	dispatch(getExistingReleaseTags());	2✔
60	}, [dispatch]);
61
62	useEffect(() => {	8✔
63	if (Object.keys(groups).length) {	2!
64	return;	2✔
65	}
UNCOV 66	dispatch(getDynamicGroups());	×
UNCOV 67	dispatch(getGroups());	×
UNCOV 68	dispatch(getRoles());	×
69	// eslint-disable-next-line react-hooks/exhaustive-deps
70	}, [dispatch, JSON.stringify(groups)]);
71
72	const addRole = () => {	8✔
UNCOV 73	setAdding(true);	×
UNCOV 74	setEditing(false);	×
UNCOV 75	setRole({ ...emptyRole });	×
76	};
77
78	const onEditRole = editedRole => {	8✔
79	setAdding(false);	2✔
80	setEditing(true);	2✔
81	setRole(editedRole);	2✔
82	};
83
84	const onCancel = () => {	8✔
85	setAdding(false);	2✔
86	setEditing(false);	2✔
87	};
88
89	const onSubmit = submittedRole => {	8✔
90	if (adding) {	1!
UNCOV 91	dispatch(createRole(submittedRole));	×
92	} else {
93	dispatch(editRole(submittedRole));	1✔
94	}
95	onCancel();	1✔
96	};
97
98	const items = useMemo(	8✔
99	() =>
100	Object.keys(rolesById)	4✔
101	.reverse()
102	.reduce((accu, key) => {
103	const index = accu.findIndex(({ id }) => id === key);	100✔
104	accu = [accu[index], ...accu.filter((item, itemIndex) => index !== itemIndex)];	185✔
105	return accu;	20✔
106	}, roles),
107	// eslint-disable-next-line react-hooks/exhaustive-deps
108	[JSON.stringify(roles)]
109	);
110
111	return (	8✔
112	<div>
113	<div className="flexbox center-aligned">
114	<h2 style={{ marginLeft: 20 }}>Roles</h2>
115	<InfoHintContainer>
116	<EnterpriseNotification id={BENEFITS.rbac.id} />
117	<DocsTooltip />
118	</InfoHintContainer>
119	</div>
120	<DetailsTable columns={columns} items={items} onItemClick={onEditRole} />
121	<Chip color="primary" icon={<AddIcon />} label="Add a role" onClick={addRole} disabled={!isEnterprise} />
122	<RoleDefinition
123	adding={adding}
124	editing={editing}
125	features={features}
126	onCancel={onCancel}
127	onSubmit={onSubmit}
128	removeRole={name => dispatch(removeRole(name))}	1✔
129	selectedRole={role}
130	stateGroups={groups}
131	stateReleaseTags={releaseTags}
132	/>
133	</div>
134	);
135	};
136
137	export default RoleManagement;

mendersoftware / gui / 1301920191

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous