#5122

Committed 26 Jun 2024 07:16PM CUT coverage: 21.692% (-0.2%) from 21.862%

Build # #5122

Build Type

push

coveralls-python

Committed by

benjaminmah

Commit Message

Reverted changes

Run Details

716 of 3628 branches covered (19.74%)

0 of 5 new or added lines in 1 file covered. (0.0%)

182 existing lines in 4 files now uncovered.

1933 of 8911 relevant lines covered (21.69%)

0.22 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/bugbot/rules/inactive_patch_author.py

# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this file,
# You can obtain one at http://mozilla.org/MPL/2.0/.

import logging
import re
from typing import Dict, List

from libmozdata.connection import Connection
from libmozdata.phabricator import PhabricatorAPI
from tenacity import retry, stop_after_attempt, wait_exponential

from bugbot import people, utils
from bugbot.bzcleaner import BzCleaner
from bugbot.user_activity import PHAB_CHUNK_SIZE, UserActivity, UserStatus

logging.basicConfig(level=logging.DEBUG)
PHAB_FILE_NAME_PAT = re.compile(r"phabricator-D([0-9]+)-url\.txt")


class InactivePatchAuthors(BzCleaner):
    """Bugs with patches authored by inactive patch authors"""

    def __init__(self):
        super(InactivePatchAuthors, self).__init__()
        self.phab = PhabricatorAPI(utils.get_login_info()["phab_api_key"])
        self.user_activity = UserActivity(include_fields=["nick"], phab=self.phab)
        self.default_assignees = utils.get_default_assignees()
        self.people = people.People.get_instance()

    def description(self):
        return "Bugs with inactive patch authors"

    def columns(self):
        return ["id", "summary"]

    def get_bugs(self, date="today", bug_ids=[], chunk_size=None):
        bugs = super().get_bugs(date, bug_ids, chunk_size)

        logging.info(f"BUGS RETRIEVED > {bugs}")
        rev_ids = {rev_id for bug in bugs.values() for rev_id in bug["rev_ids"]}
        inactive_authors = self._get_inactive_patch_authors(list(rev_ids))

        for bugid, bug in list(bugs.items()):
            inactive_patches = [
                {"rev_id": rev_id, "author": inactive_authors[rev_id]}
                for rev_id in bug["rev_ids"]
                if rev_id in inactive_authors
            ]

            if inactive_patches:
                bug["inactive_patches"] = inactive_patches
                self.unassign_inactive_author(bugid, bug, inactive_patches)
                print(f"Bug {bugid} has inactive patches: {inactive_patches}")
            else:
                del bugs[bugid]

        return bugs

    def unassign_inactive_author(self, bugid, bug, inactive_patches):
        # print(f"\n BUG >> {bugid} >> {bug}\n")
        # prod = bug["product"]
        # comp = bug["component"]
        default_assignee = "bmah@mozilla.com"
        autofix = {"assigned_to": default_assignee}

        comment = (
            "The patch author is inactive on Bugzilla, so the assignee is being reset."
        )
        autofix["comment"] = {"body": comment}

        self.autofix_changes[bugid] = autofix

    def _get_inactive_patch_authors(self, rev_ids: list) -> Dict[int, dict]:
        revisions: List[dict] = []

        for _rev_ids in Connection.chunks(rev_ids, PHAB_CHUNK_SIZE):
            for revision in self._fetch_revisions(_rev_ids):
                author_phid = revision["fields"]["authorPHID"]
                created_at = revision["fields"]["dateCreated"]
                if author_phid == "PHID-USER-eltrc7x5oplwzfguutrb":
                    continue
                revisions.append(
                    {
                        "rev_id": revision["id"],
                        "author_phid": author_phid,
                        "created_at": created_at,
                    }
                )

        user_phids = set()

        for revision in revisions:
            user_phids.add(revision["author_phid"])

        users = self.user_activity.get_phab_users_with_status(
            list(user_phids), keep_active=False
        )

        result: Dict[int, dict] = {}
        for revision in revisions:
            author_phid = revision["author_phid"]

            if author_phid not in users:
                continue

            author_info = users[author_phid]
            if author_info["status"] == UserStatus.INACTIVE:
                result[revision["rev_id"]] = {
                    "name": author_info["name"],
                    "status": author_info["status"],
                    "last_active": author_info.get("last_seen_date"),
                }

        return result

    @retry(
        wait=wait_exponential(min=4),
        stop=stop_after_attempt(5),
    )
    def _fetch_revisions(self, ids: list):
        return self.phab.request(
            "differential.revision.search",
            constraints={"ids": ids},
        )["data"]

    def handle_bug(self, bug, data):
        rev_ids = [
            int(attachment["file_name"][13:-8])
            for attachment in bug["attachments"]
            if attachment["content_type"] == "text/x-phabricator-request"
            and PHAB_FILE_NAME_PAT.match(attachment["file_name"])
            and not attachment["is_obsolete"]
        ]

        if not rev_ids:
            return

        bugid = str(bug["id"])
        data[bugid] = {
            "rev_ids": rev_ids,
        }
        return bug

    def get_bz_params(self, date):
        fields = [
            "comments.raw_text",
            "comments.creator",
            "attachments.file_name",
            "attachments.content_type",
            "attachments.is_obsolete",
            "product",
            "component",
        ]
        params = {
            "include_fields": fields,
            "resolution": "---",
            "f1": "attachments.ispatch",
            "o1": "equals",
            "v1": "1",
        }

        return params


if __name__ == "__main__":
    InactivePatchAuthors().run()

1	# This Source Code Form is subject to the terms of the Mozilla Public
2	# License, v. 2.0. If a copy of the MPL was not distributed with this file,
3	# You can obtain one at http://mozilla.org/MPL/2.0/.
4
NEW 5	import logging	×
6	import re	×
7	from typing import Dict, List	×
8
9	from libmozdata.connection import Connection	×
10	from libmozdata.phabricator import PhabricatorAPI	×
11	from tenacity import retry, stop_after_attempt, wait_exponential	×
12
13	from bugbot import people, utils	×
14	from bugbot.bzcleaner import BzCleaner	×
15	from bugbot.user_activity import PHAB_CHUNK_SIZE, UserActivity, UserStatus	×
16
NEW 17	logging.basicConfig(level=logging.DEBUG)	×
18	PHAB_FILE_NAME_PAT = re.compile(r"phabricator-D([0-9]+)-url\.txt")	×
19
20
NEW 21	class InactivePatchAuthors(BzCleaner):	×
22	"""Bugs with patches authored by inactive patch authors"""
23
24	def __init__(self):	×
25	super(InactivePatchAuthors, self).__init__()	×
26	self.phab = PhabricatorAPI(utils.get_login_info()["phab_api_key"])	×
27	self.user_activity = UserActivity(include_fields=["nick"], phab=self.phab)	×
28	self.default_assignees = utils.get_default_assignees()	×
29	self.people = people.People.get_instance()	×
30
31	def description(self):	×
32	return "Bugs with inactive patch authors"	×
33
34	def columns(self):	×
35	return ["id", "summary"]	×
36
37	def get_bugs(self, date="today", bug_ids=[], chunk_size=None):	×
38	bugs = super().get_bugs(date, bug_ids, chunk_size)	×
39
NEW 40	logging.info(f"BUGS RETRIEVED > {bugs}")	×
41	rev_ids = {rev_id for bug in bugs.values() for rev_id in bug["rev_ids"]}	×
42	inactive_authors = self._get_inactive_patch_authors(list(rev_ids))	×
43
44	for bugid, bug in list(bugs.items()):	×
45	inactive_patches = [	×
46	{"rev_id": rev_id, "author": inactive_authors[rev_id]}
47	for rev_id in bug["rev_ids"]
48	if rev_id in inactive_authors
49	]
50
51	if inactive_patches:	×
52	bug["inactive_patches"] = inactive_patches	×
53	self.unassign_inactive_author(bugid, bug, inactive_patches)	×
54	print(f"Bug {bugid} has inactive patches: {inactive_patches}")	×
55	else:
56	del bugs[bugid]	×
57
58	return bugs	×
59
60	def unassign_inactive_author(self, bugid, bug, inactive_patches):	×
61	# print(f"\n BUG >> {bugid} >> {bug}\n")
62	# prod = bug["product"]
63	# comp = bug["component"]
NEW 64	default_assignee = "bmah@mozilla.com"	×
65	autofix = {"assigned_to": default_assignee}	×
66
67	comment = (	×
68	"The patch author is inactive on Bugzilla, so the assignee is being reset."
69	)
70	autofix["comment"] = {"body": comment}	×
71
72	self.autofix_changes[bugid] = autofix	×
73
74	def _get_inactive_patch_authors(self, rev_ids: list) -> Dict[int, dict]:	×
75	revisions: List[dict] = []	×
76
77	for _rev_ids in Connection.chunks(rev_ids, PHAB_CHUNK_SIZE):	×
78	for revision in self._fetch_revisions(_rev_ids):	×
79	author_phid = revision["fields"]["authorPHID"]	×
80	created_at = revision["fields"]["dateCreated"]	×
81	if author_phid == "PHID-USER-eltrc7x5oplwzfguutrb":	×
82	continue	×
83	revisions.append(	×
84	{
85	"rev_id": revision["id"],
86	"author_phid": author_phid,
87	"created_at": created_at,
88	}
89	)
90
91	user_phids = set()	×
92
93	for revision in revisions:	×
94	user_phids.add(revision["author_phid"])	×
95
96	users = self.user_activity.get_phab_users_with_status(	×
97	list(user_phids), keep_active=False
98	)
99
100	result: Dict[int, dict] = {}	×
101	for revision in revisions:	×
102	author_phid = revision["author_phid"]	×
103
104	if author_phid not in users:	×
105	continue	×
106
107	author_info = users[author_phid]	×
108	if author_info["status"] == UserStatus.INACTIVE:	×
109	result[revision["rev_id"]] = {	×
110	"name": author_info["name"],
111	"status": author_info["status"],
112	"last_active": author_info.get("last_seen_date"),
113	}
114
115	return result	×
116
117	@retry(	×
118	wait=wait_exponential(min=4),
119	stop=stop_after_attempt(5),
120	)
121	def _fetch_revisions(self, ids: list):	×
122	return self.phab.request(	×
123	"differential.revision.search",
124	constraints={"ids": ids},
125	)["data"]
126
127	def handle_bug(self, bug, data):	×
128	rev_ids = [	×
129	int(attachment["file_name"][13:-8])
130	for attachment in bug["attachments"]
131	if attachment["content_type"] == "text/x-phabricator-request"
132	and PHAB_FILE_NAME_PAT.match(attachment["file_name"])
133	and not attachment["is_obsolete"]
134	]
135
136	if not rev_ids:	×
137	return	×
138
139	bugid = str(bug["id"])	×
140	data[bugid] = {	×
141	"rev_ids": rev_ids,
142	}
143	return bug	×
144
145	def get_bz_params(self, date):	×
146	fields = [	×
147	"comments.raw_text",
148	"comments.creator",
149	"attachments.file_name",
150	"attachments.content_type",
151	"attachments.is_obsolete",
152	"product",
153	"component",
154	]
155	params = {	×
156	"include_fields": fields,
157	"resolution": "---",
158	"f1": "attachments.ispatch",
159	"o1": "equals",
160	"v1": "1",
161	}
162
163	return params	×
164
165
166	if __name__ == "__main__":	×
167	InactivePatchAuthors().run()	×

mozilla / relman-auto-nag / #5122

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous