1350829378

Committed 27 Jun 2024 01:46PM UTC coverage: 83.494% (-16.5%) from 99.965%

Build # 1350829378

Build Type

Pull #4465

gitlab-ci

Committed by

mzedel

Commit Message

chore: test fixes

Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>

Pull Request Pull Request #4465: MEN-7169 - feat: added multi sorting capabilities to devices view

Run Details

4506 of 6430 branches covered (70.08%)

81 of 100 new or added lines in 14 files covered. (81.0%)

1661 existing lines in 163 files now uncovered.

8574 of 10269 relevant lines covered (83.49%)

160.6 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

92.31

/src/js/components/common/devicenameinput.js

// Copyright 2021 Northern.tech AS
//
//    Licensed under the Apache License, Version 2.0 (the "License");
//    you may not use this file except in compliance with the License.
//    You may obtain a copy of the License at
//
//        http://www.apache.org/licenses/LICENSE-2.0
//
//    Unless required by applicable law or agreed to in writing, software
//    distributed under the License is distributed on an "AS IS" BASIS,
//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//    See the License for the specific language governing permissions and
//    limitations under the License.
import React, { useEffect, useRef, useState } from 'react';
import { useDispatch } from 'react-redux';

// material ui
import { Input, InputAdornment } from '@mui/material';
import { makeStyles } from 'tss-react/mui';

import { setDeviceTags } from '../../actions/deviceActions';
import { ConfirmationButtons, EditButton } from './confirm';

const useStyles = makeStyles()(theme => ({
  icon: {
    fontSize: '1.25rem'
  },
  input: {
    color: theme.palette.text.primary,
    fontSize: '0.8125rem'
  }
}));

export const DeviceNameInput = ({ device, isHovered }) => {
  const [isEditing, setIsEditing] = useState(false);
  const [value, setValue] = useState('');
  const { classes } = useStyles();
  const inputRef = useRef();

  const dispatch = useDispatch();

  const { id = '', tags = {} } = device;
  const { name = '' } = tags;

  useEffect(() => {
    if (!isEditing && name !== value) {
      setValue(name);
    }
  }, [device, isEditing, name, value]);

  useEffect(() => {
    if (!isEditing || !inputRef.current) {
      return;
    }
    inputRef.current.focus();
  }, [isEditing]);

  const onSubmit = () => dispatch(setDeviceTags(id, { ...tags, name: value })).then(() => setIsEditing(false));

  const onCancel = () => {
    setValue(name);
    setIsEditing(false);
  };

  const onStartEdit = e => {
    e.stopPropagation();
    setIsEditing(true);
  };

  const onInputClick = e => e.stopPropagation();

  return (
    <Input
      id={`${device.id}-id-input`}
      className={classes.input}
      disabled={!isEditing}
      inputRef={inputRef}
      value={value}
      placeholder={`${id.substring(0, 6)}...`}
      onClick={onInputClick}
      onChange={({ target: { value } }) => setValue(value)}
      type="text"
      endAdornment={
        (isHovered || isEditing) && (
          <InputAdornment position="end">
            {isEditing ? <ConfirmationButtons onCancel={onCancel} onConfirm={onSubmit} /> : <EditButton onClick={onStartEdit} />}
          </InputAdornment>
        )
      }
    />
  );
};

export default DeviceNameInput;

1	// Copyright 2021 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14	import React, { useEffect, useRef, useState } from 'react';
15	import { useDispatch } from 'react-redux';
16
17	// material ui
18	import { Input, InputAdornment } from '@mui/material';
19	import { makeStyles } from 'tss-react/mui';
20
21	import { setDeviceTags } from '../../actions/deviceActions';
22	import { ConfirmationButtons, EditButton } from './confirm';
23
24	const useStyles = makeStyles()(theme => ({	29✔
25	icon: {
26	fontSize: '1.25rem'
27	},
28	input: {
29	color: theme.palette.text.primary,
30	fontSize: '0.8125rem'
31	}
32	}));
33
34	export const DeviceNameInput = ({ device, isHovered }) => {	29✔
35	const [isEditing, setIsEditing] = useState(false);	18✔
36	const [value, setValue] = useState('');	18✔
37	const { classes } = useStyles();	18✔
38	const inputRef = useRef();	18✔
39
40	const dispatch = useDispatch();	18✔
41
42	const { id = '', tags = {} } = device;	18!
43	const { name = '' } = tags;	18✔
44
45	useEffect(() => {	18✔
46	if (!isEditing && name !== value) {	18✔
47	setValue(name);	2✔
48	}
49	}, [device, isEditing, name, value]);
50
51	useEffect(() => {	18✔
52	if (!isEditing \|\| !inputRef.current) {	7✔
53	return;	6✔
54	}
55	inputRef.current.focus();	1✔
56	}, [isEditing]);
57
58	const onSubmit = () => dispatch(setDeviceTags(id, { ...tags, name: value })).then(() => setIsEditing(false));	18✔
59
60	const onCancel = () => {	18✔
UNCOV 61	setValue(name);	×
UNCOV 62	setIsEditing(false);	×
63	};
64
65	const onStartEdit = e => {	18✔
66	e.stopPropagation();	1✔
67	setIsEditing(true);	1✔
68	};
69
70	const onInputClick = e => e.stopPropagation();	18✔
71
72	return (	18✔
73	<Input
74	id={`${device.id}-id-input`}
75	className={classes.input}
76	disabled={!isEditing}
77	inputRef={inputRef}
78	value={value}
79	placeholder={`${id.substring(0, 6)}...`}
80	onClick={onInputClick}
81	onChange={({ target: { value } }) => setValue(value)}	9✔
82	type="text"
83	endAdornment={
84	(isHovered \|\| isEditing) && (	36!
85	<InputAdornment position="end">
86	{isEditing ? <ConfirmationButtons onCancel={onCancel} onConfirm={onSubmit} /> : <EditButton onClick={onStartEdit} />}	18✔
87	</InputAdornment>
88	)
89	}
90	/>
91	);
92	};
93
94	export default DeviceNameInput;

mendersoftware / gui / 1350829378

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous