11393106485

Committed 17 Oct 2024 09:10PM UTC coverage: 57.848% (-1.0%) from 58.81%

Build # 11393106485

Build Type

Pull #9148

github

Committed by

ProofOfKeags

Commit Message

lnwire: convert DynPropose and DynCommit to use typed tlv records

Pull Request Pull Request #9148: DynComms [2/n]: lnwire: add authenticated wire messages for Dyn*

Run Details

142 of 177 new or added lines in 4 files covered. (80.23%)

18983 existing lines in 242 files now uncovered.

99003 of 171143 relevant lines covered (57.85%)

36968.25 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

64.94

/feature/manager.go

package feature

import (
        "errors"
        "fmt"

        "github.com/lightningnetwork/lnd/lnwire"
)

var (
        // ErrUnknownSet is returned if a proposed feature vector contains a
        // set that is unknown to LND.
        ErrUnknownSet = errors.New("unknown feature bit set")

        // ErrFeatureConfigured is returned if an attempt is made to unset a
        // feature that was configured at startup.
        ErrFeatureConfigured = errors.New("can't unset configured feature")
)

// Config houses any runtime modifications to the default set descriptors. For
// our purposes, this typically means disabling certain features to test legacy
// protocol interoperability or functionality.
type Config struct {
        // NoTLVOnion unsets any optional or required TLVOnionPaylod bits from
        // all feature sets.
        NoTLVOnion bool

        // NoStaticRemoteKey unsets any optional or required StaticRemoteKey
        // bits from all feature sets.
        NoStaticRemoteKey bool

        // NoAnchors unsets any bits signaling support for anchor outputs.
        NoAnchors bool

        // NoWumbo unsets any bits signalling support for wumbo channels.
        NoWumbo bool

        // NoTaprootChans unsets any bits signaling support for taproot
        // channels.
        NoTaprootChans bool

        // NoScriptEnforcementLease unsets any bits signaling support for script
        // enforced leases.
        NoScriptEnforcementLease bool

        // NoKeysend unsets any bits signaling support for accepting keysend
        // payments.
        NoKeysend bool

        // NoOptionScidAlias unsets any bits signalling support for
        // option_scid_alias. This also implicitly disables zero-conf channels.
        NoOptionScidAlias bool

        // NoZeroConf unsets any bits signalling support for zero-conf
        // channels. This should be used instead of NoOptionScidAlias to still
        // keep option-scid-alias support.
        NoZeroConf bool

        // NoAnySegwit unsets any bits that signal support for using other
        // segwit witness versions for co-op closes.
        NoAnySegwit bool

        // NoRouteBlinding unsets route blinding feature bits.
        NoRouteBlinding bool

        // NoTaprootOverlay unsets the taproot overlay channel feature bits.
        NoTaprootOverlay bool

        // CustomFeatures is a set of custom features to advertise in each
        // set.
        CustomFeatures map[Set][]lnwire.FeatureBit
}

// Manager is responsible for generating feature vectors for different requested
// feature sets.
type Manager struct {
        // fsets is a static map of feature set to raw feature vectors. Requests
        // are fulfilled by cloning these internal feature vectors.
        fsets map[Set]*lnwire.RawFeatureVector

        // configFeatures is a set of custom features that were "hard set" in
        // lnd's config that cannot be updated at runtime (as is the case with
        // our "standard" features that are defined in LND).
        configFeatures map[Set]*lnwire.FeatureVector
}

// NewManager creates a new feature Manager, applying any custom modifications
// to its feature sets before returning.
func NewManager(cfg Config) (*Manager, error) {
        return newManager(cfg, defaultSetDesc)
}

// newManager creates a new feature Manager, applying any custom modifications
// to its feature sets before returning. This method accepts the setDesc as its
// own parameter so that it can be unit tested.
func newManager(cfg Config, desc setDesc) (*Manager, error) {
        // First build the default feature vector for all known sets.
        fsets := make(map[Set]*lnwire.RawFeatureVector)
        for bit, sets := range desc {
                for set := range sets {
                        // Fetch the feature vector for this set, allocating a
                        // new one if it doesn't exist.
                        fv, ok := fsets[set]
                        if !ok {
                                fv = lnwire.NewRawFeatureVector()
                        }

                        // Set the configured bit on the feature vector,
                        // ensuring that we don't set two feature bits for the
                        // same pair.
                        err := fv.SafeSet(bit)
                        if err != nil {
                                return nil, fmt.Errorf("unable to set "+
                                        "%v in %v: %v", bit, set, err)
                        }

                        // Write the updated feature vector under its set.
                        fsets[set] = fv
                }
        }

        // Now, remove any features as directed by the config.
        configFeatures := make(map[Set]*lnwire.FeatureVector)
        for set, raw := range fsets {
                if cfg.NoTLVOnion {
                        raw.Unset(lnwire.TLVOnionPayloadOptional)
                        raw.Unset(lnwire.TLVOnionPayloadRequired)
                        raw.Unset(lnwire.PaymentAddrOptional)
                        raw.Unset(lnwire.PaymentAddrRequired)
                        raw.Unset(lnwire.MPPOptional)
                        raw.Unset(lnwire.MPPRequired)
                        raw.Unset(lnwire.RouteBlindingOptional)
                        raw.Unset(lnwire.RouteBlindingRequired)
                        raw.Unset(lnwire.Bolt11BlindedPathsOptional)
                        raw.Unset(lnwire.Bolt11BlindedPathsRequired)
                        raw.Unset(lnwire.AMPOptional)
                        raw.Unset(lnwire.AMPRequired)
                        raw.Unset(lnwire.KeysendOptional)
                        raw.Unset(lnwire.KeysendRequired)
                }
                if cfg.NoStaticRemoteKey {
                        raw.Unset(lnwire.StaticRemoteKeyOptional)
                        raw.Unset(lnwire.StaticRemoteKeyRequired)
                }
                if cfg.NoAnchors {
                        raw.Unset(lnwire.AnchorsZeroFeeHtlcTxOptional)
                        raw.Unset(lnwire.AnchorsZeroFeeHtlcTxRequired)

                        // If anchors are disabled, then we also need to
                        // disable all other features that depend on it as
                        // well, as otherwise we may create an invalid feature
                        // bit set.
                        for bit, depFeatures := range deps {
                                for depFeature := range depFeatures {
                                        switch {
                                        case depFeature == lnwire.AnchorsZeroFeeHtlcTxRequired:
                                                fallthrough
                                        case depFeature == lnwire.AnchorsZeroFeeHtlcTxOptional:
                                                raw.Unset(bit)
                                        }
                                }
                        }
                }
                if cfg.NoWumbo {
                        raw.Unset(lnwire.WumboChannelsOptional)
                        raw.Unset(lnwire.WumboChannelsRequired)
                }
                if cfg.NoScriptEnforcementLease {
                        raw.Unset(lnwire.ScriptEnforcedLeaseOptional)
                        raw.Unset(lnwire.ScriptEnforcedLeaseRequired)
                }
                if cfg.NoKeysend {
                        raw.Unset(lnwire.KeysendOptional)
                        raw.Unset(lnwire.KeysendRequired)
                }
                if cfg.NoOptionScidAlias {
                        raw.Unset(lnwire.ScidAliasOptional)
                        raw.Unset(lnwire.ScidAliasRequired)
                }
                if cfg.NoZeroConf {
                        raw.Unset(lnwire.ZeroConfOptional)
                        raw.Unset(lnwire.ZeroConfRequired)
                }
                if cfg.NoAnySegwit {
                        raw.Unset(lnwire.ShutdownAnySegwitOptional)
                        raw.Unset(lnwire.ShutdownAnySegwitRequired)
                }
                if cfg.NoTaprootChans {
                        raw.Unset(lnwire.SimpleTaprootChannelsOptionalStaging)
                        raw.Unset(lnwire.SimpleTaprootChannelsRequiredStaging)
                }
                if cfg.NoRouteBlinding {
                        raw.Unset(lnwire.RouteBlindingOptional)
                        raw.Unset(lnwire.RouteBlindingRequired)
                        raw.Unset(lnwire.Bolt11BlindedPathsOptional)
                        raw.Unset(lnwire.Bolt11BlindedPathsRequired)
                }
                if cfg.NoTaprootOverlay {
                        raw.Unset(lnwire.SimpleTaprootOverlayChansOptional)
                        raw.Unset(lnwire.SimpleTaprootOverlayChansRequired)
                }
                for _, custom := range cfg.CustomFeatures[set] {
                        if custom > set.Maximum() {
                                return nil, fmt.Errorf("feature bit: %v "+
                                        "exceeds set: %v maximum: %v", custom,
                                        set, set.Maximum())
                        }

                        if raw.IsSet(custom) {
                                return nil, fmt.Errorf("feature bit: %v "+
                                        "already set", custom)
                        }

                        if err := raw.SafeSet(custom); err != nil {
                                return nil, fmt.Errorf("%w: could not set "+
                                        "feature: %d", err, custom)
                        }
                }

                // Track custom features separately so that we can check that
                // they aren't unset in subsequent updates. If there is no
                // entry for the set, the vector will just be empty.
                configFeatures[set] = lnwire.NewFeatureVector(
                        lnwire.NewRawFeatureVector(cfg.CustomFeatures[set]...),
                        lnwire.Features,
                )

                // Ensure that all of our feature sets properly set any
                // dependent features.
                fv := lnwire.NewFeatureVector(raw, lnwire.Features)
                err := ValidateDeps(fv)
                if err != nil {
                        return nil, fmt.Errorf("invalid feature set %v: %w",
                                set, err)
                }
        }

        return &Manager{
                fsets:          fsets,
                configFeatures: configFeatures,
        }, nil
}

// GetRaw returns a raw feature vector for the passed set. If no set is known,
// an empty raw feature vector is returned.
func (m *Manager) GetRaw(set Set) *lnwire.RawFeatureVector {
        if fv, ok := m.fsets[set]; ok {
                return fv.Clone()
        }

        return lnwire.NewRawFeatureVector()
}

// setRaw sets a new raw feature vector for the given set.
func (m *Manager) setRaw(set Set, raw *lnwire.RawFeatureVector) {
        m.fsets[set] = raw
}

// Get returns a feature vector for the passed set. If no set is known, an empty
// feature vector is returned.
func (m *Manager) Get(set Set) *lnwire.FeatureVector {
        raw := m.GetRaw(set)
        return lnwire.NewFeatureVector(raw, lnwire.Features)
}

// ListSets returns a list of the feature sets that our node supports.
func (m *Manager) ListSets() []Set {
        var sets []Set

        for set := range m.fsets {
                sets = append(sets, set)
        }

        return sets
}

// UpdateFeatureSets accepts a map of new feature vectors for each of the
// manager's known sets, validates that the update can be applied and modifies
// the feature manager's internal state. If a set is not included in the update
// map, it is left unchanged. The feature vectors provided are expected to
// include the current set of features, updated with desired bits added/removed.
func (m *Manager) UpdateFeatureSets(
        updates map[Set]*lnwire.RawFeatureVector) error {

        for set, newFeatures := range updates {
                if !set.valid() {
                        return fmt.Errorf("%w: set: %d", ErrUnknownSet, set)
                }

                if err := newFeatures.ValidatePairs(); err != nil {
                        return err
                }

                if err := m.Get(set).ValidateUpdate(
                        newFeatures, set.Maximum(),
                ); err != nil {
                        return err
                }

                // If any features were configured for this set, ensure that
                // they are still set in the new feature vector.
                if cfgFeat, haveCfgFeat := m.configFeatures[set]; haveCfgFeat {
                        for feature := range cfgFeat.Features() {
                                if !newFeatures.IsSet(feature) {
                                        return fmt.Errorf("%w: can't unset: "+
                                                "%d", ErrFeatureConfigured,
                                                feature)
                                }
                        }
                }

                fv := lnwire.NewFeatureVector(newFeatures, lnwire.Features)
                if err := ValidateDeps(fv); err != nil {
                        return err
                }
        }

        // Only update the current feature sets once every proposed set has
        // passed validation so that we don't partially update any sets then
        // fail out on a later set's validation.
        for set, features := range updates {
                m.setRaw(set, features.Clone())
        }

        return nil
}

1	package feature
2
3	import (
4	"errors"
5	"fmt"
6
7	"github.com/lightningnetwork/lnd/lnwire"
8	)
9
10	var (
11	// ErrUnknownSet is returned if a proposed feature vector contains a
12	// set that is unknown to LND.
13	ErrUnknownSet = errors.New("unknown feature bit set")
14
15	// ErrFeatureConfigured is returned if an attempt is made to unset a
16	// feature that was configured at startup.
17	ErrFeatureConfigured = errors.New("can't unset configured feature")
18	)
19
20	// Config houses any runtime modifications to the default set descriptors. For
21	// our purposes, this typically means disabling certain features to test legacy
22	// protocol interoperability or functionality.
23	type Config struct {
24	// NoTLVOnion unsets any optional or required TLVOnionPaylod bits from
25	// all feature sets.
26	NoTLVOnion bool
27
28	// NoStaticRemoteKey unsets any optional or required StaticRemoteKey
29	// bits from all feature sets.
30	NoStaticRemoteKey bool
31
32	// NoAnchors unsets any bits signaling support for anchor outputs.
33	NoAnchors bool
34
35	// NoWumbo unsets any bits signalling support for wumbo channels.
36	NoWumbo bool
37
38	// NoTaprootChans unsets any bits signaling support for taproot
39	// channels.
40	NoTaprootChans bool
41
42	// NoScriptEnforcementLease unsets any bits signaling support for script
43	// enforced leases.
44	NoScriptEnforcementLease bool
45
46	// NoKeysend unsets any bits signaling support for accepting keysend
47	// payments.
48	NoKeysend bool
49
50	// NoOptionScidAlias unsets any bits signalling support for
51	// option_scid_alias. This also implicitly disables zero-conf channels.
52	NoOptionScidAlias bool
53
54	// NoZeroConf unsets any bits signalling support for zero-conf
55	// channels. This should be used instead of NoOptionScidAlias to still
56	// keep option-scid-alias support.
57	NoZeroConf bool
58
59	// NoAnySegwit unsets any bits that signal support for using other
60	// segwit witness versions for co-op closes.
61	NoAnySegwit bool
62
63	// NoRouteBlinding unsets route blinding feature bits.
64	NoRouteBlinding bool
65
66	// NoTaprootOverlay unsets the taproot overlay channel feature bits.
67	NoTaprootOverlay bool
68
69	// CustomFeatures is a set of custom features to advertise in each
70	// set.
71	CustomFeatures map[Set][]lnwire.FeatureBit
72	}
73
74	// Manager is responsible for generating feature vectors for different requested
75	// feature sets.
76	type Manager struct {
77	// fsets is a static map of feature set to raw feature vectors. Requests
78	// are fulfilled by cloning these internal feature vectors.
79	fsets map[Set]*lnwire.RawFeatureVector
80
81	// configFeatures is a set of custom features that were "hard set" in
82	// lnd's config that cannot be updated at runtime (as is the case with
83	// our "standard" features that are defined in LND).
84	configFeatures map[Set]*lnwire.FeatureVector
85	}
86
87	// NewManager creates a new feature Manager, applying any custom modifications
88	// to its feature sets before returning.
UNCOV 89	func NewManager(cfg Config) (*Manager, error) {	×
UNCOV 90	return newManager(cfg, defaultSetDesc)	×
UNCOV 91	}	×
92
93	// newManager creates a new feature Manager, applying any custom modifications
94	// to its feature sets before returning. This method accepts the setDesc as its
95	// own parameter so that it can be unit tested.
96	func newManager(cfg Config, desc setDesc) (*Manager, error) {	16✔
97	// First build the default feature vector for all known sets.	16✔
98	fsets := make(map[Set]*lnwire.RawFeatureVector)	16✔
99	for bit, sets := range desc {	53✔
100	for set := range sets {	95✔
101	// Fetch the feature vector for this set, allocating a	58✔
102	// new one if it doesn't exist.	58✔
103	fv, ok := fsets[set]	58✔
104	if !ok {	90✔
105	fv = lnwire.NewRawFeatureVector()	32✔
106	}	32✔
107
108	// Set the configured bit on the feature vector,
109	// ensuring that we don't set two feature bits for the
110	// same pair.
111	err := fv.SafeSet(bit)	58✔
112	if err != nil {	58✔
113	return nil, fmt.Errorf("unable to set "+	×
114	"%v in %v: %v", bit, set, err)	×
115	}	×
116
117	// Write the updated feature vector under its set.
118	fsets[set] = fv	58✔
119	}
120	}
121
122	// Now, remove any features as directed by the config.
123	configFeatures := make(map[Set]*lnwire.FeatureVector)	16✔
124	for set, raw := range fsets {	48✔
125	if cfg.NoTLVOnion {	36✔
126	raw.Unset(lnwire.TLVOnionPayloadOptional)	4✔
127	raw.Unset(lnwire.TLVOnionPayloadRequired)	4✔
128	raw.Unset(lnwire.PaymentAddrOptional)	4✔
129	raw.Unset(lnwire.PaymentAddrRequired)	4✔
130	raw.Unset(lnwire.MPPOptional)	4✔
131	raw.Unset(lnwire.MPPRequired)	4✔
132	raw.Unset(lnwire.RouteBlindingOptional)	4✔
133	raw.Unset(lnwire.RouteBlindingRequired)	4✔
134	raw.Unset(lnwire.Bolt11BlindedPathsOptional)	4✔
135	raw.Unset(lnwire.Bolt11BlindedPathsRequired)	4✔
136	raw.Unset(lnwire.AMPOptional)	4✔
137	raw.Unset(lnwire.AMPRequired)	4✔
138	raw.Unset(lnwire.KeysendOptional)	4✔
139	raw.Unset(lnwire.KeysendRequired)	4✔
140	}	4✔
141	if cfg.NoStaticRemoteKey {	36✔
142	raw.Unset(lnwire.StaticRemoteKeyOptional)	4✔
143	raw.Unset(lnwire.StaticRemoteKeyRequired)	4✔
144	}	4✔
145	if cfg.NoAnchors {	34✔
146	raw.Unset(lnwire.AnchorsZeroFeeHtlcTxOptional)	2✔
147	raw.Unset(lnwire.AnchorsZeroFeeHtlcTxRequired)	2✔
148		2✔
149	// If anchors are disabled, then we also need to	2✔
150	// disable all other features that depend on it as	2✔
151	// well, as otherwise we may create an invalid feature	2✔
152	// bit set.	2✔
153	for bit, depFeatures := range deps {	28✔
154	for depFeature := range depFeatures {	58✔
155	switch {	32✔
156	case depFeature == lnwire.AnchorsZeroFeeHtlcTxRequired:	×
157	fallthrough	×
158	case depFeature == lnwire.AnchorsZeroFeeHtlcTxOptional:	4✔
159	raw.Unset(bit)	4✔
160	}
161	}
162	}
163	}
164	if cfg.NoWumbo {	32✔
UNCOV 165	raw.Unset(lnwire.WumboChannelsOptional)	×
UNCOV 166	raw.Unset(lnwire.WumboChannelsRequired)	×
UNCOV 167	}	×
168	if cfg.NoScriptEnforcementLease {	32✔
UNCOV 169	raw.Unset(lnwire.ScriptEnforcedLeaseOptional)	×
UNCOV 170	raw.Unset(lnwire.ScriptEnforcedLeaseRequired)	×
UNCOV 171	}	×
172	if cfg.NoKeysend {	32✔
173	raw.Unset(lnwire.KeysendOptional)	×
174	raw.Unset(lnwire.KeysendRequired)	×
175	}	×
176	if cfg.NoOptionScidAlias {	32✔
UNCOV 177	raw.Unset(lnwire.ScidAliasOptional)	×
UNCOV 178	raw.Unset(lnwire.ScidAliasRequired)	×
UNCOV 179	}	×
180	if cfg.NoZeroConf {	32✔
UNCOV 181	raw.Unset(lnwire.ZeroConfOptional)	×
UNCOV 182	raw.Unset(lnwire.ZeroConfRequired)	×
UNCOV 183	}	×
184	if cfg.NoAnySegwit {	32✔
UNCOV 185	raw.Unset(lnwire.ShutdownAnySegwitOptional)	×
UNCOV 186	raw.Unset(lnwire.ShutdownAnySegwitRequired)	×
UNCOV 187	}	×
188	if cfg.NoTaprootChans {	32✔
UNCOV 189	raw.Unset(lnwire.SimpleTaprootChannelsOptionalStaging)	×
UNCOV 190	raw.Unset(lnwire.SimpleTaprootChannelsRequiredStaging)	×
UNCOV 191	}	×
192	if cfg.NoRouteBlinding {	32✔
UNCOV 193	raw.Unset(lnwire.RouteBlindingOptional)	×
UNCOV 194	raw.Unset(lnwire.RouteBlindingRequired)	×
UNCOV 195	raw.Unset(lnwire.Bolt11BlindedPathsOptional)	×
UNCOV 196	raw.Unset(lnwire.Bolt11BlindedPathsRequired)	×
UNCOV 197	}	×
198	if cfg.NoTaprootOverlay {	32✔
UNCOV 199	raw.Unset(lnwire.SimpleTaprootOverlayChansOptional)	×
UNCOV 200	raw.Unset(lnwire.SimpleTaprootOverlayChansRequired)	×
UNCOV 201	}	×
202	for _, custom := range cfg.CustomFeatures[set] {	34✔
203	if custom > set.Maximum() {	2✔
204	return nil, fmt.Errorf("feature bit: %v "+	×
205	"exceeds set: %v maximum: %v", custom,	×
206	set, set.Maximum())	×
207	}	×
208
209	if raw.IsSet(custom) {	2✔
210	return nil, fmt.Errorf("feature bit: %v "+	×
211	"already set", custom)	×
212	}	×
213
214	if err := raw.SafeSet(custom); err != nil {	2✔
215	return nil, fmt.Errorf("%w: could not set "+	×
216	"feature: %d", err, custom)	×
217	}	×
218	}
219
220	// Track custom features separately so that we can check that
221	// they aren't unset in subsequent updates. If there is no
222	// entry for the set, the vector will just be empty.
223	configFeatures[set] = lnwire.NewFeatureVector(	32✔
224	lnwire.NewRawFeatureVector(cfg.CustomFeatures[set]...),	32✔
225	lnwire.Features,	32✔
226	)	32✔
227		32✔
228	// Ensure that all of our feature sets properly set any	32✔
229	// dependent features.	32✔
230	fv := lnwire.NewFeatureVector(raw, lnwire.Features)	32✔
231	err := ValidateDeps(fv)	32✔
232	if err != nil {	32✔
233	return nil, fmt.Errorf("invalid feature set %v: %w",	×
234	set, err)	×
235	}	×
236	}
237
238	return &Manager{	16✔
239	fsets: fsets,	16✔
240	configFeatures: configFeatures,	16✔
241	}, nil	16✔
242	}
243
244	// GetRaw returns a raw feature vector for the passed set. If no set is known,
245	// an empty raw feature vector is returned.
246	func (m Manager) GetRaw(set Set) lnwire.RawFeatureVector {	66✔
247	if fv, ok := m.fsets[set]; ok {	110✔
248	return fv.Clone()	44✔
249	}	44✔
250
251	return lnwire.NewRawFeatureVector()	22✔
252	}
253
254	// setRaw sets a new raw feature vector for the given set.
255	func (m Manager) setRaw(set Set, raw lnwire.RawFeatureVector) {	6✔
256	m.fsets[set] = raw	6✔
257	}	6✔
258
259	// Get returns a feature vector for the passed set. If no set is known, an empty
260	// feature vector is returned.
261	func (m Manager) Get(set Set) lnwire.FeatureVector {	32✔
262	raw := m.GetRaw(set)	32✔
263	return lnwire.NewFeatureVector(raw, lnwire.Features)	32✔
264	}	32✔
265
266	// ListSets returns a list of the feature sets that our node supports.
UNCOV 267	func (m *Manager) ListSets() []Set {	×
UNCOV 268	var sets []Set	×
UNCOV 269		×
UNCOV 270	for set := range m.fsets {	×
UNCOV 271	sets = append(sets, set)	×
UNCOV 272	}	×
273
UNCOV 274	return sets	×
275	}
276
277	// UpdateFeatureSets accepts a map of new feature vectors for each of the
278	// manager's known sets, validates that the update can be applied and modifies
279	// the feature manager's internal state. If a set is not included in the update
280	// map, it is left unchanged. The feature vectors provided are expected to
281	// include the current set of features, updated with desired bits added/removed.
282	func (m *Manager) UpdateFeatureSets(
283	updates map[Set]*lnwire.RawFeatureVector) error {	7✔
284		7✔
285	for set, newFeatures := range updates {	17✔
286	if !set.valid() {	11✔
287	return fmt.Errorf("%w: set: %d", ErrUnknownSet, set)	1✔
288	}	1✔
289
290	if err := newFeatures.ValidatePairs(); err != nil {	11✔
291	return err	2✔
292	}	2✔
293
294	if err := m.Get(set).ValidateUpdate(	7✔
295	newFeatures, set.Maximum(),	7✔
296	); err != nil {	7✔
UNCOV 297	return err	×
UNCOV 298	}	×
299
300	// If any features were configured for this set, ensure that
301	// they are still set in the new feature vector.
302	if cfgFeat, haveCfgFeat := m.configFeatures[set]; haveCfgFeat {	12✔
303	for feature := range cfgFeat.Features() {	6✔
304	if !newFeatures.IsSet(feature) {	2✔
305	return fmt.Errorf("%w: can't unset: "+	1✔
306	"%d", ErrFeatureConfigured,	1✔
307	feature)	1✔
308	}	1✔
309	}
310	}
311
312	fv := lnwire.NewFeatureVector(newFeatures, lnwire.Features)	6✔
313	if err := ValidateDeps(fv); err != nil {	6✔
314	return err	×
315	}	×
316	}
317
318	// Only update the current feature sets once every proposed set has
319	// passed validation so that we don't partially update any sets then
320	// fail out on a later set's validation.
321	for set, features := range updates {	9✔
322	m.setRaw(set, features.Clone())	6✔
323	}	6✔
324
325	return nil	3✔
326	}

lightningnetwork / lnd / 11393106485

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous