c9d0eaec-c698-418e-a1b2-1ebc338545f6

Committed 14 Nov 2024 04:42PM UTC coverage: 96.691% (+0.01%) from 96.678%

Build # c9d0eaec-c698-418e-a1b2-1ebc338545f6

Build Type

push

circleci

Committed by

christinach

Commit Message

Upgrade to Blacklight 8.6.1 (#4546)

* Blacklight 8 - take (something)

* Upgrade blacklight to 8.6.1

* Remove a concern that is unused in Blacklight 8

This way, coveralls does not complain about a dramatic drop in code coverage

---------

Co-authored-by: Max Kadel <mkadel@princeton.edu>
Co-authored-by: Max Kadel <mk8066@princeton.edu>

Run Details

5990 of 6195 relevant lines covered (96.69%)

1538.74 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

78.57

/app/services/search_service_compatibility_wrapper.rb

# frozen_string_literal: true
# We can remove this service (and just call search_service directly)
# after we migrate to Blacklight 8
# :reek:UncommunicativeVariableName
class SearchServiceCompatibilityWrapper
  def initialize(search_service)
    @search_service = search_service
  end

  # :reek:DuplicateMethodCall
  # :reek:FeatureEnvy
  def fetch(...)
    if Orangelight.using_blacklight7?
      _response, document = search_service.fetch(...)
      document
    else
      search_service.fetch(...)
    end
  end

  # :reek:DuplicateMethodCall
  # :reek:FeatureEnvy
  def search_results(...)
    if Orangelight.using_blacklight7?
      search_service.search_results(...).first
    else
      search_service.search_results(...)
    end
  end

  private

    attr_reader :search_service
end

1	# frozen_string_literal: true
2	# We can remove this service (and just call search_service directly)
3	# after we migrate to Blacklight 8
4	# :reek:UncommunicativeVariableName
5	class SearchServiceCompatibilityWrapper	3✔
6	def initialize(search_service)	3✔
7	@search_service = search_service	82✔
8	end
9
10	# :reek:DuplicateMethodCall
11	# :reek:FeatureEnvy
12	def fetch(...)	3✔
13	if Orangelight.using_blacklight7?	18✔
14	_response, document = search_service.fetch(...)	×
15	document	×
16	else
17	search_service.fetch(...)	18✔
18	end
19	end
20
21	# :reek:DuplicateMethodCall
22	# :reek:FeatureEnvy
23	def search_results(...)	3✔
24	if Orangelight.using_blacklight7?	64✔
25	search_service.search_results(...).first	×
26	else
27	search_service.search_results(...)	64✔
28	end
29	end
30
31	private	3✔
32
33	attr_reader :search_service	3✔
34	end

pulibrary / orangelight / c9d0eaec-c698-418e-a1b2-1ebc338545f6

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous