c1bac0ab-1597-49d5-8e7c-12128febf8cc

Committed 15 Nov 2024 10:31PM UTC coverage: 96.691% (+0.01%) from 96.678%

Build # c1bac0ab-1597-49d5-8e7c-12128febf8cc

Build Type

Pull #4573

circleci

Committed by

christinach

Commit Message

Upgrade to Blacklight 8.6.1 (#4546)

* Blacklight 8 - take (something)

* Upgrade blacklight to 8.6.1

* Remove a concern that is unused in Blacklight 8

This way, coveralls does not complain about a dramatic drop in code coverage

---------

Co-authored-by: Max Kadel <mkadel@princeton.edu>
Co-authored-by: Max Kadel <mk8066@princeton.edu>

Pull Request Pull Request #4573: Blacklight8 upgrade

Run Details

5990 of 6195 relevant lines covered (96.69%)

1538.73 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

80.0

/app/components/bookmark_button_component.rb

# frozen_string_literal: true

class BookmarkButtonComponent < Blacklight::Document::BookmarkComponent
  def initialize(**kwargs)
    if Orangelight.using_blacklight7?
      super(**kwargs.except(:action))
    else
      super
    end
  end
end

1	# frozen_string_literal: true
2
3	class BookmarkButtonComponent < Blacklight::Document::BookmarkComponent	3✔
4	def initialize(**kwargs)	3✔
5	if Orangelight.using_blacklight7?	104✔
6	super(**kwargs.except(:action))	×
7	else
8	super	104✔
9	end
10	end
11	end

pulibrary / orangelight / c1bac0ab-1597-49d5-8e7c-12128febf8cc

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous