12065491531

Committed 28 Nov 2024 08:42AM UTC coverage: 58.891% (-0.05%) from 58.939%

Build # 12065491531

Build Type

Pull #9318

github

Committed by

guggero

Commit Message

make: remove exotic build targets from release list

With this commit we remove build targets from our list of release build
OS/architecture pairs to reduce the overhead of building for them with
every pull request and every release.

According to https://tooomm.github.io/github-release-stats/?username=lightningnetwork&repository=lnd
those targets are rarely used, compared to the most popular ones:

| Release File                          | Absolute DL | Relative DL |
|---------------------------------------|-------------|-------------|
| lnd-darwin-amd64-v0.18.3-beta.tar.gz  | 1,930       | 72          |
| lnd-darwin-arm64-v0.18.3-beta.tar.gz  | 2,020       | 162         |
| lnd-freebsd-386-v0.18.3-beta.tar.gz   | 1,864       | 6           |
| lnd-freebsd-amd64-v0.18.3-beta.tar.gz | 1,874       | 16          |
| lnd-freebsd-arm-v0.18.3-beta.tar.gz   | 1,865       | 7           |
| lnd-linux-386-v0.18.3-beta.tar.gz     | 1,873       | 15          |
| lnd-linux-amd64-v0.18.3-beta.tar.gz   | 3,355       | 1,497       |
| lnd-linux-arm64-v0.18.3-beta.tar.gz   | 3,053       | 1,195       |
| lnd-linux-armv6-v0.18.3-beta.tar.gz   | 1,868       | 10          |
| lnd-linux-armv7-v0.18.3-beta.tar.gz   | 1,893       | 35          |
| lnd-linux-mips-v0.18.3-beta.tar.gz    | 1,859       | 1           |
| lnd-linux-mips64-v0.18.3-beta.tar.gz  | 1,860       | 2           |
| lnd-linux-mipsle-v0.18.3-beta.tar.gz  | 1,859       | 1           |
| lnd-linux-ppc64-v0.18.3-beta.tar.gz   | 1,858       | 0           |
| lnd-linux-ppc64le-v0.18.3-beta.tar.gz | 1,859       | 1           |
| lnd-linux-s390x-v0.18.3-beta.tar.gz   | 1,859       | 1           |
| lnd-netbsd-amd64-v0.18.3-beta.tar.gz  | 1,859       | 1           |
| lnd-openbsd-amd64-v0.18.3-beta.tar.gz | 1,861       | 3           |
| lnd-source-v0.18.3-beta.tar.gz        | 1,863       | 5           |
| lnd-windows-386-v0.18.3-beta.zip      | 1,895       | 37          |
| lnd-windows-amd64-v0.18.3-beta.zip    | ... (continued)

Pull Request Pull Request #9318: make: remove exotic build targets from release list

Run Details

133304 of 226358 relevant lines covered (58.89%)

19531.56 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

62.86

/chainreg/taproot_check.go

package chainreg

import (
        "encoding/json"

        "github.com/btcsuite/btcd/rpcclient"
)

// backendSupportsTaproot returns true if the backend understands the taproot
// soft fork.
func backendSupportsTaproot(rpc *rpcclient.Client) bool {
        // First, we'll try to access the normal getblockchaininfo call.
        chainInfo, err := rpc.GetBlockChainInfo()
        if err == nil {
                // If this call worked, then we'll check that the taproot
                // deployment is defined.
                switch {
                // Bitcoind versions before 0.19 and also btcd use the
                // SoftForks fields.
                case chainInfo.SoftForks != nil:
                        _, ok := chainInfo.SoftForks.Bip9SoftForks["taproot"]
                        if ok {
                                return ok
                        }

                // Bitcoind versions after 0.19 will use the UnifiedSoftForks
                // field that factors in the set of "buried" soft forks.
                case chainInfo.UnifiedSoftForks != nil:
                        _, ok := chainInfo.UnifiedSoftForks.SoftForks["taproot"]
                        if ok {
                                return ok
                        }
                }
        }

        // The user might be running a newer version of bitcoind that doesn't
        // implement the getblockchaininfo call any longer, so we'll fall back
        // here.
        //
        // Alternatively, the fork wasn't specified, but the user might be
        // running a newer version of bitcoind that still has the
        // getblockchaininfo call, but doesn't populate the data, so we'll hit
        // the new getdeploymentinfo call.
        resp, err := rpc.RawRequest("getdeploymentinfo", nil)
        if err != nil {
                log.Warnf("unable to make getdeploymentinfo request: %v", err)
                return false
        }

        info := struct {
                Deployments map[string]struct {
                        Type   string `json:"type"`
                        Active bool   `json:"active"`
                        Height int32  `json:"height"`
                } `json:"deployments"`
        }{}
        if err := json.Unmarshal(resp, &info); err != nil {
                log.Warnf("unable to decode getdeploymentinfo resp: %v", err)
                return false
        }

        _, ok := info.Deployments["taproot"]
        return ok
}

1	package chainreg
2
3	import (
4	"encoding/json"
5
6	"github.com/btcsuite/btcd/rpcclient"
7	)
8
9	// backendSupportsTaproot returns true if the backend understands the taproot
10	// soft fork.
11	func backendSupportsTaproot(rpc *rpcclient.Client) bool {	2✔
12	// First, we'll try to access the normal getblockchaininfo call.	2✔
13	chainInfo, err := rpc.GetBlockChainInfo()	2✔
14	if err == nil {	4✔
15	// If this call worked, then we'll check that the taproot	2✔
16	// deployment is defined.	2✔
17	switch {	2✔
18	// Bitcoind versions before 0.19 and also btcd use the
19	// SoftForks fields.
20	case chainInfo.SoftForks != nil:	×
21	_, ok := chainInfo.SoftForks.Bip9SoftForks["taproot"]	×
22	if ok {	×
23	return ok	×
24	}	×
25
26	// Bitcoind versions after 0.19 will use the UnifiedSoftForks
27	// field that factors in the set of "buried" soft forks.
28	case chainInfo.UnifiedSoftForks != nil:	2✔
29	_, ok := chainInfo.UnifiedSoftForks.SoftForks["taproot"]	2✔
30	if ok {	2✔
31	return ok	×
32	}	×
33	}
34	}
35
36	// The user might be running a newer version of bitcoind that doesn't
37	// implement the getblockchaininfo call any longer, so we'll fall back
38	// here.
39	//
40	// Alternatively, the fork wasn't specified, but the user might be
41	// running a newer version of bitcoind that still has the
42	// getblockchaininfo call, but doesn't populate the data, so we'll hit
43	// the new getdeploymentinfo call.
44	resp, err := rpc.RawRequest("getdeploymentinfo", nil)	2✔
45	if err != nil {	2✔
46	log.Warnf("unable to make getdeploymentinfo request: %v", err)	×
47	return false	×
48	}	×
49
50	info := struct {	2✔
51	Deployments map[string]struct {	2✔
52	Type string `json:"type"`	2✔
53	Active bool `json:"active"`	2✔
54	Height int32 `json:"height"`	2✔
55	} `json:"deployments"`	2✔
56	}{}	2✔
57	if err := json.Unmarshal(resp, &info); err != nil {	2✔
58	log.Warnf("unable to decode getdeploymentinfo resp: %v", err)	×
59	return false	×
60	}	×
61
62	_, ok := info.Deployments["taproot"]	2✔
63	return ok	2✔
64	}

lightningnetwork / lnd / 12065491531

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous