12115442155

Committed 02 Dec 2024 08:28AM UTC coverage: 48.662% (-10.3%) from 58.948%

Build # 12115442155

Build Type

Pull #9175

github

Committed by

ellemouton

Commit Message

netann: update ChanAnn2 validation to work for P2WSH channels

This commit expands the ChannelAnnouncement2 validation for the case
where it is announcing a P2WSH channel.

Pull Request Pull Request #9175: lnwire+netann: update structure of g175 messages to be pure TLV

Run Details

6 of 314 new or added lines in 9 files covered. (1.91%)

27532 existing lines in 434 files now uncovered.

97890 of 201164 relevant lines covered (48.66%)

0.52 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

26.67

/feature/required.go

package feature

import (
        "fmt"

        "github.com/lightningnetwork/lnd/lnwire"
)

// ErrUnknownRequired signals that a feature vector requires certain features
// that our node is unaware of or does not implement.
type ErrUnknownRequired struct {
        unknown []lnwire.FeatureBit
}

// NewErrUnknownRequired initializes an ErrUnknownRequired with the unknown
// feature bits.
func NewErrUnknownRequired(unknown []lnwire.FeatureBit) ErrUnknownRequired {
        return ErrUnknownRequired{
                unknown: unknown,
        }
}

// Error returns a human-readable description of the error.
func (e ErrUnknownRequired) Error() string {
        return fmt.Sprintf("feature vector contains unknown required "+
                "features: %v", e.unknown)
}

// ValidateRequired returns an error if the feature vector contains a non-zero
// number of unknown, required feature bits.
func ValidateRequired(fv *lnwire.FeatureVector) error {
        unknown := fv.UnknownRequiredFeatures()
        if len(unknown) > 0 {
                return NewErrUnknownRequired(unknown)
        }
        return nil
}

1	package feature
2
3	import (
4	"fmt"
5
6	"github.com/lightningnetwork/lnd/lnwire"
7	)
8
9	// ErrUnknownRequired signals that a feature vector requires certain features
10	// that our node is unaware of or does not implement.
11	type ErrUnknownRequired struct {
12	unknown []lnwire.FeatureBit
13	}
14
15	// NewErrUnknownRequired initializes an ErrUnknownRequired with the unknown
16	// feature bits.
UNCOV 17	func NewErrUnknownRequired(unknown []lnwire.FeatureBit) ErrUnknownRequired {	×
UNCOV 18	return ErrUnknownRequired{	×
UNCOV 19	unknown: unknown,	×
UNCOV 20	}	×
UNCOV 21	}	×
22
23	// Error returns a human-readable description of the error.
UNCOV 24	func (e ErrUnknownRequired) Error() string {	×
UNCOV 25	return fmt.Sprintf("feature vector contains unknown required "+	×
UNCOV 26	"features: %v", e.unknown)	×
UNCOV 27	}	×
28
29	// ValidateRequired returns an error if the feature vector contains a non-zero
30	// number of unknown, required feature bits.
31	func ValidateRequired(fv *lnwire.FeatureVector) error {	1✔
32	unknown := fv.UnknownRequiredFeatures()	1✔
33	if len(unknown) > 0 {	1✔
UNCOV 34	return NewErrUnknownRequired(unknown)	×
UNCOV 35	}	×
36	return nil	1✔
37	}

lightningnetwork / lnd / 12115442155

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous