12115442155

Committed 02 Dec 2024 08:28AM UTC coverage: 48.662% (-10.3%) from 58.948%

Build # 12115442155

Build Type

Pull #9175

github

Committed by

ellemouton

Commit Message

netann: update ChanAnn2 validation to work for P2WSH channels

This commit expands the ChannelAnnouncement2 validation for the case
where it is announcing a P2WSH channel.

Pull Request Pull Request #9175: lnwire+netann: update structure of g175 messages to be pure TLV

Run Details

6 of 314 new or added lines in 9 files covered. (1.91%)

27532 existing lines in 434 files now uncovered.

97890 of 201164 relevant lines covered (48.66%)

0.52 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

79.45

/routing/unified_edges.go

package routing

import (
        "math"

        "github.com/btcsuite/btcd/btcutil"
        graphdb "github.com/lightningnetwork/lnd/graph/db"
        "github.com/lightningnetwork/lnd/graph/db/models"
        "github.com/lightningnetwork/lnd/lntypes"
        "github.com/lightningnetwork/lnd/lnwire"
        "github.com/lightningnetwork/lnd/routing/route"
)

// nodeEdgeUnifier holds all edge unifiers for connections towards a node.
type nodeEdgeUnifier struct {
        // edgeUnifiers contains an edge unifier for every from node.
        edgeUnifiers map[route.Vertex]*edgeUnifier

        // sourceNode is the sender of a payment. The rules to pick the final
        // policy are different for local channels.
        sourceNode route.Vertex

        // toNode is the node for which the edge unifiers are instantiated.
        toNode route.Vertex

        // useInboundFees indicates whether to take inbound fees into account.
        useInboundFees bool

        // outChanRestr is an optional outgoing channel restriction for the
        // local channel to use.
        outChanRestr map[uint64]struct{}
}

// newNodeEdgeUnifier instantiates a new nodeEdgeUnifier object. Channel
// policies can be added to this object.
func newNodeEdgeUnifier(sourceNode, toNode route.Vertex, useInboundFees bool,
        outChanRestr map[uint64]struct{}) *nodeEdgeUnifier {

        return &nodeEdgeUnifier{
                edgeUnifiers:   make(map[route.Vertex]*edgeUnifier),
                toNode:         toNode,
                useInboundFees: useInboundFees,
                sourceNode:     sourceNode,
                outChanRestr:   outChanRestr,
        }
}

// addPolicy adds a single channel policy. Capacity may be zero if unknown
// (light clients). We expect a non-nil payload size function and will request a
// graceful shutdown if it is not provided as this indicates that edges are
// incorrectly specified.
func (u *nodeEdgeUnifier) addPolicy(fromNode route.Vertex,
        edge *models.CachedEdgePolicy, inboundFee models.InboundFee,
        capacity btcutil.Amount, hopPayloadSizeFn PayloadSizeFunc,
        blindedPayment *BlindedPayment) {

        localChan := fromNode == u.sourceNode

        // Skip channels if there is an outgoing channel restriction.
        if localChan && u.outChanRestr != nil {
                if _, ok := u.outChanRestr[edge.ChannelID]; !ok {
                        return
                }
        }

        // Update the edgeUnifiers map.
        unifier, ok := u.edgeUnifiers[fromNode]
        if !ok {
                unifier = &edgeUnifier{
                        localChan: localChan,
                }
                u.edgeUnifiers[fromNode] = unifier
        }

        // In case no payload size function was provided a graceful shutdown
        // is requested, because this function is not used as intended.
        if hopPayloadSizeFn == nil {
                log.Criticalf("No payloadsize function was provided for the "+
                        "edge (chanid=%v) when adding it to the edge unifier "+
                        "of node: %v", edge.ChannelID, fromNode)

                return
        }

        // Zero inbound fee for exit hops.
        if !u.useInboundFees {
                inboundFee = models.InboundFee{}
        }

        unifier.edges = append(unifier.edges, newUnifiedEdge(
                edge, capacity, inboundFee, hopPayloadSizeFn, blindedPayment,
        ))
}

// addGraphPolicies adds all policies that are known for the toNode in the
// graph.
func (u *nodeEdgeUnifier) addGraphPolicies(g Graph) error {
        cb := func(channel *graphdb.DirectedChannel) error {
                // If there is no edge policy for this candidate node, skip.
                // Note that we are searching backwards so this node would have
                // come prior to the pivot node in the route.
                if channel.InPolicy == nil {
                        return nil
                }

                // Add this policy to the corresponding edgeUnifier. We default
                // to the clear hop payload size function because
                // `addGraphPolicies` is only used for cleartext intermediate
                // hops in a route.
                inboundFee := models.NewInboundFeeFromWire(
                        channel.InboundFee,
                )

                u.addPolicy(
                        channel.OtherNode, channel.InPolicy, inboundFee,
                        channel.Capacity, defaultHopPayloadSize, nil,
                )

                return nil
        }

        // Iterate over all channels of the to node.
        return g.ForEachNodeChannel(u.toNode, cb)
}

// unifiedEdge is the individual channel data that is kept inside an edgeUnifier
// object.
type unifiedEdge struct {
        policy      *models.CachedEdgePolicy
        capacity    btcutil.Amount
        inboundFees models.InboundFee

        // hopPayloadSize supplies an edge with the ability to calculate the
        // exact payload size if this edge would be included in a route. This
        // is needed because hops of a blinded path differ in their payload
        // structure compared to cleartext hops.
        hopPayloadSizeFn PayloadSizeFunc

        // blindedPayment if set, is the BlindedPayment that this edge was
        // derived from originally.
        blindedPayment *BlindedPayment
}

// newUnifiedEdge constructs a new unifiedEdge.
func newUnifiedEdge(policy *models.CachedEdgePolicy, capacity btcutil.Amount,
        inboundFees models.InboundFee, hopPayloadSizeFn PayloadSizeFunc,
        blindedPayment *BlindedPayment) *unifiedEdge {

        return &unifiedEdge{
                policy:           policy,
                capacity:         capacity,
                inboundFees:      inboundFees,
                hopPayloadSizeFn: hopPayloadSizeFn,
                blindedPayment:   blindedPayment,
        }
}

// amtInRange checks whether an amount falls within the valid range for a
// channel.
func (u *unifiedEdge) amtInRange(amt lnwire.MilliSatoshi) bool {
        // If the capacity is available (non-light clients), skip channels that
        // are too small.
        if u.capacity > 0 &&
                amt > lnwire.NewMSatFromSatoshis(u.capacity) {

                log.Tracef("Not enough capacity: amt=%v, capacity=%v",
                        amt, u.capacity)
                return false
        }

        // Skip channels for which this htlc is too large.
        if u.policy.MessageFlags.HasMaxHtlc() &&
                amt > u.policy.MaxHTLC {

                log.Tracef("Exceeds policy's MaxHTLC: amt=%v, MaxHTLC=%v",
                        amt, u.policy.MaxHTLC)
                return false
        }

        // Skip channels for which this htlc is too small.
        if amt < u.policy.MinHTLC {
                log.Tracef("below policy's MinHTLC: amt=%v, MinHTLC=%v",
                        amt, u.policy.MinHTLC)
                return false
        }

        return true
}

// edgeUnifier is an object that covers all channels between a pair of nodes.
type edgeUnifier struct {
        edges     []*unifiedEdge
        localChan bool
}

// getEdge returns the optimal unified edge to use for this connection given a
// specific amount to send. It differentiates between local and network
// channels.
func (u *edgeUnifier) getEdge(netAmtReceived lnwire.MilliSatoshi,
        bandwidthHints bandwidthHints,
        nextOutFee lnwire.MilliSatoshi) *unifiedEdge {

        if u.localChan {
                return u.getEdgeLocal(
                        netAmtReceived, bandwidthHints, nextOutFee,
                )
        }

        return u.getEdgeNetwork(netAmtReceived, nextOutFee)
}

// calcCappedInboundFee calculates the inbound fee for a channel, taking into
// account the total node fee for the "to" node.
func calcCappedInboundFee(edge *unifiedEdge, amt lnwire.MilliSatoshi,
        nextOutFee lnwire.MilliSatoshi) int64 {

        // Calculate the inbound fee charged for the amount that passes over the
        // channel.
        inboundFee := edge.inboundFees.CalcFee(amt)

        // Take into account that the total node fee cannot be negative.
        if inboundFee < -int64(nextOutFee) {
                inboundFee = -int64(nextOutFee)
        }

        return inboundFee
}

// getEdgeLocal returns the optimal unified edge to use for this local
// connection given a specific amount to send.
func (u *edgeUnifier) getEdgeLocal(netAmtReceived lnwire.MilliSatoshi,
        bandwidthHints bandwidthHints,
        nextOutFee lnwire.MilliSatoshi) *unifiedEdge {

        var (
                bestEdge     *unifiedEdge
                maxBandwidth lnwire.MilliSatoshi
        )

        for _, edge := range u.edges {
                // Calculate the inbound fee charged at the receiving node.
                inboundFee := calcCappedInboundFee(
                        edge, netAmtReceived, nextOutFee,
                )

                // Add inbound fee to get to the amount that is sent over the
                // local channel.
                amt := netAmtReceived + lnwire.MilliSatoshi(inboundFee)

                // Check valid amount range for the channel. We skip this test
                // for payments with custom HTLC data, as the amount sent on
                // the BTC layer may differ from the amount that is actually
                // forwarded in custom channels.
                if bandwidthHints.firstHopCustomBlob().IsNone() &&
                        !edge.amtInRange(amt) {

                        log.Debugf("Amount %v not in range for edge %v",
                                netAmtReceived, edge.policy.ChannelID)

                        continue
                }

                // For local channels, there is no fee to pay or an extra time
                // lock. We only consider the currently available bandwidth for
                // channel selection. The disabled flag is ignored for local
                // channels.

                // Retrieve bandwidth for this local channel. If not
                // available, assume this channel has enough bandwidth.
                //
                // TODO(joostjager): Possibly change to skipping this
                // channel. The bandwidth hint is expected to be
                // available.
                bandwidth, ok := bandwidthHints.availableChanBandwidth(
                        edge.policy.ChannelID, amt,
                )
                if !ok {
                        log.Debugf("Cannot get bandwidth for edge %v, use max "+
                                "instead", edge.policy.ChannelID)
                        bandwidth = lnwire.MaxMilliSatoshi
                }

                // TODO(yy): if the above `!ok` is chosen, we'd have
                // `bandwidth` to be the max value, which will end up having
                // the `maxBandwidth` to be have the largest value and this
                // edge will be the chosen one. This is wrong in two ways,
                // 1. we need to understand why `availableChanBandwidth` cannot
                // find bandwidth for this edge as something is wrong with this
                // channel, and,
                // 2. this edge is likely NOT the local channel with the
                // highest available bandwidth.
                //
                // Skip channels that can't carry the payment.
                if amt > bandwidth {
                        log.Debugf("Skipped edge %v: not enough bandwidth, "+
                                "bandwidth=%v, amt=%v", edge.policy.ChannelID,
                                bandwidth, amt)

                        continue
                }

                // We pick the local channel with the highest available
                // bandwidth, to maximize the success probability. It can be
                // that the channel state changes between querying the bandwidth
                // hints and sending out the htlc.
                if bandwidth < maxBandwidth {
                        log.Debugf("Skipped edge %v: not max bandwidth, "+
                                "bandwidth=%v, maxBandwidth=%v",
                                edge.policy.ChannelID, bandwidth, maxBandwidth)

                        continue
                }
                maxBandwidth = bandwidth

                // Update best edge.
                bestEdge = newUnifiedEdge(
                        edge.policy, edge.capacity, edge.inboundFees,
                        edge.hopPayloadSizeFn, edge.blindedPayment,
                )
        }

        return bestEdge
}

// getEdgeNetwork returns the optimal unified edge to use for this connection
// given a specific amount to send. The goal is to return a unified edge with a
// policy that maximizes the probability of a successful forward in a non-strict
// forwarding context.
func (u *edgeUnifier) getEdgeNetwork(netAmtReceived lnwire.MilliSatoshi,
        nextOutFee lnwire.MilliSatoshi) *unifiedEdge {

        var (
                bestPolicy       *unifiedEdge
                maxFee           int64 = math.MinInt64
                maxTimelock      uint16
                maxCapMsat       lnwire.MilliSatoshi
                hopPayloadSizeFn PayloadSizeFunc
        )

        for _, edge := range u.edges {
                // Calculate the inbound fee charged at the receiving node.
                inboundFee := calcCappedInboundFee(
                        edge, netAmtReceived, nextOutFee,
                )

                // Add inbound fee to get to the amount that is sent over the
                // channel.
                amt := netAmtReceived + lnwire.MilliSatoshi(inboundFee)

                // Check valid amount range for the channel.
                if !edge.amtInRange(amt) {
                        log.Debugf("Amount %v not in range for edge %v",
                                amt, edge.policy.ChannelID)
                        continue
                }

                // For network channels, skip the disabled ones.
                edgeFlags := edge.policy.ChannelFlags
                isDisabled := edgeFlags&lnwire.ChanUpdateDisabled != 0
                if isDisabled {
                        log.Debugf("Skipped edge %v due to it being disabled",
                                edge.policy.ChannelID)
                        continue
                }

                // Track the maximal capacity for usable channels. If we don't
                // know the capacity, we fall back to MaxHTLC.
                capMsat := lnwire.NewMSatFromSatoshis(edge.capacity)
                if capMsat == 0 && edge.policy.MessageFlags.HasMaxHtlc() {
                        log.Tracef("No capacity available for channel %v, "+
                                "using MaxHtlcMsat (%v) as a fallback.",
                                edge.policy.ChannelID, edge.policy.MaxHTLC)

                        capMsat = edge.policy.MaxHTLC
                }
                maxCapMsat = lntypes.Max(capMsat, maxCapMsat)

                // Track the maximum time lock of all channels that are
                // candidate for non-strict forwarding at the routing node.
                maxTimelock = lntypes.Max(
                        maxTimelock, edge.policy.TimeLockDelta,
                )

                outboundFee := int64(edge.policy.ComputeFee(amt))
                fee := outboundFee + inboundFee

                // Use the policy that results in the highest fee for this
                // specific amount.
                if fee < maxFee {
                        log.Debugf("Skipped edge %v due to it produces less "+
                                "fee: fee=%v, maxFee=%v",
                                edge.policy.ChannelID, fee, maxFee)

                        continue
                }
                maxFee = fee

                bestPolicy = newUnifiedEdge(
                        edge.policy, 0, edge.inboundFees, nil,
                        edge.blindedPayment,
                )

                // The payload size function for edges to a connected peer is
                // always the same hence there is not need to find the maximum.
                // This also counts for blinded edges where we only have one
                // edge to a blinded peer.
                hopPayloadSizeFn = edge.hopPayloadSizeFn
        }

        // Return early if no channel matches.
        if bestPolicy == nil {
                return nil
        }

        // We have already picked the highest fee that could be required for
        // non-strict forwarding. To also cover the case where a lower fee
        // channel requires a longer time lock, we modify the policy by setting
        // the maximum encountered time lock. Note that this results in a
        // synthetic policy that is not actually present on the routing node.
        //
        // The reason we do this, is that we try to maximize the chance that we
        // get forwarded. Because we penalize pair-wise, there won't be a second
        // chance for this node pair. But this is all only needed for nodes that
        // have distinct policies for channels to the same peer.
        policyCopy := *bestPolicy.policy
        policyCopy.TimeLockDelta = maxTimelock
        modifiedEdge := newUnifiedEdge(
                &policyCopy, maxCapMsat.ToSatoshis(), bestPolicy.inboundFees,
                hopPayloadSizeFn, bestPolicy.blindedPayment,
        )

        return modifiedEdge
}

// minAmt returns the minimum amount that can be forwarded on this connection.
func (u *edgeUnifier) minAmt() lnwire.MilliSatoshi {
        min := lnwire.MaxMilliSatoshi
        for _, edge := range u.edges {
                min = lntypes.Min(min, edge.policy.MinHTLC)
        }

        return min
}

1	package routing
2
3	import (
4	"math"
5
6	"github.com/btcsuite/btcd/btcutil"
7	graphdb "github.com/lightningnetwork/lnd/graph/db"
8	"github.com/lightningnetwork/lnd/graph/db/models"
9	"github.com/lightningnetwork/lnd/lntypes"
10	"github.com/lightningnetwork/lnd/lnwire"
11	"github.com/lightningnetwork/lnd/routing/route"
12	)
13
14	// nodeEdgeUnifier holds all edge unifiers for connections towards a node.
15	type nodeEdgeUnifier struct {
16	// edgeUnifiers contains an edge unifier for every from node.
17	edgeUnifiers map[route.Vertex]*edgeUnifier
18
19	// sourceNode is the sender of a payment. The rules to pick the final
20	// policy are different for local channels.
21	sourceNode route.Vertex
22
23	// toNode is the node for which the edge unifiers are instantiated.
24	toNode route.Vertex
25
26	// useInboundFees indicates whether to take inbound fees into account.
27	useInboundFees bool
28
29	// outChanRestr is an optional outgoing channel restriction for the
30	// local channel to use.
31	outChanRestr map[uint64]struct{}
32	}
33
34	// newNodeEdgeUnifier instantiates a new nodeEdgeUnifier object. Channel
35	// policies can be added to this object.
36	func newNodeEdgeUnifier(sourceNode, toNode route.Vertex, useInboundFees bool,
37	outChanRestr map[uint64]struct{}) *nodeEdgeUnifier {	1✔
38		1✔
39	return &nodeEdgeUnifier{	1✔
40	edgeUnifiers: make(map[route.Vertex]*edgeUnifier),	1✔
41	toNode: toNode,	1✔
42	useInboundFees: useInboundFees,	1✔
43	sourceNode: sourceNode,	1✔
44	outChanRestr: outChanRestr,	1✔
45	}	1✔
46	}	1✔
47
48	// addPolicy adds a single channel policy. Capacity may be zero if unknown
49	// (light clients). We expect a non-nil payload size function and will request a
50	// graceful shutdown if it is not provided as this indicates that edges are
51	// incorrectly specified.
52	func (u *nodeEdgeUnifier) addPolicy(fromNode route.Vertex,
53	edge *models.CachedEdgePolicy, inboundFee models.InboundFee,
54	capacity btcutil.Amount, hopPayloadSizeFn PayloadSizeFunc,
55	blindedPayment *BlindedPayment) {	1✔
56		1✔
57	localChan := fromNode == u.sourceNode	1✔
58		1✔
59	// Skip channels if there is an outgoing channel restriction.	1✔
60	if localChan && u.outChanRestr != nil {	1✔
UNCOV 61	if _, ok := u.outChanRestr[edge.ChannelID]; !ok {	×
UNCOV 62	return	×
UNCOV 63	}	×
64	}
65
66	// Update the edgeUnifiers map.
67	unifier, ok := u.edgeUnifiers[fromNode]	1✔
68	if !ok {	2✔
69	unifier = &edgeUnifier{	1✔
70	localChan: localChan,	1✔
71	}	1✔
72	u.edgeUnifiers[fromNode] = unifier	1✔
73	}	1✔
74
75	// In case no payload size function was provided a graceful shutdown
76	// is requested, because this function is not used as intended.
77	if hopPayloadSizeFn == nil {	1✔
78	log.Criticalf("No payloadsize function was provided for the "+	×
79	"edge (chanid=%v) when adding it to the edge unifier "+	×
80	"of node: %v", edge.ChannelID, fromNode)	×
81		×
82	return	×
83	}	×
84
85	// Zero inbound fee for exit hops.
86	if !u.useInboundFees {	2✔
87	inboundFee = models.InboundFee{}	1✔
88	}	1✔
89
90	unifier.edges = append(unifier.edges, newUnifiedEdge(	1✔
91	edge, capacity, inboundFee, hopPayloadSizeFn, blindedPayment,	1✔
92	))	1✔
93	}
94
95	// addGraphPolicies adds all policies that are known for the toNode in the
96	// graph.
97	func (u *nodeEdgeUnifier) addGraphPolicies(g Graph) error {	1✔
98	cb := func(channel *graphdb.DirectedChannel) error {	2✔
99	// If there is no edge policy for this candidate node, skip.	1✔
100	// Note that we are searching backwards so this node would have	1✔
101	// come prior to the pivot node in the route.	1✔
102	if channel.InPolicy == nil {	1✔
103	return nil	×
104	}	×
105
106	// Add this policy to the corresponding edgeUnifier. We default
107	// to the clear hop payload size function because
108	// `addGraphPolicies` is only used for cleartext intermediate
109	// hops in a route.
110	inboundFee := models.NewInboundFeeFromWire(	1✔
111	channel.InboundFee,	1✔
112	)	1✔
113		1✔
114	u.addPolicy(	1✔
115	channel.OtherNode, channel.InPolicy, inboundFee,	1✔
116	channel.Capacity, defaultHopPayloadSize, nil,	1✔
117	)	1✔
118		1✔
119	return nil	1✔
120	}
121
122	// Iterate over all channels of the to node.
123	return g.ForEachNodeChannel(u.toNode, cb)	1✔
124	}
125
126	// unifiedEdge is the individual channel data that is kept inside an edgeUnifier
127	// object.
128	type unifiedEdge struct {
129	policy *models.CachedEdgePolicy
130	capacity btcutil.Amount
131	inboundFees models.InboundFee
132
133	// hopPayloadSize supplies an edge with the ability to calculate the
134	// exact payload size if this edge would be included in a route. This
135	// is needed because hops of a blinded path differ in their payload
136	// structure compared to cleartext hops.
137	hopPayloadSizeFn PayloadSizeFunc
138
139	// blindedPayment if set, is the BlindedPayment that this edge was
140	// derived from originally.
141	blindedPayment *BlindedPayment
142	}
143
144	// newUnifiedEdge constructs a new unifiedEdge.
145	func newUnifiedEdge(policy *models.CachedEdgePolicy, capacity btcutil.Amount,
146	inboundFees models.InboundFee, hopPayloadSizeFn PayloadSizeFunc,
147	blindedPayment BlindedPayment) unifiedEdge {	1✔
148		1✔
149	return &unifiedEdge{	1✔
150	policy: policy,	1✔
151	capacity: capacity,	1✔
152	inboundFees: inboundFees,	1✔
153	hopPayloadSizeFn: hopPayloadSizeFn,	1✔
154	blindedPayment: blindedPayment,	1✔
155	}	1✔
156	}	1✔
157
158	// amtInRange checks whether an amount falls within the valid range for a
159	// channel.
160	func (u *unifiedEdge) amtInRange(amt lnwire.MilliSatoshi) bool {	1✔
161	// If the capacity is available (non-light clients), skip channels that	1✔
162	// are too small.	1✔
163	if u.capacity > 0 &&	1✔
164	amt > lnwire.NewMSatFromSatoshis(u.capacity) {	1✔
UNCOV 165		×
UNCOV 166	log.Tracef("Not enough capacity: amt=%v, capacity=%v",	×
UNCOV 167	amt, u.capacity)	×
UNCOV 168	return false	×
UNCOV 169	}	×
170
171	// Skip channels for which this htlc is too large.
172	if u.policy.MessageFlags.HasMaxHtlc() &&	1✔
173	amt > u.policy.MaxHTLC {	2✔
174		1✔
175	log.Tracef("Exceeds policy's MaxHTLC: amt=%v, MaxHTLC=%v",	1✔
176	amt, u.policy.MaxHTLC)	1✔
177	return false	1✔
178	}	1✔
179
180	// Skip channels for which this htlc is too small.
181	if amt < u.policy.MinHTLC {	2✔
182	log.Tracef("below policy's MinHTLC: amt=%v, MinHTLC=%v",	1✔
183	amt, u.policy.MinHTLC)	1✔
184	return false	1✔
185	}	1✔
186
187	return true	1✔
188	}
189
190	// edgeUnifier is an object that covers all channels between a pair of nodes.
191	type edgeUnifier struct {
192	edges []*unifiedEdge
193	localChan bool
194	}
195
196	// getEdge returns the optimal unified edge to use for this connection given a
197	// specific amount to send. It differentiates between local and network
198	// channels.
199	func (u *edgeUnifier) getEdge(netAmtReceived lnwire.MilliSatoshi,
200	bandwidthHints bandwidthHints,
201	nextOutFee lnwire.MilliSatoshi) *unifiedEdge {	1✔
202		1✔
203	if u.localChan {	2✔
204	return u.getEdgeLocal(	1✔
205	netAmtReceived, bandwidthHints, nextOutFee,	1✔
206	)	1✔
207	}	1✔
208
209	return u.getEdgeNetwork(netAmtReceived, nextOutFee)	1✔
210	}
211
212	// calcCappedInboundFee calculates the inbound fee for a channel, taking into
213	// account the total node fee for the "to" node.
214	func calcCappedInboundFee(edge *unifiedEdge, amt lnwire.MilliSatoshi,
215	nextOutFee lnwire.MilliSatoshi) int64 {	1✔
216		1✔
217	// Calculate the inbound fee charged for the amount that passes over the	1✔
218	// channel.	1✔
219	inboundFee := edge.inboundFees.CalcFee(amt)	1✔
220		1✔
221	// Take into account that the total node fee cannot be negative.	1✔
222	if inboundFee < -int64(nextOutFee) {	1✔
UNCOV 223	inboundFee = -int64(nextOutFee)	×
UNCOV 224	}	×
225
226	return inboundFee	1✔
227	}
228
229	// getEdgeLocal returns the optimal unified edge to use for this local
230	// connection given a specific amount to send.
231	func (u *edgeUnifier) getEdgeLocal(netAmtReceived lnwire.MilliSatoshi,
232	bandwidthHints bandwidthHints,
233	nextOutFee lnwire.MilliSatoshi) *unifiedEdge {	1✔
234		1✔
235	var (	1✔
236	bestEdge *unifiedEdge	1✔
237	maxBandwidth lnwire.MilliSatoshi	1✔
238	)	1✔
239		1✔
240	for _, edge := range u.edges {	2✔
241	// Calculate the inbound fee charged at the receiving node.	1✔
242	inboundFee := calcCappedInboundFee(	1✔
243	edge, netAmtReceived, nextOutFee,	1✔
244	)	1✔
245		1✔
246	// Add inbound fee to get to the amount that is sent over the	1✔
247	// local channel.	1✔
248	amt := netAmtReceived + lnwire.MilliSatoshi(inboundFee)	1✔
249		1✔
250	// Check valid amount range for the channel. We skip this test	1✔
251	// for payments with custom HTLC data, as the amount sent on	1✔
252	// the BTC layer may differ from the amount that is actually	1✔
253	// forwarded in custom channels.	1✔
254	if bandwidthHints.firstHopCustomBlob().IsNone() &&	1✔
255	!edge.amtInRange(amt) {	1✔
UNCOV 256		×
UNCOV 257	log.Debugf("Amount %v not in range for edge %v",	×
UNCOV 258	netAmtReceived, edge.policy.ChannelID)	×
UNCOV 259		×
UNCOV 260	continue	×
261	}
262
263	// For local channels, there is no fee to pay or an extra time
264	// lock. We only consider the currently available bandwidth for
265	// channel selection. The disabled flag is ignored for local
266	// channels.
267
268	// Retrieve bandwidth for this local channel. If not
269	// available, assume this channel has enough bandwidth.
270	//
271	// TODO(joostjager): Possibly change to skipping this
272	// channel. The bandwidth hint is expected to be
273	// available.
274	bandwidth, ok := bandwidthHints.availableChanBandwidth(	1✔
275	edge.policy.ChannelID, amt,	1✔
276	)	1✔
277	if !ok {	1✔
UNCOV 278	log.Debugf("Cannot get bandwidth for edge %v, use max "+	×
UNCOV 279	"instead", edge.policy.ChannelID)	×
UNCOV 280	bandwidth = lnwire.MaxMilliSatoshi	×
UNCOV 281	}	×
282
283	// TODO(yy): if the above `!ok` is chosen, we'd have
284	// `bandwidth` to be the max value, which will end up having
285	// the `maxBandwidth` to be have the largest value and this
286	// edge will be the chosen one. This is wrong in two ways,
287	// 1. we need to understand why `availableChanBandwidth` cannot
288	// find bandwidth for this edge as something is wrong with this
289	// channel, and,
290	// 2. this edge is likely NOT the local channel with the
291	// highest available bandwidth.
292	//
293	// Skip channels that can't carry the payment.
294	if amt > bandwidth {	2✔
295	log.Debugf("Skipped edge %v: not enough bandwidth, "+	1✔
296	"bandwidth=%v, amt=%v", edge.policy.ChannelID,	1✔
297	bandwidth, amt)	1✔
298		1✔
299	continue	1✔
300	}
301
302	// We pick the local channel with the highest available
303	// bandwidth, to maximize the success probability. It can be
304	// that the channel state changes between querying the bandwidth
305	// hints and sending out the htlc.
306	if bandwidth < maxBandwidth {	1✔
UNCOV 307	log.Debugf("Skipped edge %v: not max bandwidth, "+	×
UNCOV 308	"bandwidth=%v, maxBandwidth=%v",	×
UNCOV 309	edge.policy.ChannelID, bandwidth, maxBandwidth)	×
UNCOV 310		×
UNCOV 311	continue	×
312	}
313	maxBandwidth = bandwidth	1✔
314		1✔
315	// Update best edge.	1✔
316	bestEdge = newUnifiedEdge(	1✔
317	edge.policy, edge.capacity, edge.inboundFees,	1✔
318	edge.hopPayloadSizeFn, edge.blindedPayment,	1✔
319	)	1✔
320	}
321
322	return bestEdge	1✔
323	}
324
325	// getEdgeNetwork returns the optimal unified edge to use for this connection
326	// given a specific amount to send. The goal is to return a unified edge with a
327	// policy that maximizes the probability of a successful forward in a non-strict
328	// forwarding context.
329	func (u *edgeUnifier) getEdgeNetwork(netAmtReceived lnwire.MilliSatoshi,
330	nextOutFee lnwire.MilliSatoshi) *unifiedEdge {	1✔
331		1✔
332	var (	1✔
333	bestPolicy *unifiedEdge	1✔
334	maxFee int64 = math.MinInt64	1✔
335	maxTimelock uint16	1✔
336	maxCapMsat lnwire.MilliSatoshi	1✔
337	hopPayloadSizeFn PayloadSizeFunc	1✔
338	)	1✔
339		1✔
340	for _, edge := range u.edges {	2✔
341	// Calculate the inbound fee charged at the receiving node.	1✔
342	inboundFee := calcCappedInboundFee(	1✔
343	edge, netAmtReceived, nextOutFee,	1✔
344	)	1✔
345		1✔
346	// Add inbound fee to get to the amount that is sent over the	1✔
347	// channel.	1✔
348	amt := netAmtReceived + lnwire.MilliSatoshi(inboundFee)	1✔
349		1✔
350	// Check valid amount range for the channel.	1✔
351	if !edge.amtInRange(amt) {	2✔
352	log.Debugf("Amount %v not in range for edge %v",	1✔
353	amt, edge.policy.ChannelID)	1✔
354	continue	1✔
355	}
356
357	// For network channels, skip the disabled ones.
358	edgeFlags := edge.policy.ChannelFlags	1✔
359	isDisabled := edgeFlags&lnwire.ChanUpdateDisabled != 0	1✔
360	if isDisabled {	1✔
UNCOV 361	log.Debugf("Skipped edge %v due to it being disabled",	×
UNCOV 362	edge.policy.ChannelID)	×
UNCOV 363	continue	×
364	}
365
366	// Track the maximal capacity for usable channels. If we don't
367	// know the capacity, we fall back to MaxHTLC.
368	capMsat := lnwire.NewMSatFromSatoshis(edge.capacity)	1✔
369	if capMsat == 0 && edge.policy.MessageFlags.HasMaxHtlc() {	1✔
UNCOV 370	log.Tracef("No capacity available for channel %v, "+	×
UNCOV 371	"using MaxHtlcMsat (%v) as a fallback.",	×
UNCOV 372	edge.policy.ChannelID, edge.policy.MaxHTLC)	×
UNCOV 373		×
UNCOV 374	capMsat = edge.policy.MaxHTLC	×
UNCOV 375	}	×
376	maxCapMsat = lntypes.Max(capMsat, maxCapMsat)	1✔
377		1✔
378	// Track the maximum time lock of all channels that are	1✔
379	// candidate for non-strict forwarding at the routing node.	1✔
380	maxTimelock = lntypes.Max(	1✔
381	maxTimelock, edge.policy.TimeLockDelta,	1✔
382	)	1✔
383		1✔
384	outboundFee := int64(edge.policy.ComputeFee(amt))	1✔
385	fee := outboundFee + inboundFee	1✔
386		1✔
387	// Use the policy that results in the highest fee for this	1✔
388	// specific amount.	1✔
389	if fee < maxFee {	1✔
UNCOV 390	log.Debugf("Skipped edge %v due to it produces less "+	×
UNCOV 391	"fee: fee=%v, maxFee=%v",	×
UNCOV 392	edge.policy.ChannelID, fee, maxFee)	×
UNCOV 393		×
UNCOV 394	continue	×
395	}
396	maxFee = fee	1✔
397		1✔
398	bestPolicy = newUnifiedEdge(	1✔
399	edge.policy, 0, edge.inboundFees, nil,	1✔
400	edge.blindedPayment,	1✔
401	)	1✔
402		1✔
403	// The payload size function for edges to a connected peer is	1✔
404	// always the same hence there is not need to find the maximum.	1✔
405	// This also counts for blinded edges where we only have one	1✔
406	// edge to a blinded peer.	1✔
407	hopPayloadSizeFn = edge.hopPayloadSizeFn	1✔
408	}
409
410	// Return early if no channel matches.
411	if bestPolicy == nil {	2✔
412	return nil	1✔
413	}	1✔
414
415	// We have already picked the highest fee that could be required for
416	// non-strict forwarding. To also cover the case where a lower fee
417	// channel requires a longer time lock, we modify the policy by setting
418	// the maximum encountered time lock. Note that this results in a
419	// synthetic policy that is not actually present on the routing node.
420	//
421	// The reason we do this, is that we try to maximize the chance that we
422	// get forwarded. Because we penalize pair-wise, there won't be a second
423	// chance for this node pair. But this is all only needed for nodes that
424	// have distinct policies for channels to the same peer.
425	policyCopy := *bestPolicy.policy	1✔
426	policyCopy.TimeLockDelta = maxTimelock	1✔
427	modifiedEdge := newUnifiedEdge(	1✔
428	&policyCopy, maxCapMsat.ToSatoshis(), bestPolicy.inboundFees,	1✔
429	hopPayloadSizeFn, bestPolicy.blindedPayment,	1✔
430	)	1✔
431		1✔
432	return modifiedEdge	1✔
433	}
434
435	// minAmt returns the minimum amount that can be forwarded on this connection.
UNCOV 436	func (u *edgeUnifier) minAmt() lnwire.MilliSatoshi {	×
UNCOV 437	min := lnwire.MaxMilliSatoshi	×
UNCOV 438	for _, edge := range u.edges {	×
UNCOV 439	min = lntypes.Min(min, edge.policy.MinHTLC)	×
UNCOV 440	}	×
441
UNCOV 442	return min	×
443	}

lightningnetwork / lnd / 12115442155

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous