12293715361

Committed 12 Dec 2024 09:38AM UTC coverage: 57.483% (+7.9%) from 49.538%

Build # 12293715361

Build Type

Pull #9348

github

Committed by

ziggie1984

Commit Message

github: update goveralls tool

The goverall tool had a bug regarding the module versioning of
golang packages see also
https://github.com/mattn/goveralls/pull/222 for more background.
Goveralls is wrapped by another library to make it available for
github actions. So the relevant PR which is referenced here in
LND is:
https://github.com/shogo82148/actions-goveralls/pull/521.

Pull Request Pull Request #9348: github: update goveralls tool

Run Details

101897 of 177264 relevant lines covered (57.48%)

24982.4 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/lncfg/htlcswitch.go

package lncfg

import (
        "fmt"
        "time"
)

var (
        // MaxMailboxDeliveryTimeout specifies the max allowed timeout value.
        // This value is derived from the itest `async_bidirectional_payments`,
        // where both side send 483 payments at the same time to stress test
        // lnd.
        MaxMailboxDeliveryTimeout = 2 * time.Minute
)

//nolint:ll
type Htlcswitch struct {
        MailboxDeliveryTimeout time.Duration `long:"mailboxdeliverytimeout" description:"The timeout value when delivering HTLCs to a channel link. Setting this value too small will result in local payment failures if large number of payments are sent over a short period."`
}

// Validate checks the values configured for htlcswitch.
func (h *Htlcswitch) Validate() error {
        if h.MailboxDeliveryTimeout <= 0 {
                return fmt.Errorf("mailboxdeliverytimeout must be positive")
        }

        if h.MailboxDeliveryTimeout > MaxMailboxDeliveryTimeout {
                return fmt.Errorf("mailboxdeliverytimeout: %v exceeds "+
                        "maximum: %v", h.MailboxDeliveryTimeout,
                        MaxMailboxDeliveryTimeout)
        }

        return nil
}

1	package lncfg
2
3	import (
4	"fmt"
5	"time"
6	)
7
8	var (
9	// MaxMailboxDeliveryTimeout specifies the max allowed timeout value.
10	// This value is derived from the itest `async_bidirectional_payments`,
11	// where both side send 483 payments at the same time to stress test
12	// lnd.
13	MaxMailboxDeliveryTimeout = 2 * time.Minute
14	)
15
16	//nolint:ll
17	type Htlcswitch struct {
18	MailboxDeliveryTimeout time.Duration `long:"mailboxdeliverytimeout" description:"The timeout value when delivering HTLCs to a channel link. Setting this value too small will result in local payment failures if large number of payments are sent over a short period."`
19	}
20
21	// Validate checks the values configured for htlcswitch.
22	func (h *Htlcswitch) Validate() error {	×
23	if h.MailboxDeliveryTimeout <= 0 {	×
24	return fmt.Errorf("mailboxdeliverytimeout must be positive")	×
25	}	×
26
27	if h.MailboxDeliveryTimeout > MaxMailboxDeliveryTimeout {	×
28	return fmt.Errorf("mailboxdeliverytimeout: %v exceeds "+	×
29	"maximum: %v", h.MailboxDeliveryTimeout,	×
30	MaxMailboxDeliveryTimeout)	×
31	}	×
32
33	return nil	×
34	}

lightningnetwork / lnd / 12293715361

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous