12293715361

Committed 12 Dec 2024 09:38AM UTC coverage: 57.483% (+7.9%) from 49.538%

Build # 12293715361

Build Type

Pull #9348

github

Committed by

ziggie1984

Commit Message

github: update goveralls tool

The goverall tool had a bug regarding the module versioning of
golang packages see also
https://github.com/mattn/goveralls/pull/222 for more background.
Goveralls is wrapped by another library to make it available for
github actions. So the relevant PR which is referenced here in
LND is:
https://github.com/shogo82148/actions-goveralls/pull/521.

Pull Request Pull Request #9348: github: update goveralls tool

Run Details

101897 of 177264 relevant lines covered (57.48%)

24982.4 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/lncfg/protocol_legacy_on.go

//go:build dev
// +build dev

package lncfg

// Legacy is a sub-config that houses all the legacy protocol options.  These
// are mostly used for integration tests as most modern nodes should always run
// with them on by default.
//
//nolint:ll
type LegacyProtocol struct {
        // LegacyOnionFormat if set to true, then we won't signal
        // TLVOnionPayloadOptional. As a result, nodes that include us in the
        // route won't use the new modern onion framing.
        LegacyOnionFormat bool `long:"onion" description:"force node to not advertise the new modern TLV onion format"`

        // CommitmentTweak guards if we should use the old legacy commitment
        // protocol, or the newer variant that doesn't have a tweak for the
        // remote party's output in the commitment. If set to true, then we
        // won't signal StaticRemoteKeyOptional.
        CommitmentTweak bool `long:"committweak" description:"force node to not advertise the new commitment format"`
}

// LegacyOnion returns true if the old legacy onion format should be used when
// we're an intermediate or final hop. This controls if we set the
// TLVOnionPayloadOptional bit or not.
func (l *LegacyProtocol) LegacyOnion() bool {
        return l.LegacyOnionFormat
}

// NoStaticRemoteKey returns true if the old commitment format with a tweaked
// remote key should be used for new funded channels.
func (l *LegacyProtocol) NoStaticRemoteKey() bool {
        return l.CommitmentTweak
}

1	//go:build dev
2	// +build dev
3
4	package lncfg
5
6	// Legacy is a sub-config that houses all the legacy protocol options. These
7	// are mostly used for integration tests as most modern nodes should always run
8	// with them on by default.
9	//
10	//nolint:ll
11	type LegacyProtocol struct {
12	// LegacyOnionFormat if set to true, then we won't signal
13	// TLVOnionPayloadOptional. As a result, nodes that include us in the
14	// route won't use the new modern onion framing.
15	LegacyOnionFormat bool `long:"onion" description:"force node to not advertise the new modern TLV onion format"`
16
17	// CommitmentTweak guards if we should use the old legacy commitment
18	// protocol, or the newer variant that doesn't have a tweak for the
19	// remote party's output in the commitment. If set to true, then we
20	// won't signal StaticRemoteKeyOptional.
21	CommitmentTweak bool `long:"committweak" description:"force node to not advertise the new commitment format"`
22	}
23
24	// LegacyOnion returns true if the old legacy onion format should be used when
25	// we're an intermediate or final hop. This controls if we set the
26	// TLVOnionPayloadOptional bit or not.
27	func (l *LegacyProtocol) LegacyOnion() bool {	×
28	return l.LegacyOnionFormat	×
29	}	×
30
31	// NoStaticRemoteKey returns true if the old commitment format with a tweaked
32	// remote key should be used for new funded channels.
33	func (l *LegacyProtocol) NoStaticRemoteKey() bool {	×
34	return l.CommitmentTweak	×
35	}	×

lightningnetwork / lnd / 12293715361

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous