12312390362

Committed 13 Dec 2024 08:44AM UTC coverage: 57.458% (+8.5%) from 48.92%

Build # 12312390362

Build Type

Pull #9343

github

Committed by

ellemouton

Commit Message

fn: rework the ContextGuard and add tests

In this commit, the ContextGuard struct is re-worked such that the
context that its new main WithCtx method provides is cancelled in sync
with a parent context being cancelled or with it's quit channel being
cancelled. Tests are added to assert the behaviour. In order for the
close of the quit channel to be consistent with the cancelling of the
derived context, the quit channel _must_ be contained internal to the
ContextGuard so that callers are only able to close the channel via the
exposed Quit method which will then take care to first cancel any
derived context that depend on the quit channel before returning.

Pull Request Pull Request #9343: fn: expand the ContextGuard and add tests

Run Details

101853 of 177264 relevant lines covered (57.46%)

24972.93 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/chainreg/taproot_check.go

package chainreg

import (
        "encoding/json"

        "github.com/btcsuite/btcd/rpcclient"
)

// backendSupportsTaproot returns true if the backend understands the taproot
// soft fork.
func backendSupportsTaproot(rpc *rpcclient.Client) bool {
        // First, we'll try to access the normal getblockchaininfo call.
        chainInfo, err := rpc.GetBlockChainInfo()
        if err == nil {
                // If this call worked, then we'll check that the taproot
                // deployment is defined.
                switch {
                // Bitcoind versions before 0.19 and also btcd use the
                // SoftForks fields.
                case chainInfo.SoftForks != nil:
                        _, ok := chainInfo.SoftForks.Bip9SoftForks["taproot"]
                        if ok {
                                return ok
                        }

                // Bitcoind versions after 0.19 will use the UnifiedSoftForks
                // field that factors in the set of "buried" soft forks.
                case chainInfo.UnifiedSoftForks != nil:
                        _, ok := chainInfo.UnifiedSoftForks.SoftForks["taproot"]
                        if ok {
                                return ok
                        }
                }
        }

        // The user might be running a newer version of bitcoind that doesn't
        // implement the getblockchaininfo call any longer, so we'll fall back
        // here.
        //
        // Alternatively, the fork wasn't specified, but the user might be
        // running a newer version of bitcoind that still has the
        // getblockchaininfo call, but doesn't populate the data, so we'll hit
        // the new getdeploymentinfo call.
        resp, err := rpc.RawRequest("getdeploymentinfo", nil)
        if err != nil {
                log.Warnf("unable to make getdeploymentinfo request: %v", err)
                return false
        }

        info := struct {
                Deployments map[string]struct {
                        Type   string `json:"type"`
                        Active bool   `json:"active"`
                        Height int32  `json:"height"`
                } `json:"deployments"`
        }{}
        if err := json.Unmarshal(resp, &info); err != nil {
                log.Warnf("unable to decode getdeploymentinfo resp: %v", err)
                return false
        }

        _, ok := info.Deployments["taproot"]
        return ok
}

1	package chainreg
2
3	import (
4	"encoding/json"
5
6	"github.com/btcsuite/btcd/rpcclient"
7	)
8
9	// backendSupportsTaproot returns true if the backend understands the taproot
10	// soft fork.
11	func backendSupportsTaproot(rpc *rpcclient.Client) bool {	×
12	// First, we'll try to access the normal getblockchaininfo call.	×
13	chainInfo, err := rpc.GetBlockChainInfo()	×
14	if err == nil {	×
15	// If this call worked, then we'll check that the taproot	×
16	// deployment is defined.	×
17	switch {	×
18	// Bitcoind versions before 0.19 and also btcd use the
19	// SoftForks fields.
20	case chainInfo.SoftForks != nil:	×
21	_, ok := chainInfo.SoftForks.Bip9SoftForks["taproot"]	×
22	if ok {	×
23	return ok	×
24	}	×
25
26	// Bitcoind versions after 0.19 will use the UnifiedSoftForks
27	// field that factors in the set of "buried" soft forks.
28	case chainInfo.UnifiedSoftForks != nil:	×
29	_, ok := chainInfo.UnifiedSoftForks.SoftForks["taproot"]	×
30	if ok {	×
31	return ok	×
32	}	×
33	}
34	}
35
36	// The user might be running a newer version of bitcoind that doesn't
37	// implement the getblockchaininfo call any longer, so we'll fall back
38	// here.
39	//
40	// Alternatively, the fork wasn't specified, but the user might be
41	// running a newer version of bitcoind that still has the
42	// getblockchaininfo call, but doesn't populate the data, so we'll hit
43	// the new getdeploymentinfo call.
44	resp, err := rpc.RawRequest("getdeploymentinfo", nil)	×
45	if err != nil {	×
46	log.Warnf("unable to make getdeploymentinfo request: %v", err)	×
47	return false	×
48	}	×
49
50	info := struct {	×
51	Deployments map[string]struct {	×
52	Type string `json:"type"`	×
53	Active bool `json:"active"`	×
54	Height int32 `json:"height"`	×
55	} `json:"deployments"`	×
56	}{}	×
57	if err := json.Unmarshal(resp, &info); err != nil {	×
58	log.Warnf("unable to decode getdeploymentinfo resp: %v", err)	×
59	return false	×
60	}	×
61
62	_, ok := info.Deployments["taproot"]	×
63	return ok	×
64	}

lightningnetwork / lnd / 12312390362

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous