12312390362

Committed 13 Dec 2024 08:44AM UTC coverage: 57.458% (+8.5%) from 48.92%

Build # 12312390362

Build Type

Pull #9343

github

Committed by

ellemouton

Commit Message

fn: rework the ContextGuard and add tests

In this commit, the ContextGuard struct is re-worked such that the
context that its new main WithCtx method provides is cancelled in sync
with a parent context being cancelled or with it's quit channel being
cancelled. Tests are added to assert the behaviour. In order for the
close of the quit channel to be consistent with the cancelling of the
derived context, the quit channel _must_ be contained internal to the
ContextGuard so that callers are only able to close the channel via the
exposed Quit method which will then take care to first cancel any
derived context that depend on the quit channel before returning.

Pull Request Pull Request #9343: fn: expand the ContextGuard and add tests

Run Details

101853 of 177264 relevant lines covered (57.46%)

24972.93 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/lncfg/gossip.go

package lncfg

import (
        "time"

        "github.com/lightningnetwork/lnd/discovery"
        "github.com/lightningnetwork/lnd/routing/route"
)

//nolint:ll
type Gossip struct {
        PinnedSyncersRaw []string `long:"pinned-syncers" description:"A set of peers that should always remain in an active sync state, which can be used to closely synchronize the routing tables of two nodes. The value should be a hex-encoded pubkey, the flag can be specified multiple times to add multiple peers. Connected peers matching this pubkey will remain active for the duration of the connection and not count towards the NumActiveSyncer count."`

        PinnedSyncers discovery.PinnedSyncers

        MaxChannelUpdateBurst int `long:"max-channel-update-burst" description:"The maximum number of updates for a specific channel and direction that lnd will accept over the channel update interval."`

        ChannelUpdateInterval time.Duration `long:"channel-update-interval" description:"The interval used to determine how often lnd should allow a burst of new updates for a specific channel and direction."`

        SubBatchDelay time.Duration `long:"sub-batch-delay" description:"The duration to wait before sending the next announcement batch if there are multiple. Use a small value if there are a lot announcements and they need to be broadcast quickly."`
}

// Parse the pubkeys for the pinned syncers.
func (g *Gossip) Parse() error {
        pinnedSyncers := make(discovery.PinnedSyncers)
        for _, pubkeyStr := range g.PinnedSyncersRaw {
                vertex, err := route.NewVertexFromStr(pubkeyStr)
                if err != nil {
                        return err
                }
                pinnedSyncers[vertex] = struct{}{}
        }

        g.PinnedSyncers = pinnedSyncers

        return nil
}

1	package lncfg
2
3	import (
4	"time"
5
6	"github.com/lightningnetwork/lnd/discovery"
7	"github.com/lightningnetwork/lnd/routing/route"
8	)
9
10	//nolint:ll
11	type Gossip struct {
12	PinnedSyncersRaw []string `long:"pinned-syncers" description:"A set of peers that should always remain in an active sync state, which can be used to closely synchronize the routing tables of two nodes. The value should be a hex-encoded pubkey, the flag can be specified multiple times to add multiple peers. Connected peers matching this pubkey will remain active for the duration of the connection and not count towards the NumActiveSyncer count."`
13
14	PinnedSyncers discovery.PinnedSyncers
15
16	MaxChannelUpdateBurst int `long:"max-channel-update-burst" description:"The maximum number of updates for a specific channel and direction that lnd will accept over the channel update interval."`
17
18	ChannelUpdateInterval time.Duration `long:"channel-update-interval" description:"The interval used to determine how often lnd should allow a burst of new updates for a specific channel and direction."`
19
20	SubBatchDelay time.Duration `long:"sub-batch-delay" description:"The duration to wait before sending the next announcement batch if there are multiple. Use a small value if there are a lot announcements and they need to be broadcast quickly."`
21	}
22
23	// Parse the pubkeys for the pinned syncers.
24	func (g *Gossip) Parse() error {	×
25	pinnedSyncers := make(discovery.PinnedSyncers)	×
26	for _, pubkeyStr := range g.PinnedSyncersRaw {	×
27	vertex, err := route.NewVertexFromStr(pubkeyStr)	×
28	if err != nil {	×
29	return err	×
30	}	×
31	pinnedSyncers[vertex] = struct{}{}	×
32	}
33
34	g.PinnedSyncers = pinnedSyncers	×
35		×
36	return nil	×
37	}

lightningnetwork / lnd / 12312390362

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous