12312390362

Committed 13 Dec 2024 08:44AM UTC coverage: 57.458% (+8.5%) from 48.92%

Build # 12312390362

Build Type

Pull #9343

github

Committed by

ellemouton

Commit Message

fn: rework the ContextGuard and add tests

In this commit, the ContextGuard struct is re-worked such that the
context that its new main WithCtx method provides is cancelled in sync
with a parent context being cancelled or with it's quit channel being
cancelled. Tests are added to assert the behaviour. In order for the
close of the quit channel to be consistent with the cancelling of the
derived context, the quit channel _must_ be contained internal to the
ContextGuard so that callers are only able to close the channel via the
exposed Quit method which will then take care to first cancel any
derived context that depend on the quit channel before returning.

Pull Request Pull Request #9343: fn: expand the ContextGuard and add tests

Run Details

101853 of 177264 relevant lines covered (57.46%)

24972.93 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/lncfg/htlcswitch.go

package lncfg

import (
        "fmt"
        "time"
)

var (
        // MaxMailboxDeliveryTimeout specifies the max allowed timeout value.
        // This value is derived from the itest `async_bidirectional_payments`,
        // where both side send 483 payments at the same time to stress test
        // lnd.
        MaxMailboxDeliveryTimeout = 2 * time.Minute
)

//nolint:ll
type Htlcswitch struct {
        MailboxDeliveryTimeout time.Duration `long:"mailboxdeliverytimeout" description:"The timeout value when delivering HTLCs to a channel link. Setting this value too small will result in local payment failures if large number of payments are sent over a short period."`
}

// Validate checks the values configured for htlcswitch.
func (h *Htlcswitch) Validate() error {
        if h.MailboxDeliveryTimeout <= 0 {
                return fmt.Errorf("mailboxdeliverytimeout must be positive")
        }

        if h.MailboxDeliveryTimeout > MaxMailboxDeliveryTimeout {
                return fmt.Errorf("mailboxdeliverytimeout: %v exceeds "+
                        "maximum: %v", h.MailboxDeliveryTimeout,
                        MaxMailboxDeliveryTimeout)
        }

        return nil
}

1	package lncfg
2
3	import (
4	"fmt"
5	"time"
6	)
7
8	var (
9	// MaxMailboxDeliveryTimeout specifies the max allowed timeout value.
10	// This value is derived from the itest `async_bidirectional_payments`,
11	// where both side send 483 payments at the same time to stress test
12	// lnd.
13	MaxMailboxDeliveryTimeout = 2 * time.Minute
14	)
15
16	//nolint:ll
17	type Htlcswitch struct {
18	MailboxDeliveryTimeout time.Duration `long:"mailboxdeliverytimeout" description:"The timeout value when delivering HTLCs to a channel link. Setting this value too small will result in local payment failures if large number of payments are sent over a short period."`
19	}
20
21	// Validate checks the values configured for htlcswitch.
22	func (h *Htlcswitch) Validate() error {	×
23	if h.MailboxDeliveryTimeout <= 0 {	×
24	return fmt.Errorf("mailboxdeliverytimeout must be positive")	×
25	}	×
26
27	if h.MailboxDeliveryTimeout > MaxMailboxDeliveryTimeout {	×
28	return fmt.Errorf("mailboxdeliverytimeout: %v exceeds "+	×
29	"maximum: %v", h.MailboxDeliveryTimeout,	×
30	MaxMailboxDeliveryTimeout)	×
31	}	×
32
33	return nil	×
34	}

lightningnetwork / lnd / 12312390362

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous