12312390362

Committed 13 Dec 2024 08:44AM UTC coverage: 57.458% (+8.5%) from 48.92%

Build # 12312390362

Build Type

Pull #9343

github

Committed by

ellemouton

Commit Message

fn: rework the ContextGuard and add tests

In this commit, the ContextGuard struct is re-worked such that the
context that its new main WithCtx method provides is cancelled in sync
with a parent context being cancelled or with it's quit channel being
cancelled. Tests are added to assert the behaviour. In order for the
close of the quit channel to be consistent with the cancelling of the
derived context, the quit channel _must_ be contained internal to the
ContextGuard so that callers are only able to close the channel via the
exposed Quit method which will then take care to first cancel any
derived context that depend on the quit channel before returning.

Pull Request Pull Request #9343: fn: expand the ContextGuard and add tests

Run Details

101853 of 177264 relevant lines covered (57.46%)

24972.93 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.78

/lnwallet/chainfee/rates.go

package chainfee

import (
        "fmt"

        "github.com/btcsuite/btcd/blockchain"
        "github.com/btcsuite/btcd/btcutil"
        "github.com/lightningnetwork/lnd/lntypes"
)

const (
        // FeePerKwFloor is the lowest fee rate in sat/kw that we should use for
        // estimating transaction fees before signing.
        FeePerKwFloor SatPerKWeight = 253

        // AbsoluteFeePerKwFloor is the lowest fee rate in sat/kw of a
        // transaction that we should ever _create_. This is the equivalent
        // of 1 sat/byte in sat/kw.
        AbsoluteFeePerKwFloor SatPerKWeight = 250
)

// SatPerVByte represents a fee rate in sat/vbyte.
type SatPerVByte btcutil.Amount

// FeePerKWeight converts the current fee rate from sat/vb to sat/kw.
func (s SatPerVByte) FeePerKWeight() SatPerKWeight {
        return SatPerKWeight(s * 1000 / blockchain.WitnessScaleFactor)
}

// FeePerKVByte converts the current fee rate from sat/vb to sat/kvb.
func (s SatPerVByte) FeePerKVByte() SatPerKVByte {
        return SatPerKVByte(s * 1000)
}

// String returns a human-readable string of the fee rate.
func (s SatPerVByte) String() string {
        return fmt.Sprintf("%v sat/vb", int64(s))
}

// SatPerKVByte represents a fee rate in sat/kb.
type SatPerKVByte btcutil.Amount

// FeeForVSize calculates the fee resulting from this fee rate and the given
// vsize in vbytes.
func (s SatPerKVByte) FeeForVSize(vbytes lntypes.VByte) btcutil.Amount {
        return btcutil.Amount(s) * btcutil.Amount(vbytes) / 1000
}

// FeePerKWeight converts the current fee rate from sat/kb to sat/kw.
func (s SatPerKVByte) FeePerKWeight() SatPerKWeight {
        return SatPerKWeight(s / blockchain.WitnessScaleFactor)
}

// String returns a human-readable string of the fee rate.
func (s SatPerKVByte) String() string {
        return fmt.Sprintf("%v sat/kvb", int64(s))
}

// SatPerKWeight represents a fee rate in sat/kw.
type SatPerKWeight btcutil.Amount

// NewSatPerKWeight creates a new fee rate in sat/kw.
func NewSatPerKWeight(fee btcutil.Amount, wu lntypes.WeightUnit) SatPerKWeight {
        return SatPerKWeight(fee.MulF64(1000 / float64(wu)))
}

// FeeForWeight calculates the fee resulting from this fee rate and the given
// weight in weight units (wu).
func (s SatPerKWeight) FeeForWeight(wu lntypes.WeightUnit) btcutil.Amount {
        // The resulting fee is rounded down, as specified in BOLT#03.
        return btcutil.Amount(s) * btcutil.Amount(wu) / 1000
}

// FeeForVByte calculates the fee resulting from this fee rate and the given
// size in vbytes (vb).
func (s SatPerKWeight) FeeForVByte(vb lntypes.VByte) btcutil.Amount {
        return s.FeePerKVByte().FeeForVSize(vb)
}

// FeePerKVByte converts the current fee rate from sat/kw to sat/kb.
func (s SatPerKWeight) FeePerKVByte() SatPerKVByte {
        return SatPerKVByte(s * blockchain.WitnessScaleFactor)
}

// FeePerVByte converts the current fee rate from sat/kw to sat/vb.
func (s SatPerKWeight) FeePerVByte() SatPerVByte {
        return SatPerVByte(s * blockchain.WitnessScaleFactor / 1000)
}

// String returns a human-readable string of the fee rate.
func (s SatPerKWeight) String() string {
        return fmt.Sprintf("%v sat/kw", int64(s))
}

1	package chainfee
2
3	import (
4	"fmt"
5
6	"github.com/btcsuite/btcd/blockchain"
7	"github.com/btcsuite/btcd/btcutil"
8	"github.com/lightningnetwork/lnd/lntypes"
9	)
10
11	const (
12	// FeePerKwFloor is the lowest fee rate in sat/kw that we should use for
13	// estimating transaction fees before signing.
14	FeePerKwFloor SatPerKWeight = 253
15
16	// AbsoluteFeePerKwFloor is the lowest fee rate in sat/kw of a
17	// transaction that we should ever _create_. This is the equivalent
18	// of 1 sat/byte in sat/kw.
19	AbsoluteFeePerKwFloor SatPerKWeight = 250
20	)
21
22	// SatPerVByte represents a fee rate in sat/vbyte.
23	type SatPerVByte btcutil.Amount
24
25	// FeePerKWeight converts the current fee rate from sat/vb to sat/kw.
26	func (s SatPerVByte) FeePerKWeight() SatPerKWeight {	17✔
27	return SatPerKWeight(s * 1000 / blockchain.WitnessScaleFactor)	17✔
28	}	17✔
29
30	// FeePerKVByte converts the current fee rate from sat/vb to sat/kvb.
31	func (s SatPerVByte) FeePerKVByte() SatPerKVByte {	1✔
32	return SatPerKVByte(s * 1000)	1✔
33	}	1✔
34
35	// String returns a human-readable string of the fee rate.
36	func (s SatPerVByte) String() string {	1✔
37	return fmt.Sprintf("%v sat/vb", int64(s))	1✔
38	}	1✔
39
40	// SatPerKVByte represents a fee rate in sat/kb.
41	type SatPerKVByte btcutil.Amount
42
43	// FeeForVSize calculates the fee resulting from this fee rate and the given
44	// vsize in vbytes.
45	func (s SatPerKVByte) FeeForVSize(vbytes lntypes.VByte) btcutil.Amount {	234✔
46	return btcutil.Amount(s) * btcutil.Amount(vbytes) / 1000	234✔
47	}	234✔
48
49	// FeePerKWeight converts the current fee rate from sat/kb to sat/kw.
50	func (s SatPerKVByte) FeePerKWeight() SatPerKWeight {	221✔
51	return SatPerKWeight(s / blockchain.WitnessScaleFactor)	221✔
52	}	221✔
53
54	// String returns a human-readable string of the fee rate.
55	func (s SatPerKVByte) String() string {	×
56	return fmt.Sprintf("%v sat/kvb", int64(s))	×
57	}	×
58
59	// SatPerKWeight represents a fee rate in sat/kw.
60	type SatPerKWeight btcutil.Amount
61
62	// NewSatPerKWeight creates a new fee rate in sat/kw.
63	func NewSatPerKWeight(fee btcutil.Amount, wu lntypes.WeightUnit) SatPerKWeight {	8✔
64	return SatPerKWeight(fee.MulF64(1000 / float64(wu)))	8✔
65	}	8✔
66
67	// FeeForWeight calculates the fee resulting from this fee rate and the given
68	// weight in weight units (wu).
69	func (s SatPerKWeight) FeeForWeight(wu lntypes.WeightUnit) btcutil.Amount {	240,429✔
70	// The resulting fee is rounded down, as specified in BOLT#03.	240,429✔
71	return btcutil.Amount(s) * btcutil.Amount(wu) / 1000	240,429✔
72	}	240,429✔
73
74	// FeeForVByte calculates the fee resulting from this fee rate and the given
75	// size in vbytes (vb).
76	func (s SatPerKWeight) FeeForVByte(vb lntypes.VByte) btcutil.Amount {	×
77	return s.FeePerKVByte().FeeForVSize(vb)	×
78	}	×
79
80	// FeePerKVByte converts the current fee rate from sat/kw to sat/kb.
81	func (s SatPerKWeight) FeePerKVByte() SatPerKVByte {	532✔
82	return SatPerKVByte(s * blockchain.WitnessScaleFactor)	532✔
83	}	532✔
84
85	// FeePerVByte converts the current fee rate from sat/kw to sat/vb.
86	func (s SatPerKWeight) FeePerVByte() SatPerVByte {	36✔
87	return SatPerVByte(s * blockchain.WitnessScaleFactor / 1000)	36✔
88	}	36✔
89
90	// String returns a human-readable string of the fee rate.
91	func (s SatPerKWeight) String() string {	32✔
92	return fmt.Sprintf("%v sat/kw", int64(s))	32✔
93	}	32✔

lightningnetwork / lnd / 12312390362

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous