12343072627

Committed 15 Dec 2024 11:09PM UTC coverage: 57.504% (-1.1%) from 58.636%

Build # 12343072627

Build Type

Pull #9315

github

Committed by

yyforyongyu

Commit Message

contractcourt: offer outgoing htlc one block earlier before its expiry

We need to offer the outgoing htlc one block earlier to make sure when
the expiry height hits, the sweeper will not miss sweeping it in the
same block. This also means the outgoing contest resolver now only does
one thing - watch for preimage spend till height expiry-1, which can
easily be moved into the timeout resolver instead in the future.

Pull Request Pull Request #9315: Implement `blockbeat`

Run Details

1445 of 2007 new or added lines in 26 files covered. (72.0%)

19246 existing lines in 249 files now uncovered.

102342 of 177975 relevant lines covered (57.5%)

24772.24 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/lncfg/remotesigner.go

package lncfg

import (
        "fmt"
        "time"
)

const (
        // DefaultRemoteSignerRPCTimeout is the default timeout that is used
        // when forwarding a request to the remote signer through RPC.
        DefaultRemoteSignerRPCTimeout = 5 * time.Second
)

// RemoteSigner holds the configuration options for a remote RPC signer.
//
//nolint:ll
type RemoteSigner struct {
        Enable           bool          `long:"enable" description:"Use a remote signer for signing any on-chain related transactions or messages. Only recommended if local wallet is initialized as watch-only. Remote signer must use the same seed/root key as the local watch-only wallet but must have private keys."`
        RPCHost          string        `long:"rpchost" description:"The remote signer's RPC host:port"`
        MacaroonPath     string        `long:"macaroonpath" description:"The macaroon to use for authenticating with the remote signer"`
        TLSCertPath      string        `long:"tlscertpath" description:"The TLS certificate to use for establishing the remote signer's identity"`
        Timeout          time.Duration `long:"timeout" description:"The timeout for connecting to and signing requests with the remote signer. Valid time units are {s, m, h}."`
        MigrateWatchOnly bool          `long:"migrate-wallet-to-watch-only" description:"If a wallet with private key material already exists, migrate it into a watch-only wallet on first startup. WARNING: This cannot be undone! Make sure you have backed up your seed before you use this flag! All private keys will be purged from the wallet after first unlock with this flag!"`
}

// Validate checks the values configured for our remote RPC signer.
func (r *RemoteSigner) Validate() error {
        if !r.Enable {
                return nil
        }

        if r.Timeout < time.Millisecond {
                return fmt.Errorf("remote signer: timeout of %v is invalid, "+
                        "cannot be smaller than %v", r.Timeout,
                        time.Millisecond)
        }

        if r.MigrateWatchOnly && !r.Enable {
                return fmt.Errorf("remote signer: cannot turn on wallet " +
                        "migration to watch-only if remote signing is not " +
                        "enabled")
        }

        return nil
}

1	package lncfg
2
3	import (
4	"fmt"
5	"time"
6	)
7
8	const (
9	// DefaultRemoteSignerRPCTimeout is the default timeout that is used
10	// when forwarding a request to the remote signer through RPC.
11	DefaultRemoteSignerRPCTimeout = 5 * time.Second
12	)
13
14	// RemoteSigner holds the configuration options for a remote RPC signer.
15	//
16	//nolint:ll
17	type RemoteSigner struct {
18	Enable bool `long:"enable" description:"Use a remote signer for signing any on-chain related transactions or messages. Only recommended if local wallet is initialized as watch-only. Remote signer must use the same seed/root key as the local watch-only wallet but must have private keys."`
19	RPCHost string `long:"rpchost" description:"The remote signer's RPC host:port"`
20	MacaroonPath string `long:"macaroonpath" description:"The macaroon to use for authenticating with the remote signer"`
21	TLSCertPath string `long:"tlscertpath" description:"The TLS certificate to use for establishing the remote signer's identity"`
22	Timeout time.Duration `long:"timeout" description:"The timeout for connecting to and signing requests with the remote signer. Valid time units are {s, m, h}."`
23	MigrateWatchOnly bool `long:"migrate-wallet-to-watch-only" description:"If a wallet with private key material already exists, migrate it into a watch-only wallet on first startup. WARNING: This cannot be undone! Make sure you have backed up your seed before you use this flag! All private keys will be purged from the wallet after first unlock with this flag!"`
24	}
25
26	// Validate checks the values configured for our remote RPC signer.
UNCOV 27	func (r *RemoteSigner) Validate() error {	×
UNCOV 28	if !r.Enable {	×
UNCOV 29	return nil	×
UNCOV 30	}	×
31
UNCOV 32	if r.Timeout < time.Millisecond {	×
33	return fmt.Errorf("remote signer: timeout of %v is invalid, "+	×
34	"cannot be smaller than %v", r.Timeout,	×
35	time.Millisecond)	×
36	}	×
37
UNCOV 38	if r.MigrateWatchOnly && !r.Enable {	×
39	return fmt.Errorf("remote signer: cannot turn on wallet " +	×
40	"migration to watch-only if remote signing is not " +	×
41	"enabled")	×
42	}	×
43
UNCOV 44	return nil	×
45	}

lightningnetwork / lnd / 12343072627

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous