fdcd3310-12d3-4e80-823f-8ca1a6a1953a

Committed 17 Dec 2024 10:50PM UTC coverage: 95.739% (-0.7%) from 96.415%

Build # fdcd3310-12d3-4e80-823f-8ca1a6a1953a

Build Type

Pull #4582

circleci

Committed by

web-flow

Commit Message

Merge pull request #4656 from pulibrary/blacklight-8.7.0

bundle update blacklight 8.7.0

Pull Request Pull Request #4582: Blacklight upgrade to 8.6.1

Run Details

9 of 9 new or added lines in 2 files covered. (100.0%)

50 existing lines in 4 files now uncovered.

6022 of 6290 relevant lines covered (95.74%)

1512.76 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

78.57

/app/services/search_service_compatibility_wrapper.rb

# frozen_string_literal: true
# We can remove this service (and just call search_service directly)
# after we migrate to Blacklight 8
# :reek:UncommunicativeVariableName
class SearchServiceCompatibilityWrapper
  def initialize(search_service)
    @search_service = search_service
  end

  # :reek:DuplicateMethodCall
  # :reek:FeatureEnvy
  def fetch(...)
    if Orangelight.using_blacklight7?
      _response, document = search_service.fetch(...)
      document
    else
      search_service.fetch(...)
    end
  end

  # :reek:DuplicateMethodCall
  # :reek:FeatureEnvy
  def search_results(...)
    if Orangelight.using_blacklight7?
      search_service.search_results(...).first
    else
      search_service.search_results(...)
    end
  end

  private

    attr_reader :search_service
end

1	# frozen_string_literal: true
2	# We can remove this service (and just call search_service directly)
3	# after we migrate to Blacklight 8
4	# :reek:UncommunicativeVariableName
5	class SearchServiceCompatibilityWrapper	3✔
6	def initialize(search_service)	3✔
7	@search_service = search_service	83✔
8	end
9
10	# :reek:DuplicateMethodCall
11	# :reek:FeatureEnvy
12	def fetch(...)	3✔
13	if Orangelight.using_blacklight7?	18✔
UNCOV 14	_response, document = search_service.fetch(...)	×
UNCOV 15	document	×
16	else
17	search_service.fetch(...)	18✔
18	end
19	end
20
21	# :reek:DuplicateMethodCall
22	# :reek:FeatureEnvy
23	def search_results(...)	3✔
24	if Orangelight.using_blacklight7?	65✔
UNCOV 25	search_service.search_results(...).first	×
26	else
27	search_service.search_results(...)	65✔
28	end
29	end
30
31	private	3✔
32
33	attr_reader :search_service	3✔
34	end

pulibrary / orangelight / fdcd3310-12d3-4e80-823f-8ca1a6a1953a

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous