12430766295

Committed 20 Dec 2024 11:38AM UTC coverage: 52.607% (-6.1%) from 58.716%

Build # 12430766295

Build Type

Pull #9384

github

Committed by

ziggie1984

Commit Message

funding: refactor gossip msg code

We almost never need to create all messages at the same time
(ChanUpdate,ChanAnnouncement,Proof) so we split it up into own
functions.

Pull Request Pull Request #9384: Refactor gossip msg code

Run Details

224 of 279 new or added lines in 7 files covered. (80.29%)

27070 existing lines in 437 files now uncovered.

53540 of 101773 relevant lines covered (52.61%)

4.11 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

26.67

/feature/required.go

package feature

import (
        "fmt"

        "github.com/lightningnetwork/lnd/lnwire"
)

// ErrUnknownRequired signals that a feature vector requires certain features
// that our node is unaware of or does not implement.
type ErrUnknownRequired struct {
        unknown []lnwire.FeatureBit
}

// NewErrUnknownRequired initializes an ErrUnknownRequired with the unknown
// feature bits.
func NewErrUnknownRequired(unknown []lnwire.FeatureBit) ErrUnknownRequired {
        return ErrUnknownRequired{
                unknown: unknown,
        }
}

// Error returns a human-readable description of the error.
func (e ErrUnknownRequired) Error() string {
        return fmt.Sprintf("feature vector contains unknown required "+
                "features: %v", e.unknown)
}

// ValidateRequired returns an error if the feature vector contains a non-zero
// number of unknown, required feature bits.
func ValidateRequired(fv *lnwire.FeatureVector) error {
        unknown := fv.UnknownRequiredFeatures()
        if len(unknown) > 0 {
                return NewErrUnknownRequired(unknown)
        }
        return nil
}

1	package feature
2
3	import (
4	"fmt"
5
6	"github.com/lightningnetwork/lnd/lnwire"
7	)
8
9	// ErrUnknownRequired signals that a feature vector requires certain features
10	// that our node is unaware of or does not implement.
11	type ErrUnknownRequired struct {
12	unknown []lnwire.FeatureBit
13	}
14
15	// NewErrUnknownRequired initializes an ErrUnknownRequired with the unknown
16	// feature bits.
UNCOV 17	func NewErrUnknownRequired(unknown []lnwire.FeatureBit) ErrUnknownRequired {	×
UNCOV 18	return ErrUnknownRequired{	×
UNCOV 19	unknown: unknown,	×
UNCOV 20	}	×
UNCOV 21	}	×
22
23	// Error returns a human-readable description of the error.
UNCOV 24	func (e ErrUnknownRequired) Error() string {	×
UNCOV 25	return fmt.Sprintf("feature vector contains unknown required "+	×
UNCOV 26	"features: %v", e.unknown)	×
UNCOV 27	}	×
28
29	// ValidateRequired returns an error if the feature vector contains a non-zero
30	// number of unknown, required feature bits.
31	func ValidateRequired(fv *lnwire.FeatureVector) error {	4✔
32	unknown := fv.UnknownRequiredFeatures()	4✔
33	if len(unknown) > 0 {	4✔
UNCOV 34	return NewErrUnknownRequired(unknown)	×
UNCOV 35	}	×
36	return nil	4✔
37	}

lightningnetwork / lnd / 12430766295

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous