12430766295

Committed 20 Dec 2024 11:38AM UTC coverage: 52.607% (-6.1%) from 58.716%

Build # 12430766295

Build Type

Pull #9384

github

Committed by

ziggie1984

Commit Message

funding: refactor gossip msg code

We almost never need to create all messages at the same time
(ChanUpdate,ChanAnnouncement,Proof) so we split it up into own
functions.

Pull Request Pull Request #9384: Refactor gossip msg code

Run Details

224 of 279 new or added lines in 7 files covered. (80.29%)

27070 existing lines in 437 files now uncovered.

53540 of 101773 relevant lines covered (52.61%)

4.11 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

70.0

/netann/sign.go

package netann

import (
        "fmt"

        "github.com/lightningnetwork/lnd/input"
        "github.com/lightningnetwork/lnd/keychain"
        "github.com/lightningnetwork/lnd/lnwallet"
        "github.com/lightningnetwork/lnd/lnwire"
)

// SignAnnouncement signs any type of gossip message that is announced on the
// network.
func SignAnnouncement(signer lnwallet.MessageSigner, keyLoc keychain.KeyLocator,
        msg lnwire.Message) (input.Signature, error) {

        var (
                data []byte
                err  error
        )

        switch m := msg.(type) {
        case *lnwire.ChannelAnnouncement1:
                data, err = m.DataToSign()
        case *lnwire.ChannelUpdate1:
                data, err = m.DataToSign()
        case *lnwire.NodeAnnouncement:
                data, err = m.DataToSign()
        default:
                return nil, fmt.Errorf("can't sign %T message", m)
        }
        if err != nil {
                return nil, fmt.Errorf("unable to get data to sign: %w", err)
        }

        return signer.SignMessage(keyLoc, data, true)
}

1	package netann
2
3	import (
4	"fmt"
5
6	"github.com/lightningnetwork/lnd/input"
7	"github.com/lightningnetwork/lnd/keychain"
8	"github.com/lightningnetwork/lnd/lnwallet"
9	"github.com/lightningnetwork/lnd/lnwire"
10	)
11
12	// SignAnnouncement signs any type of gossip message that is announced on the
13	// network.
14	func SignAnnouncement(signer lnwallet.MessageSigner, keyLoc keychain.KeyLocator,
15	msg lnwire.Message) (input.Signature, error) {	4✔
16		4✔
17	var (	4✔
18	data []byte	4✔
19	err error	4✔
20	)	4✔
21		4✔
22	switch m := msg.(type) {	4✔
UNCOV 23	case *lnwire.ChannelAnnouncement1:	×
UNCOV 24	data, err = m.DataToSign()	×
25	case *lnwire.ChannelUpdate1:	4✔
26	data, err = m.DataToSign()	4✔
27	case *lnwire.NodeAnnouncement:	4✔
28	data, err = m.DataToSign()	4✔
29	default:	×
30	return nil, fmt.Errorf("can't sign %T message", m)	×
31	}
32	if err != nil {	4✔
33	return nil, fmt.Errorf("unable to get data to sign: %w", err)	×
34	}	×
35
36	return signer.SignMessage(keyLoc, data, true)	4✔
37	}

lightningnetwork / lnd / 12430766295

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous