12455509985

Committed 22 Dec 2024 03:28PM CUT coverage: 100.0%. Remained the same

Build # 12455509985

Build Type

push

github

Committed by

web-flow

Commit Message

Deprecate slow methods like `World.Assign` and `World.NewEntityWith` (#441)

The fix in #438 slows these methods down due to more use of reflection. However, their generic counterparts were optimized in #440 to not use any reflection.

Thus, we deprecate the slow, non-generic methods.

* deprecate slow methods Assign and NewEntityWith
* ignore deprecated Assign in generic query tests
* add deprecation node to benchmarks in user guide
* update CHANGELOG

Run Details

6411 of 6411 relevant lines covered (100.0%)

115483.98 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0

/ecs/bitset.go

package ecs

// Data structure for compact storage of booleans.
type bitSet struct {
        data []uint64
}

// Get a value.
func (b *bitSet) Get(bit eid) bool {
        chunk, bit := bit/wordSize, bit%wordSize
        mask := uint64(1 << bit)
        return b.data[chunk]&mask == mask
}

// Set a value.
func (b *bitSet) Set(bit eid, value bool) {
        chunk, bit := bit/wordSize, bit%wordSize
        if value {
                b.data[chunk] |= uint64(1 << bit)
        } else {
                b.data[chunk] &= uint64(^(1 << bit))
        }
}

// Reset all values.
func (b *bitSet) Reset() {
        for i := range b.data {
                b.data[i] = 0
        }
}

// Extend to hold at least the given bits.
func (b *bitSet) ExtendTo(length int) {
        chunks, bit := length/wordSize, length%wordSize
        if bit > 0 {
                chunks++
        }
        if len(b.data) >= chunks {
                return
        }

        old := b.data
        b.data = make([]uint64, chunks)

        copy(b.data, old)
}

1	package ecs
2
3	// Data structure for compact storage of booleans.
4	type bitSet struct {
5	data []uint64
6	}
7
8	// Get a value.
9	func (b *bitSet) Get(bit eid) bool {	3,520,365✔
10	chunk, bit := bit/wordSize, bit%wordSize	3,520,365✔
11	mask := uint64(1 << bit)	3,520,365✔
12	return b.data[chunk]&mask == mask	3,520,365✔
13	}	3,520,365✔
14
15	// Set a value.
16	func (b *bitSet) Set(bit eid, value bool) {	3,827,769✔
17	chunk, bit := bit/wordSize, bit%wordSize	3,827,769✔
18	if value {	3,858,270✔
19	b.data[chunk] \|= uint64(1 << bit)	30,501✔
20	} else {	3,827,769✔
21	b.data[chunk] &= uint64(^(1 << bit))	3,797,268✔
22	}	3,797,268✔
23	}
24
25	// Reset all values.
26	func (b *bitSet) Reset() {	33✔
27	for i := range b.data {	3,900✔
28	b.data[i] = 0	3,867✔
29	}	3,867✔
30	}
31
32	// Extend to hold at least the given bits.
33	func (b *bitSet) ExtendTo(length int) {	39,469✔
34	chunks, bit := length/wordSize, length%wordSize	39,469✔
35	if bit > 0 {	51,173✔
36	chunks++	11,704✔
37	}	11,704✔
38	if len(b.data) >= chunks {	78,499✔
39	return	39,030✔
40	}	39,030✔
41
42	old := b.data	439✔
43	b.data = make([]uint64, chunks)	439✔
44		439✔
45	copy(b.data, old)	439✔
46	}

mlange-42 / arche / 12455509985

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous