2ee2c4fc-5ef0-4806-b86e-01bf70aa67a0

Committed 24 Dec 2024 04:55PM UTC coverage: 91.859% (-0.04%) from 91.902%

Build # 2ee2c4fc-5ef0-4806-b86e-01bf70aa67a0

Build Type

Pull #2569

circleci

Committed by

christinach

Commit Message

Generate new .rubocop_todo.yml
rubocop fix

Pull Request Pull Request #2569: Rubocop gems

Run Details

335 of 378 new or added lines in 57 files covered. (88.62%)

2 existing lines in 2 files now uncovered.

3385 of 3685 relevant lines covered (91.86%)

377.92 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

79.49

/app/controllers/barcode_controller.rb

class BarcodeController < ApplicationController
  include FormattingConcern

  def index
    if params[:barcode]
      redirect_to action: :barcode, barcode: sanitized_barcode, status: :moved_permanently
    else
      render plain: 'Please supply a barcode.', status: :not_found
    end
  end

  # Client: This endpoint is used by the ReCAP inventory management system, LAS,
  #   to pull data from our ILS when items are accessioned
  def scsb
    barcode = params[:barcode]
    if valid_barcode?(barcode)
      adapter = AlmaAdapter.new
      item = adapter.item_by_barcode(barcode)
      mms_id = item['bib_data']['mms_id']
      record = adapter.get_bib_record(mms_id, show_suppressed: true)

      # If the bib record is not found, the returned record will be nil and the controller should return with a 404 status
      if record.nil?
        render plain: "Record #{mms_id} not found", status: :not_found
        return
      end
      holding = adapter.holding_by_id(mms_id:, holding_id: item.holding_data['holding_id'])
      records = if record.linked_record_ids.present?
                  adapter.get_bib_records(record.linked_record_ids)
                else
                  [record]
                end
      records.each do |bib_record|
        bib_record.enrich_with_item(item)
        bib_record.delete_conflicting_holding_data!
        bib_record.enrich_with_holding(holding, recap: true)
        bib_record.strip_non_numeric!
      end
      if records == []
        render plain: "Barcode #{barcode} not found.", status: :not_found
      else
        respond_to do |wants|
          wants.json  do
            json = MultiJson.dump(pass_records_through_xml_parser(records))
            render json:
          end
          wants.xml do
            xml = records_to_xml_string(records)
            render xml:
          end
        end
      end
    else
      render plain: "Barcode #{barcode} not valid.", status: :not_found
    end
  rescue StandardError => e
    handle_alma_exception(exception: e, message: "Error for barcode: #{barcode}")
  end

  private

    def sanitized_barcode
      CGI.escape(params[:barcode])
    end
end

1	class BarcodeController < ApplicationController	1✔
2	include FormattingConcern	1✔
3
4	def index	1✔
5	if params[:barcode]	1✔
6	redirect_to action: :barcode, barcode: sanitized_barcode, status: :moved_permanently	×
7	else
8	render plain: 'Please supply a barcode.', status: :not_found	1✔
9	end
10	end
11
12	# Client: This endpoint is used by the ReCAP inventory management system, LAS,
13	# to pull data from our ILS when items are accessioned
14	def scsb	1✔
15	barcode = params[:barcode]	7✔
16	if valid_barcode?(barcode)	7✔
17	adapter = AlmaAdapter.new	7✔
18	item = adapter.item_by_barcode(barcode)	7✔
19	mms_id = item['bib_data']['mms_id']	5✔
20	record = adapter.get_bib_record(mms_id, show_suppressed: true)	5✔
21
22	# If the bib record is not found, the returned record will be nil and the controller should return with a 404 status
23	if record.nil?	5✔
24	render plain: "Record #{mms_id} not found", status: :not_found	×
25	return	×
26	end
27	holding = adapter.holding_by_id(mms_id:, holding_id: item.holding_data['holding_id'])	5✔
28	records = if record.linked_record_ids.present?	4✔
29	adapter.get_bib_records(record.linked_record_ids)	1✔
30	else
31	[record]	3✔
32	end
33	records.each do \|bib_record\|	4✔
34	bib_record.enrich_with_item(item)	5✔
35	bib_record.delete_conflicting_holding_data!	5✔
36	bib_record.enrich_with_holding(holding, recap: true)	5✔
37	bib_record.strip_non_numeric!	5✔
38	end
39	if records == []	4✔
40	render plain: "Barcode #{barcode} not found.", status: :not_found	×
41	else
42	respond_to do \|wants\|	4✔
43	wants.json do	4✔
44	json = MultiJson.dump(pass_records_through_xml_parser(records))	×
45	render json:	×
46	end
47	wants.xml do	4✔
48	xml = records_to_xml_string(records)	4✔
49	render xml:	4✔
50	end
51	end
52	end
53	else
NEW 54	render plain: "Barcode #{barcode} not valid.", status: :not_found	×
55	end
56	rescue StandardError => e
57	handle_alma_exception(exception: e, message: "Error for barcode: #{barcode}")	3✔
58	end
59
60	private	1✔
61
62	def sanitized_barcode	1✔
63	CGI.escape(params[:barcode])	×
64	end
65	end

pulibrary / bibdata / 2ee2c4fc-5ef0-4806-b86e-01bf70aa67a0

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous