eb4febde-3117-47a7-9176-e4c5c77d5dcf

Committed 24 Dec 2024 06:37PM UTC coverage: 91.87% (-0.03%) from 91.904%

Build # eb4febde-3117-47a7-9176-e4c5c77d5dcf

Build Type

Pull #2563

circleci

Committed by

maxkadel

Commit Message

Change more jobs to be Sidekiq jobs

Pull Request Pull Request #2563: I2321 Shift SCSB full index tasks into separate background jobs

Run Details

132 of 137 new or added lines in 8 files covered. (96.35%)

4 existing lines in 1 file now uncovered.

3458 of 3764 relevant lines covered (91.87%)

370.17 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

80.0

/app/models/scsb/partner_updates/callback.rb

module Scsb
  class PartnerUpdates
    class Callback
      # called by batch.on(:success)
      def on_success(_status, options)
        event = Event.find(options['event_id'])
        event.success = true
        event.save!
        Scsb::PartnerUpdates::Update.generated_date(dump_id: event.dump.id)
      end

      def on_complete(status, options)
        event_id = options['event_id']
        event = Event.find(event_id)
        return unless status.failures != 0
        event.success = false
        event.error << "Sidekiq batch: #{status.bid} completed with errors for event_id: #{event_id}"
        event.save!
      end
    end
  end
end

1	module Scsb	1✔
2	class PartnerUpdates	1✔
3	class Callback	1✔
4	# called by batch.on(:success)
5	def on_success(_status, options)	1✔
6	event = Event.find(options['event_id'])	1✔
7	event.success = true	1✔
8	event.save!	1✔
9	Scsb::PartnerUpdates::Update.generated_date(dump_id: event.dump.id)	1✔
10	end
11
12	def on_complete(status, options)	1✔
13	event_id = options['event_id']	1✔
14	event = Event.find(event_id)	1✔
15	return unless status.failures != 0	1✔
NEW 16	event.success = false	×
NEW 17	event.error << "Sidekiq batch: #{status.bid} completed with errors for event_id: #{event_id}"	×
NEW 18	event.save!	×
19	end
20	end
21	end
22	end

pulibrary / bibdata / eb4febde-3117-47a7-9176-e4c5c77d5dcf

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous