5db7f693-1ba8-464b-88d6-caaa168a35c8

Committed 30 Dec 2024 07:22PM UTC coverage: 91.223% (-0.6%) from 91.859%

Build # 5db7f693-1ba8-464b-88d6-caaa168a35c8

Build Type

Pull #2563

circleci

Committed by

maxkadel

Commit Message

Rubocop

Pull Request Pull Request #2563: I2321 Shift SCSB full index tasks into separate background jobs

Run Details

134 of 163 new or added lines in 10 files covered. (82.21%)

5 existing lines in 1 file now uncovered.

3461 of 3794 relevant lines covered (91.22%)

366.61 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

53.33

/app/models/scsb/partner_updates/callback.rb

module Scsb
  class PartnerUpdates
    class Callback
      # called by batch.on(:success)
      def on_success(_status, options)
        event = Event.find(options['event_id'])
        event.success = true
        event.save!
        Scsb::PartnerUpdates::Update.generated_date(dump_id: event.dump.id)
      end

      def on_complete(status, options)
        event_id = options['event_id']
        event = Event.find(event_id)
        return unless status.failures != 0

        event.success = false
        event.error << "Sidekiq batch: #{status.bid} completed with errors for event_id: #{event_id}"
        event.save!
      end
    end
  end
end

1	module Scsb	1✔
2	class PartnerUpdates	1✔
3	class Callback	1✔
4	# called by batch.on(:success)
5	def on_success(_status, options)	1✔
NEW 6	event = Event.find(options['event_id'])	×
NEW 7	event.success = true	×
NEW 8	event.save!	×
NEW 9	Scsb::PartnerUpdates::Update.generated_date(dump_id: event.dump.id)	×
10	end
11
12	def on_complete(status, options)	1✔
13	event_id = options['event_id']	1✔
14	event = Event.find(event_id)	1✔
15	return unless status.failures != 0	1✔
16
NEW 17	event.success = false	×
NEW 18	event.error << "Sidekiq batch: #{status.bid} completed with errors for event_id: #{event_id}"	×
NEW 19	event.save!	×
20	end
21	end
22	end
23	end

pulibrary / bibdata / 5db7f693-1ba8-464b-88d6-caaa168a35c8

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous