12583319996

Committed 02 Jan 2025 01:38PM UTC coverage: 57.522% (-1.1%) from 58.598%

Build # 12583319996

Build Type

Pull #9361

github

Committed by

starius

Commit Message

fn/ContextGuard: use context.AfterFunc to wait

Simplifies context cancellation handling by using context.AfterFunc instead of a
goroutine to wait for context cancellation. This approach avoids the overhead of
a goroutine during the waiting period.

For ctxQuitUnsafe, since g.quit is closed only in the Quit method (which also
cancels all associated contexts), waiting on context cancellation ensures the
same behavior without unnecessary dependency on g.quit.

Added a test to ensure that the Create method does not launch any goroutines.

Pull Request Pull Request #9361: fn: optimize context guard

Run Details

102587 of 178344 relevant lines covered (57.52%)

24734.33 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/lncfg/routing.go

package lncfg

import "fmt"

// Routing holds the configuration options for routing.
//
//nolint:ll
type Routing struct {
        AssumeChannelValid bool `long:"assumechanvalid" description:"DEPRECATED: Skip checking channel spentness during graph validation. This speedup comes at the risk of using an unvalidated view of the network for routing. (default: false)" hidden:"true"`

        StrictZombiePruning bool `long:"strictgraphpruning" description:"If true, then the graph will be pruned more aggressively for zombies. In practice this means that edges with a single stale edge will be considered a zombie."`

        BlindedPaths BlindedPaths `group:"blinding" namespace:"blinding"`
}

// BlindedPaths holds the configuration options for blinded path construction.
//
//nolint:ll
type BlindedPaths struct {
        MinNumRealHops           uint8   `long:"min-num-real-hops" description:"The minimum number of real hops to include in a blinded path. This doesn't include our node, so if the minimum is 1, then the path will contain at minimum our node along with an introduction node hop. If it is zero then the shortest path will use our node as an introduction node."`
        NumHops                  uint8   `long:"num-hops" description:"The number of hops to include in a blinded path. This doesn't include our node, so if it is 1, then the path will contain our node along with an introduction node or dummy node hop. If paths shorter than NumHops is found, then they will be padded using dummy hops."`
        MaxNumPaths              uint8   `long:"max-num-paths" description:"The maximum number of blinded paths to select and add to an invoice."`
        PolicyIncreaseMultiplier float64 `long:"policy-increase-multiplier" description:"The amount by which to increase certain policy values of hops on a blinded path in order to add a probing buffer."`
        PolicyDecreaseMultiplier float64 `long:"policy-decrease-multiplier" description:"The amount by which to decrease certain policy values of hops on a blinded path in order to add a probing buffer."`
}

// Validate checks that the various routing config options are sane.
//
// NOTE: this is part of the Validator interface.
func (r *Routing) Validate() error {
        if r.BlindedPaths.MinNumRealHops > r.BlindedPaths.NumHops {
                return fmt.Errorf("the minimum number of real hops in a " +
                        "blinded path must be smaller than or equal to the " +
                        "number of hops expected to be included in each path")
        }

        if r.BlindedPaths.PolicyIncreaseMultiplier < 1 {
                return fmt.Errorf("the blinded route policy increase " +
                        "multiplier must be greater than or equal to 1")
        }

        if r.BlindedPaths.PolicyDecreaseMultiplier > 1 ||
                r.BlindedPaths.PolicyDecreaseMultiplier < 0 {

                return fmt.Errorf("the blinded route policy decrease " +
                        "multiplier must be in the range (0,1]")
        }

        return nil
}

1	package lncfg
2
3	import "fmt"
4
5	// Routing holds the configuration options for routing.
6	//
7	//nolint:ll
8	type Routing struct {
9	AssumeChannelValid bool `long:"assumechanvalid" description:"DEPRECATED: Skip checking channel spentness during graph validation. This speedup comes at the risk of using an unvalidated view of the network for routing. (default: false)" hidden:"true"`
10
11	StrictZombiePruning bool `long:"strictgraphpruning" description:"If true, then the graph will be pruned more aggressively for zombies. In practice this means that edges with a single stale edge will be considered a zombie."`
12
13	BlindedPaths BlindedPaths `group:"blinding" namespace:"blinding"`
14	}
15
16	// BlindedPaths holds the configuration options for blinded path construction.
17	//
18	//nolint:ll
19	type BlindedPaths struct {
20	MinNumRealHops uint8 `long:"min-num-real-hops" description:"The minimum number of real hops to include in a blinded path. This doesn't include our node, so if the minimum is 1, then the path will contain at minimum our node along with an introduction node hop. If it is zero then the shortest path will use our node as an introduction node."`
21	NumHops uint8 `long:"num-hops" description:"The number of hops to include in a blinded path. This doesn't include our node, so if it is 1, then the path will contain our node along with an introduction node or dummy node hop. If paths shorter than NumHops is found, then they will be padded using dummy hops."`
22	MaxNumPaths uint8 `long:"max-num-paths" description:"The maximum number of blinded paths to select and add to an invoice."`
23	PolicyIncreaseMultiplier float64 `long:"policy-increase-multiplier" description:"The amount by which to increase certain policy values of hops on a blinded path in order to add a probing buffer."`
24	PolicyDecreaseMultiplier float64 `long:"policy-decrease-multiplier" description:"The amount by which to decrease certain policy values of hops on a blinded path in order to add a probing buffer."`
25	}
26
27	// Validate checks that the various routing config options are sane.
28	//
29	// NOTE: this is part of the Validator interface.
30	func (r *Routing) Validate() error {	×
31	if r.BlindedPaths.MinNumRealHops > r.BlindedPaths.NumHops {	×
32	return fmt.Errorf("the minimum number of real hops in a " +	×
33	"blinded path must be smaller than or equal to the " +	×
34	"number of hops expected to be included in each path")	×
35	}	×
36
37	if r.BlindedPaths.PolicyIncreaseMultiplier < 1 {	×
38	return fmt.Errorf("the blinded route policy increase " +	×
39	"multiplier must be greater than or equal to 1")	×
40	}	×
41
42	if r.BlindedPaths.PolicyDecreaseMultiplier > 1 \|\|	×
43	r.BlindedPaths.PolicyDecreaseMultiplier < 0 {	×
44		×
45	return fmt.Errorf("the blinded route policy decrease " +	×
46	"multiplier must be in the range (0,1]")	×
47	}	×
48
49	return nil	×
50	}

lightningnetwork / lnd / 12583319996

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous