12583319996

Committed 02 Jan 2025 01:38PM UTC coverage: 57.522% (-1.1%) from 58.598%

Build # 12583319996

Build Type

Pull #9361

github

Committed by

starius

Commit Message

fn/ContextGuard: use context.AfterFunc to wait

Simplifies context cancellation handling by using context.AfterFunc instead of a
goroutine to wait for context cancellation. This approach avoids the overhead of
a goroutine during the waiting period.

For ctxQuitUnsafe, since g.quit is closed only in the Quit method (which also
cancels all associated contexts), waiting on context cancellation ensures the
same behavior without unnecessary dependency on g.quit.

Added a test to ensure that the Create method does not launch any goroutines.

Pull Request Pull Request #9361: fn: optimize context guard

Run Details

102587 of 178344 relevant lines covered (57.52%)

24734.33 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/lnwallet/rpcwallet/healthcheck.go

package rpcwallet

import (
        "fmt"
        "time"

        "github.com/lightningnetwork/lnd/lncfg"
)

// HealthCheck returns a health check function for the given remote signing
// configuration.
func HealthCheck(cfg *lncfg.RemoteSigner, timeout time.Duration) func() error {
        return func() error {
                conn, err := connectRPC(
                        cfg.RPCHost, cfg.TLSCertPath, cfg.MacaroonPath, timeout,
                )
                if err != nil {
                        return fmt.Errorf("error connecting to the remote "+
                                "signing node through RPC: %v", err)
                }

                defer func() {
                        err = conn.Close()
                        if err != nil {
                                log.Warnf("Failed to close health check "+
                                        "connection to remote signing node: %v",
                                        err)
                        }
                }()

                return nil
        }
}

1	package rpcwallet
2
3	import (
4	"fmt"
5	"time"
6
7	"github.com/lightningnetwork/lnd/lncfg"
8	)
9
10	// HealthCheck returns a health check function for the given remote signing
11	// configuration.
12	func HealthCheck(cfg *lncfg.RemoteSigner, timeout time.Duration) func() error {	×
13	return func() error {	×
14	conn, err := connectRPC(	×
15	cfg.RPCHost, cfg.TLSCertPath, cfg.MacaroonPath, timeout,	×
16	)	×
17	if err != nil {	×
18	return fmt.Errorf("error connecting to the remote "+	×
19	"signing node through RPC: %v", err)	×
20	}	×
21
22	defer func() {	×
23	err = conn.Close()	×
24	if err != nil {	×
25	log.Warnf("Failed to close health check "+	×
26	"connection to remote signing node: %v",	×
27	err)	×
28	}	×
29	}()
30
31	return nil	×
32	}
33	}

lightningnetwork / lnd / 12583319996

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous