9c0e7611-27ad-4f98-84d9-d19b8b320fbe

Committed 08 Jan 2025 03:48PM CUT coverage: 85.084%. Remained the same

Build # 9c0e7611-27ad-4f98-84d9-d19b8b320fbe

Build Type

Pull #5296

circleci

Committed by

jwhitlock

Commit Message

Use @typescript-eslint/typescript-estree@8.19.1

Avoid the CI test_frontend lint warning:

WARNING: You are currently running a version of TypeScript which is not
officially supported by @typescript-eslint/typescript-estree.

The stricted nested dependency is @typescript-eslint/parser, so sync
on its version by using @typescript-eslint/eslint-plugin 8.19.1

1) Add "overrides" to package.json:

{
  "overrides": {
    "eslint-config-next": {
      "@typescript-eslint/eslint-plugin": "8.19.1"
    },
    "eslint-plugin-testing-library": {
      "@typescript-eslint/eslint-plugin": "8.19.1"
    }
  },
}

2) Uninstall and reinstall

npm uninstall --workspace frontend eslint-plugin-testing-library
npm install --workspace frontend -D eslint-plugin-testing-library@7.1.1
npm uninstall --workspace frontend eslint-config-next
npm install --workspace frontend -D eslint-config-next@15.1.3

Verify that frontend/package.json did not change.

3) Revert package.json to remove overrides

4) Confirm same version is used everywhere:

npm list @typescript-eslint/typescript-estree

5) Commit package-lock.json

Pull Request Pull Request #5296: Bump typescript from 5.4.5 to 5.7.2

Run Details

2433 of 3561 branches covered (68.32%)

Branch coverage included in aggregate %.

16995 of 19273 relevant lines covered (88.18%)

9.92 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/emails/admin.py

1	from django.contrib import admin	×
2
3	from .models import DeletedAddress, DomainAddress, RelayAddress, Reply	×
4
5
6	@admin.register(Reply)	×
7	class ReplyAdmin(admin.ModelAdmin):	×
8	readonly_fields = ("created_at",)	×
9	list_display = ("relay_address", "domain_address", "created_at")	×
10
11
12	admin.site.register(DeletedAddress)	×
13	admin.site.register(RelayAddress)	×
14	admin.site.register(DomainAddress)	×

mozilla / fx-private-relay / 9c0e7611-27ad-4f98-84d9-d19b8b320fbe

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous