9c0e7611-27ad-4f98-84d9-d19b8b320fbe

Committed 08 Jan 2025 03:48PM CUT coverage: 85.084%. Remained the same

Build # 9c0e7611-27ad-4f98-84d9-d19b8b320fbe

Build Type

Pull #5296

circleci

Committed by

jwhitlock

Commit Message

Use @typescript-eslint/typescript-estree@8.19.1

Avoid the CI test_frontend lint warning:

WARNING: You are currently running a version of TypeScript which is not
officially supported by @typescript-eslint/typescript-estree.

The stricted nested dependency is @typescript-eslint/parser, so sync
on its version by using @typescript-eslint/eslint-plugin 8.19.1

1) Add "overrides" to package.json:

{
  "overrides": {
    "eslint-config-next": {
      "@typescript-eslint/eslint-plugin": "8.19.1"
    },
    "eslint-plugin-testing-library": {
      "@typescript-eslint/eslint-plugin": "8.19.1"
    }
  },
}

2) Uninstall and reinstall

npm uninstall --workspace frontend eslint-plugin-testing-library
npm install --workspace frontend -D eslint-plugin-testing-library@7.1.1
npm uninstall --workspace frontend eslint-config-next
npm install --workspace frontend -D eslint-config-next@15.1.3

Verify that frontend/package.json did not change.

3) Revert package.json to remove overrides

4) Confirm same version is used everywhere:

npm list @typescript-eslint/typescript-estree

5) Commit package-lock.json

Pull Request Pull Request #5296: Bump typescript from 5.4.5 to 5.7.2

Run Details

2433 of 3561 branches covered (68.32%)

Branch coverage included in aggregate %.

16995 of 19273 relevant lines covered (88.18%)

9.92 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/emails/management/commands/delete_old_reply_records.py

from datetime import UTC, datetime, timedelta

from django.core.management.base import BaseCommand
from django.db import transaction

from ...models import Reply


class Command(BaseCommand):
    help = "Deletes all Reply objects older than 3 months."

    def add_arguments(self, parser):
        parser.add_argument("days_old", nargs=1, type=int)

    def handle(self, *args, **options):
        delete_date = datetime.now(UTC) - timedelta(options["days_old"][0])
        replies_to_delete = Reply.objects.filter(created_at__lt=delete_date).only("id")
        print(
            f"Deleting {len(replies_to_delete)} reply records "
            f"older than {delete_date}"
        )
        with transaction.atomic():
            replies_to_delete.delete()

1	from datetime import UTC, datetime, timedelta	×
2
3	from django.core.management.base import BaseCommand	×
4	from django.db import transaction	×
5
6	from ...models import Reply	×
7
8
9	class Command(BaseCommand):	×
10	help = "Deletes all Reply objects older than 3 months."	×
11
12	def add_arguments(self, parser):	×
13	parser.add_argument("days_old", nargs=1, type=int)	×
14
15	def handle(self, args, *options):	×
16	delete_date = datetime.now(UTC) - timedelta(options["days_old"][0])	×
17	replies_to_delete = Reply.objects.filter(created_at__lt=delete_date).only("id")	×
18	print(	×
19	f"Deleting {len(replies_to_delete)} reply records "
20	f"older than {delete_date}"
21	)
22	with transaction.atomic():	×
23	replies_to_delete.delete()	×

mozilla / fx-private-relay / 9c0e7611-27ad-4f98-84d9-d19b8b320fbe

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous