9c0e7611-27ad-4f98-84d9-d19b8b320fbe

Committed 08 Jan 2025 03:48PM CUT coverage: 85.084%. Remained the same

Build # 9c0e7611-27ad-4f98-84d9-d19b8b320fbe

Build Type

Pull #5296

circleci

Committed by

jwhitlock

Commit Message

Use @typescript-eslint/typescript-estree@8.19.1

Avoid the CI test_frontend lint warning:

WARNING: You are currently running a version of TypeScript which is not
officially supported by @typescript-eslint/typescript-estree.

The stricted nested dependency is @typescript-eslint/parser, so sync
on its version by using @typescript-eslint/eslint-plugin 8.19.1

1) Add "overrides" to package.json:

{
  "overrides": {
    "eslint-config-next": {
      "@typescript-eslint/eslint-plugin": "8.19.1"
    },
    "eslint-plugin-testing-library": {
      "@typescript-eslint/eslint-plugin": "8.19.1"
    }
  },
}

2) Uninstall and reinstall

npm uninstall --workspace frontend eslint-plugin-testing-library
npm install --workspace frontend -D eslint-plugin-testing-library@7.1.1
npm uninstall --workspace frontend eslint-config-next
npm install --workspace frontend -D eslint-config-next@15.1.3

Verify that frontend/package.json did not change.

3) Revert package.json to remove overrides

4) Confirm same version is used everywhere:

npm list @typescript-eslint/typescript-estree

5) Commit package-lock.json

Pull Request Pull Request #5296: Bump typescript from 5.4.5 to 5.7.2

Run Details

2433 of 3561 branches covered (68.32%)

Branch coverage included in aggregate %.

16995 of 19273 relevant lines covered (88.18%)

9.92 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/emails/management/commands/get_latest_email_tracker_lists.py

import pathlib

from django.core.management.base import BaseCommand

from emails.utils import download_trackers, shavar_prod_lists_url, store_trackers

EMAILS_FOLDER_PATH = pathlib.Path(__file__).parents[2]
TRACKER_FOLDER_PATH = EMAILS_FOLDER_PATH / "tracker_lists"


class Command(BaseCommand):
    help = "Fetch and store email tracker lists from Shavar Prod List repository"

    def add_arguments(self, parser):
        parser.add_argument(
            "--repo-url",
            default=shavar_prod_lists_url,
            help="Set url that the email tracker lists will be pulled from",
        )
        parser.add_argument(
            "--tracker-level",
            default=1,
            type=int,
            choices=[1, 2],
            help="Choose the level of tracker list desired",
        )

    def handle(self, *args, **options):
        repo_url = options["repo_url"]
        tracker_level = options["tracker_level"]

        category = "Email"
        tracker_list_name = "level-one-trackers"
        if tracker_level == 2:
            category = "EmailAggressive"
            tracker_list_name = "level-two-trackers"

        trackers = download_trackers(repo_url, category)
        file_name = f"{tracker_list_name}.json"

        store_trackers(trackers, TRACKER_FOLDER_PATH, file_name)
        print(f"Added {file_name} in {TRACKER_FOLDER_PATH}")

1	import pathlib	×
2
3	from django.core.management.base import BaseCommand	×
4
5	from emails.utils import download_trackers, shavar_prod_lists_url, store_trackers	×
6
7	EMAILS_FOLDER_PATH = pathlib.Path(__file__).parents[2]	×
8	TRACKER_FOLDER_PATH = EMAILS_FOLDER_PATH / "tracker_lists"	×
9
10
11	class Command(BaseCommand):	×
12	help = "Fetch and store email tracker lists from Shavar Prod List repository"	×
13
14	def add_arguments(self, parser):	×
15	parser.add_argument(	×
16	"--repo-url",
17	default=shavar_prod_lists_url,
18	help="Set url that the email tracker lists will be pulled from",
19	)
20	parser.add_argument(	×
21	"--tracker-level",
22	default=1,
23	type=int,
24	choices=[1, 2],
25	help="Choose the level of tracker list desired",
26	)
27
28	def handle(self, args, *options):	×
29	repo_url = options["repo_url"]	×
30	tracker_level = options["tracker_level"]	×
31
32	category = "Email"	×
33	tracker_list_name = "level-one-trackers"	×
34	if tracker_level == 2:	×
35	category = "EmailAggressive"	×
36	tracker_list_name = "level-two-trackers"	×
37
38	trackers = download_trackers(repo_url, category)	×
39	file_name = f"{tracker_list_name}.json"	×
40
41	store_trackers(trackers, TRACKER_FOLDER_PATH, file_name)	×
42	print(f"Added {file_name} in {TRACKER_FOLDER_PATH}")	×

mozilla / fx-private-relay / 9c0e7611-27ad-4f98-84d9-d19b8b320fbe

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous