• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

mozilla / fx-private-relay / 9c0e7611-27ad-4f98-84d9-d19b8b320fbe

08 Jan 2025 03:48PM CUT coverage: 85.084%. Remained the same
9c0e7611-27ad-4f98-84d9-d19b8b320fbe

Pull #5296

circleci

jwhitlock
Use @typescript-eslint/typescript-estree@8.19.1

Avoid the CI test_frontend lint warning:

WARNING: You are currently running a version of TypeScript which is not
officially supported by @typescript-eslint/typescript-estree.

The stricted nested dependency is @typescript-eslint/parser, so sync
on its version by using @typescript-eslint/eslint-plugin 8.19.1

1) Add "overrides" to package.json:

{
  "overrides": {
    "eslint-config-next": {
      "@typescript-eslint/eslint-plugin": "8.19.1"
    },
    "eslint-plugin-testing-library": {
      "@typescript-eslint/eslint-plugin": "8.19.1"
    }
  },
}

2) Uninstall and reinstall

npm uninstall --workspace frontend eslint-plugin-testing-library
npm install --workspace frontend -D eslint-plugin-testing-library@7.1.1
npm uninstall --workspace frontend eslint-config-next
npm install --workspace frontend -D eslint-config-next@15.1.3

Verify that frontend/package.json did not change.

3) Revert package.json to remove overrides

4) Confirm same version is used everywhere:

npm list @typescript-eslint/typescript-estree

5) Commit package-lock.json
Pull Request #5296: Bump typescript from 5.4.5 to 5.7.2

2433 of 3561 branches covered (68.32%)

Branch coverage included in aggregate %.

16995 of 19273 relevant lines covered (88.18%)

9.92 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0
/frontend/src/components/ReactAriaI18nProvider.tsx
1
import { ReactChild } from "react";
2
import { I18nProvider } from "react-aria";
×
3
import { getLocale } from "../functions/getLocale";
×
4
import { useL10n } from "../hooks/l10n";
×
5

6
/**
7
 * React-aria has some components (e.g. `<DismissButton>`) that include their
8
 * own strings. This component ensures that they use the same locale as the
9
 * rest of the application does.
10
 */
11
export const ReactAriaI18nProvider = (props: { children: ReactChild }) => {
×
12
  const l10n = useL10n();
×
13
  const locale = getLocale(l10n);
×
14

15
  return <I18nProvider locale={locale}>{props.children}</I18nProvider>;
16
};
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc