1622978334

Committed 13 Jan 2025 03:51PM UTC coverage: 72.802% (-3.8%) from 76.608%

Build # 1622978334

Build Type

Pull #300

gitlab-ci

Committed by

alfrunes

Commit Message

fix: Deployment device count should not exceed max devices

Added a condition to skip deployments when the device count reaches max
devices.

Changelog: Title
Ticket: MEN-7847
Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>

Pull Request Pull Request #300: fix: Deployment device count should not exceed max devices

Run Details

4251 of 6164 branches covered (68.96%)

Branch coverage included in aggregate %.

0 of 18 new or added lines in 1 file covered. (0.0%)

2544 existing lines in 83 files now uncovered.

42741 of 58384 relevant lines covered (73.21%)

21.49 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

51.61

/backend/services/useradm/api/http/middleware.go

// Copyright 2021 Northern.tech AS
//
//        Licensed under the Apache License, Version 2.0 (the "License");
//        you may not use this file except in compliance with the License.
//        You may obtain a copy of the License at
//
//            http://www.apache.org/licenses/LICENSE-2.0
//
//        Unless required by applicable law or agreed to in writing, software
//        distributed under the License is distributed on an "AS IS" BASIS,
//        WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//        See the License for the specific language governing permissions and
//        limitations under the License.
package http

import (
        "errors"
        "net/http"
        "strings"

        "github.com/ant0ine/go-json-rest/rest"

        "github.com/mendersoftware/mender-server/services/useradm/authz"
)

func IsVerificationEndpoint(r *rest.Request) bool {
        if r.URL.Path == uriInternalAuthVerify &&
                (r.Method == http.MethodPost || r.Method == http.MethodGet) {
                return true
        } else {
                return false
        }
}

// ExtractResourceAction extracts resource action from the request url
func ExtractResourceAction(r *rest.Request) (*authz.Action, error) {
        action := authz.Action{}

        // extract original uri
        uri := r.Header.Get("X-Forwarded-Uri")
        if uri == "" {
                uri = r.Header.Get("X-Forwarded-URI")
        }
        uriItems := strings.Split(uri, "/")

        if uri == "" || len(uriItems) < 4 {
                return nil, errors.New("can't parse service name from original uri " + uri)
        }

        action.Resource = strings.Join(uriItems[4:], ":")

        // extract original http method
        action.Method = r.Header.Get("X-Forwarded-Method")
        if action.Method == "" {
                action.Method = r.Header.Get("X-Forwarded-Method")
        }
        if action.Method == "" {
                return nil, errors.New("can't parse original request method")
        }

        return &action, nil
}

1	// Copyright 2021 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14	package http
15
16	import (
17	"errors"
18	"net/http"
19	"strings"
20
21	"github.com/ant0ine/go-json-rest/rest"
22
23	"github.com/mendersoftware/mender-server/services/useradm/authz"
24	)
25
26	func IsVerificationEndpoint(r *rest.Request) bool {	×
27	if r.URL.Path == uriInternalAuthVerify &&	×
28	(r.Method == http.MethodPost \|\| r.Method == http.MethodGet) {	×
29	return true	×
30	} else {	×
31	return false	×
32	}	×
33	}
34
35	// ExtractResourceAction extracts resource action from the request url
36	func ExtractResourceAction(r rest.Request) (authz.Action, error) {	1✔
37	action := authz.Action{}	1✔
38		1✔
39	// extract original uri	1✔
40	uri := r.Header.Get("X-Forwarded-Uri")	1✔
41	if uri == "" {	1✔
42	uri = r.Header.Get("X-Forwarded-URI")	×
43	}	×
44	uriItems := strings.Split(uri, "/")	1✔
45		1✔
46	if uri == "" \|\| len(uriItems) < 4 {	1✔
UNCOV 47	return nil, errors.New("can't parse service name from original uri " + uri)	×
UNCOV 48	}	×
49
50	action.Resource = strings.Join(uriItems[4:], ":")	1✔
51		1✔
52	// extract original http method	1✔
53	action.Method = r.Header.Get("X-Forwarded-Method")	1✔
54	if action.Method == "" {	1✔
55	action.Method = r.Header.Get("X-Forwarded-Method")	×
56	}	×
57	if action.Method == "" {	1✔
58	return nil, errors.New("can't parse original request method")	×
59	}	×
60
61	return &action, nil	1✔
62	}

mendersoftware / mender-server / 1622978334

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous