1622978334

Committed 13 Jan 2025 03:51PM UTC coverage: 72.802% (-3.8%) from 76.608%

Build # 1622978334

Build Type

Pull #300

gitlab-ci

Committed by

alfrunes

Commit Message

fix: Deployment device count should not exceed max devices

Added a condition to skip deployments when the device count reaches max
devices.

Changelog: Title
Ticket: MEN-7847
Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>

Pull Request Pull Request #300: fix: Deployment device count should not exceed max devices

Run Details

4251 of 6164 branches covered (68.96%)

Branch coverage included in aggregate %.

0 of 18 new or added lines in 1 file covered. (0.0%)

2544 existing lines in 83 files now uncovered.

42741 of 58384 relevant lines covered (73.21%)

21.49 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

91.3

/backend/services/useradm/utils/similar_checker.go

package utils

import (
        "strings"

        "github.com/mendersoftware/mender-server/services/useradm/model"
)

func CheckIfPassSimilarToEmailRaw(mail string, pass string) bool {
        if len(mail) == 0 || len(pass) == 0 {
                return false
        }
        lmail := strings.ToLower(mail)
        lpass := strings.ToLower(pass)
        return strings.Contains(lmail, lpass)
}
func CheckIfPassSimilarToEmail(user *model.User, userUpdate *model.UserUpdate) bool {
        if len(userUpdate.Password) > 0 {
                pwd := userUpdate.Password
                // Check if similar to updated email
                if userUpdate.Email != "" &&
                        CheckIfPassSimilarToEmailRaw(string(userUpdate.Email), pwd) {
                        return true
                }
                // Check if similar to (old) email
                return CheckIfPassSimilarToEmailRaw(string(user.Email), pwd)
        } else if len(userUpdate.Email) > 0 {
                // check when changing the email
                return CheckIfPassSimilarToEmailRaw(
                        string(userUpdate.Email),
                        userUpdate.CurrentPassword)
        }
        return false
}

1	package utils
2
3	import (
4	"strings"
5
6	"github.com/mendersoftware/mender-server/services/useradm/model"
7	)
8
9	func CheckIfPassSimilarToEmailRaw(mail string, pass string) bool {	3✔
10	if len(mail) == 0 \|\| len(pass) == 0 {	3✔
UNCOV 11	return false	×
UNCOV 12	}	×
13	lmail := strings.ToLower(mail)	3✔
14	lpass := strings.ToLower(pass)	3✔
15	return strings.Contains(lmail, lpass)	3✔
16	}
17	func CheckIfPassSimilarToEmail(user model.User, userUpdate model.UserUpdate) bool {	2✔
18	if len(userUpdate.Password) > 0 {	4✔
19	pwd := userUpdate.Password	2✔
20	// Check if similar to updated email	2✔
21	if userUpdate.Email != "" &&	2✔
22	CheckIfPassSimilarToEmailRaw(string(userUpdate.Email), pwd) {	3✔
23	return true	1✔
24	}	1✔
25	// Check if similar to (old) email
26	return CheckIfPassSimilarToEmailRaw(string(user.Email), pwd)	2✔
27	} else if len(userUpdate.Email) > 0 {	2✔
28	// check when changing the email	1✔
29	return CheckIfPassSimilarToEmailRaw(	1✔
30	string(userUpdate.Email),	1✔
31	userUpdate.CurrentPassword)	1✔
32	}	1✔
33	return false	1✔
34	}

mendersoftware / mender-server / 1622978334

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous