13035292482

Committed 29 Jan 2025 03:59PM UTC coverage: 49.3% (-9.5%) from 58.777%

Build # 13035292482

Build Type

Pull #9456

github

Committed by

mohamedawnallah

Commit Message

docs: update release-notes-0.19.0.md

In this commit, we warn users about the removal
of RPCs `SendToRoute`, `SendToRouteSync`, `SendPayment`,
and `SendPaymentSync` in the next release 0.20.

Pull Request Pull Request #9456: lnrpc+docs: deprecate warning `SendToRoute`, `SendToRouteSync`, `SendPayment`, and `SendPaymentSync` in Release 0.19

Run Details

100634 of 204126 relevant lines covered (49.3%)

1.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/chainntnfs/bitcoindnotify/bitcoind_dev.go

//go:build dev
// +build dev

package bitcoindnotify

import (
        "fmt"
        "time"

        "github.com/btcsuite/btcd/chaincfg/chainhash"
        "github.com/btcsuite/btcwallet/chain"
        "github.com/lightningnetwork/lnd/chainntnfs"
)

// UnsafeStart starts the notifier with a specified best height and optional
// best hash. Its bestBlock and txNotifier are initialized with bestHeight and
// optionally bestHash. The parameter generateBlocks is necessary for the
// bitcoind notifier to ensure we drain all notifications up to syncHeight,
// since if they are generated ahead of UnsafeStart the chainConn may start up
// with an outdated best block and miss sending ntfns. Used for testing.
func (b *BitcoindNotifier) UnsafeStart(bestHeight int32, bestHash *chainhash.Hash,
        syncHeight int32, generateBlocks func() error) error {

        // Connect to bitcoind, and register for notifications on connected,
        // and disconnected blocks.
        if err := b.chainConn.Start(); err != nil {
                return err
        }
        if err := b.chainConn.NotifyBlocks(); err != nil {
                return err
        }

        b.txNotifier = chainntnfs.NewTxNotifier(
                uint32(bestHeight), chainntnfs.ReorgSafetyLimit,
                b.confirmHintCache, b.spendHintCache,
        )

        if generateBlocks != nil {
                // Ensure no block notifications are pending when we start the
                // notification dispatcher goroutine.

                // First generate the blocks, then drain the notifications
                // for the generated blocks.
                if err := generateBlocks(); err != nil {
                        return err
                }

                timeout := time.After(60 * time.Second)
        loop:
                for {
                        select {
                        case ntfn := <-b.chainConn.Notifications():
                                switch update := ntfn.(type) {
                                case chain.BlockConnected:
                                        if update.Height >= syncHeight {
                                                break loop
                                        }
                                }
                        case <-timeout:
                                return fmt.Errorf("unable to catch up to height %d",
                                        syncHeight)
                        }
                }
        }

        // Run notificationDispatcher after setting the notifier's best block
        // to avoid a race condition.
        b.bestBlock = chainntnfs.BlockEpoch{Height: bestHeight, Hash: bestHash}
        if bestHash == nil {
                hash, err := b.chainConn.GetBlockHash(int64(bestHeight))
                if err != nil {
                        return err
                }
                b.bestBlock.Hash = hash
        }

        b.wg.Add(1)
        go b.notificationDispatcher()

        return nil
}

1	//go:build dev
2	// +build dev
3
4	package bitcoindnotify
5
6	import (
7	"fmt"
8	"time"
9
10	"github.com/btcsuite/btcd/chaincfg/chainhash"
11	"github.com/btcsuite/btcwallet/chain"
12	"github.com/lightningnetwork/lnd/chainntnfs"
13	)
14
15	// UnsafeStart starts the notifier with a specified best height and optional
16	// best hash. Its bestBlock and txNotifier are initialized with bestHeight and
17	// optionally bestHash. The parameter generateBlocks is necessary for the
18	// bitcoind notifier to ensure we drain all notifications up to syncHeight,
19	// since if they are generated ahead of UnsafeStart the chainConn may start up
20	// with an outdated best block and miss sending ntfns. Used for testing.
21	func (b BitcoindNotifier) UnsafeStart(bestHeight int32, bestHash chainhash.Hash,
22	syncHeight int32, generateBlocks func() error) error {	×
23		×
24	// Connect to bitcoind, and register for notifications on connected,	×
25	// and disconnected blocks.	×
26	if err := b.chainConn.Start(); err != nil {	×
27	return err	×
28	}	×
29	if err := b.chainConn.NotifyBlocks(); err != nil {	×
30	return err	×
31	}	×
32
33	b.txNotifier = chainntnfs.NewTxNotifier(	×
34	uint32(bestHeight), chainntnfs.ReorgSafetyLimit,	×
35	b.confirmHintCache, b.spendHintCache,	×
36	)	×
37		×
38	if generateBlocks != nil {	×
39	// Ensure no block notifications are pending when we start the	×
40	// notification dispatcher goroutine.	×
41		×
42	// First generate the blocks, then drain the notifications	×
43	// for the generated blocks.	×
44	if err := generateBlocks(); err != nil {	×
45	return err	×
46	}	×
47
48	timeout := time.After(60 * time.Second)	×
49	loop:	×
50	for {	×
51	select {	×
52	case ntfn := <-b.chainConn.Notifications():	×
53	switch update := ntfn.(type) {	×
54	case chain.BlockConnected:	×
55	if update.Height >= syncHeight {	×
56	break loop	×
57	}
58	}
59	case <-timeout:	×
60	return fmt.Errorf("unable to catch up to height %d",	×
61	syncHeight)	×
62	}
63	}
64	}
65
66	// Run notificationDispatcher after setting the notifier's best block
67	// to avoid a race condition.
68	b.bestBlock = chainntnfs.BlockEpoch{Height: bestHeight, Hash: bestHash}	×
69	if bestHash == nil {	×
70	hash, err := b.chainConn.GetBlockHash(int64(bestHeight))	×
71	if err != nil {	×
72	return err	×
73	}	×
74	b.bestBlock.Hash = hash	×
75	}
76
77	b.wg.Add(1)	×
78	go b.notificationDispatcher()	×
79		×
80	return nil	×
81	}

lightningnetwork / lnd / 13035292482

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous