13043384202

Committed 30 Jan 2025 12:49AM UTC coverage: 48.841% (-9.9%) from 58.777%

Build # 13043384202

Build Type

Pull #9459

github

Committed by

ziggie1984

Commit Message

docs: add release notes.

Pull Request Pull Request #9459: invoices: amp invoices bugfix.

Run Details

28 of 45 new or added lines in 3 files covered. (62.22%)

28177 existing lines in 437 files now uncovered.

99712 of 204157 relevant lines covered (48.84%)

1.02 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

80.66

/feature/manager.go

package feature

import (
        "errors"
        "fmt"

        "github.com/lightningnetwork/lnd/lnwire"
)

var (
        // ErrUnknownSet is returned if a proposed feature vector contains a
        // set that is unknown to LND.
        ErrUnknownSet = errors.New("unknown feature bit set")

        // ErrFeatureConfigured is returned if an attempt is made to unset a
        // feature that was configured at startup.
        ErrFeatureConfigured = errors.New("can't unset configured feature")
)

// Config houses any runtime modifications to the default set descriptors. For
// our purposes, this typically means disabling certain features to test legacy
// protocol interoperability or functionality.
type Config struct {
        // NoTLVOnion unsets any optional or required TLVOnionPaylod bits from
        // all feature sets.
        NoTLVOnion bool

        // NoStaticRemoteKey unsets any optional or required StaticRemoteKey
        // bits from all feature sets.
        NoStaticRemoteKey bool

        // NoAnchors unsets any bits signaling support for anchor outputs.
        NoAnchors bool

        // NoWumbo unsets any bits signalling support for wumbo channels.
        NoWumbo bool

        // NoTaprootChans unsets any bits signaling support for taproot
        // channels.
        NoTaprootChans bool

        // NoScriptEnforcementLease unsets any bits signaling support for script
        // enforced leases.
        NoScriptEnforcementLease bool

        // NoKeysend unsets any bits signaling support for accepting keysend
        // payments.
        NoKeysend bool

        // NoOptionScidAlias unsets any bits signalling support for
        // option_scid_alias. This also implicitly disables zero-conf channels.
        NoOptionScidAlias bool

        // NoZeroConf unsets any bits signalling support for zero-conf
        // channels. This should be used instead of NoOptionScidAlias to still
        // keep option-scid-alias support.
        NoZeroConf bool

        // NoAnySegwit unsets any bits that signal support for using other
        // segwit witness versions for co-op closes.
        NoAnySegwit bool

        // NoRouteBlinding unsets route blinding feature bits.
        NoRouteBlinding bool

        // NoQuiescence unsets quiescence feature bits.
        NoQuiescence bool

        // NoTaprootOverlay unsets the taproot overlay channel feature bits.
        NoTaprootOverlay bool

        // NoExperimentalEndorsement unsets any bits that signal support for
        // forwarding experimental endorsement.
        NoExperimentalEndorsement bool

        // CustomFeatures is a set of custom features to advertise in each
        // set.
        CustomFeatures map[Set][]lnwire.FeatureBit
}

// Manager is responsible for generating feature vectors for different requested
// feature sets.
type Manager struct {
        // fsets is a static map of feature set to raw feature vectors. Requests
        // are fulfilled by cloning these internal feature vectors.
        fsets map[Set]*lnwire.RawFeatureVector

        // configFeatures is a set of custom features that were "hard set" in
        // lnd's config that cannot be updated at runtime (as is the case with
        // our "standard" features that are defined in LND).
        configFeatures map[Set]*lnwire.FeatureVector
}

// NewManager creates a new feature Manager, applying any custom modifications
// to its feature sets before returning.
func NewManager(cfg Config) (*Manager, error) {
        return newManager(cfg, defaultSetDesc)
}

// newManager creates a new feature Manager, applying any custom modifications
// to its feature sets before returning. This method accepts the setDesc as its
// own parameter so that it can be unit tested.
func newManager(cfg Config, desc setDesc) (*Manager, error) {
        // First build the default feature vector for all known sets.
        fsets := make(map[Set]*lnwire.RawFeatureVector)
        for bit, sets := range desc {
                for set := range sets {
                        // Fetch the feature vector for this set, allocating a
                        // new one if it doesn't exist.
                        fv, ok := fsets[set]
                        if !ok {
                                fv = lnwire.NewRawFeatureVector()
                        }

                        // Set the configured bit on the feature vector,
                        // ensuring that we don't set two feature bits for the
                        // same pair.
                        err := fv.SafeSet(bit)
                        if err != nil {
                                return nil, fmt.Errorf("unable to set "+
                                        "%v in %v: %v", bit, set, err)
                        }

                        // Write the updated feature vector under its set.
                        fsets[set] = fv
                }
        }

        // Now, remove any features as directed by the config.
        configFeatures := make(map[Set]*lnwire.FeatureVector)
        for set, raw := range fsets {
                if cfg.NoTLVOnion {
                        raw.Unset(lnwire.TLVOnionPayloadOptional)
                        raw.Unset(lnwire.TLVOnionPayloadRequired)
                        raw.Unset(lnwire.PaymentAddrOptional)
                        raw.Unset(lnwire.PaymentAddrRequired)
                        raw.Unset(lnwire.MPPOptional)
                        raw.Unset(lnwire.MPPRequired)
                        raw.Unset(lnwire.RouteBlindingOptional)
                        raw.Unset(lnwire.RouteBlindingRequired)
                        raw.Unset(lnwire.Bolt11BlindedPathsOptional)
                        raw.Unset(lnwire.Bolt11BlindedPathsRequired)
                        raw.Unset(lnwire.AMPOptional)
                        raw.Unset(lnwire.AMPRequired)
                        raw.Unset(lnwire.KeysendOptional)
                        raw.Unset(lnwire.KeysendRequired)
                }
                if cfg.NoStaticRemoteKey {
                        raw.Unset(lnwire.StaticRemoteKeyOptional)
                        raw.Unset(lnwire.StaticRemoteKeyRequired)
                }
                if cfg.NoAnchors {
                        raw.Unset(lnwire.AnchorsZeroFeeHtlcTxOptional)
                        raw.Unset(lnwire.AnchorsZeroFeeHtlcTxRequired)

                        // If anchors are disabled, then we also need to
                        // disable all other features that depend on it as
                        // well, as otherwise we may create an invalid feature
                        // bit set.
                        for bit, depFeatures := range deps {
                                for depFeature := range depFeatures {
                                        switch {
                                        case depFeature == lnwire.AnchorsZeroFeeHtlcTxRequired:
                                                fallthrough
                                        case depFeature == lnwire.AnchorsZeroFeeHtlcTxOptional:
                                                raw.Unset(bit)
                                        }
                                }
                        }
                }
                if cfg.NoWumbo {
                        raw.Unset(lnwire.WumboChannelsOptional)
                        raw.Unset(lnwire.WumboChannelsRequired)
                }
                if cfg.NoScriptEnforcementLease {
                        raw.Unset(lnwire.ScriptEnforcedLeaseOptional)
                        raw.Unset(lnwire.ScriptEnforcedLeaseRequired)
                }
                if cfg.NoKeysend {
                        raw.Unset(lnwire.KeysendOptional)
                        raw.Unset(lnwire.KeysendRequired)
                }
                if cfg.NoOptionScidAlias {
                        raw.Unset(lnwire.ScidAliasOptional)
                        raw.Unset(lnwire.ScidAliasRequired)
                }
                if cfg.NoZeroConf {
                        raw.Unset(lnwire.ZeroConfOptional)
                        raw.Unset(lnwire.ZeroConfRequired)
                }
                if cfg.NoAnySegwit {
                        raw.Unset(lnwire.ShutdownAnySegwitOptional)
                        raw.Unset(lnwire.ShutdownAnySegwitRequired)
                }
                if cfg.NoTaprootChans {
                        raw.Unset(lnwire.SimpleTaprootChannelsOptionalStaging)
                        raw.Unset(lnwire.SimpleTaprootChannelsRequiredStaging)
                }
                if cfg.NoRouteBlinding {
                        raw.Unset(lnwire.RouteBlindingOptional)
                        raw.Unset(lnwire.RouteBlindingRequired)
                        raw.Unset(lnwire.Bolt11BlindedPathsOptional)
                        raw.Unset(lnwire.Bolt11BlindedPathsRequired)
                }
                if cfg.NoQuiescence {
                        raw.Unset(lnwire.QuiescenceOptional)
                }
                if cfg.NoTaprootOverlay {
                        raw.Unset(lnwire.SimpleTaprootOverlayChansOptional)
                        raw.Unset(lnwire.SimpleTaprootOverlayChansRequired)
                }

                if cfg.NoExperimentalEndorsement {
                        raw.Unset(lnwire.ExperimentalEndorsementOptional)
                        raw.Unset(lnwire.ExperimentalEndorsementRequired)
                }

                for _, custom := range cfg.CustomFeatures[set] {
                        if custom > set.Maximum() {
                                return nil, fmt.Errorf("feature bit: %v "+
                                        "exceeds set: %v maximum: %v", custom,
                                        set, set.Maximum())
                        }

                        if raw.IsSet(custom) {
                                return nil, fmt.Errorf("feature bit: %v "+
                                        "already set", custom)
                        }

                        if err := raw.SafeSet(custom); err != nil {
                                return nil, fmt.Errorf("%w: could not set "+
                                        "feature: %d", err, custom)
                        }
                }

                // Track custom features separately so that we can check that
                // they aren't unset in subsequent updates. If there is no
                // entry for the set, the vector will just be empty.
                configFeatures[set] = lnwire.NewFeatureVector(
                        lnwire.NewRawFeatureVector(cfg.CustomFeatures[set]...),
                        lnwire.Features,
                )

                // Ensure that all of our feature sets properly set any
                // dependent features.
                fv := lnwire.NewFeatureVector(raw, lnwire.Features)
                err := ValidateDeps(fv)
                if err != nil {
                        return nil, fmt.Errorf("invalid feature set %v: %w",
                                set, err)
                }
        }

        return &Manager{
                fsets:          fsets,
                configFeatures: configFeatures,
        }, nil
}

// GetRaw returns a raw feature vector for the passed set. If no set is known,
// an empty raw feature vector is returned.
func (m *Manager) GetRaw(set Set) *lnwire.RawFeatureVector {
        if fv, ok := m.fsets[set]; ok {
                return fv.Clone()
        }

        return lnwire.NewRawFeatureVector()
}

// setRaw sets a new raw feature vector for the given set.
func (m *Manager) setRaw(set Set, raw *lnwire.RawFeatureVector) {
        m.fsets[set] = raw
}

// Get returns a feature vector for the passed set. If no set is known, an empty
// feature vector is returned.
func (m *Manager) Get(set Set) *lnwire.FeatureVector {
        raw := m.GetRaw(set)
        return lnwire.NewFeatureVector(raw, lnwire.Features)
}

// ListSets returns a list of the feature sets that our node supports.
func (m *Manager) ListSets() []Set {
        var sets []Set

        for set := range m.fsets {
                sets = append(sets, set)
        }

        return sets
}

// UpdateFeatureSets accepts a map of new feature vectors for each of the
// manager's known sets, validates that the update can be applied and modifies
// the feature manager's internal state. If a set is not included in the update
// map, it is left unchanged. The feature vectors provided are expected to
// include the current set of features, updated with desired bits added/removed.
func (m *Manager) UpdateFeatureSets(
        updates map[Set]*lnwire.RawFeatureVector) error {

        for set, newFeatures := range updates {
                if !set.valid() {
                        return fmt.Errorf("%w: set: %d", ErrUnknownSet, set)
                }

                if err := newFeatures.ValidatePairs(); err != nil {
                        return err
                }

                if err := m.Get(set).ValidateUpdate(
                        newFeatures, set.Maximum(),
                ); err != nil {
                        return err
                }

                // If any features were configured for this set, ensure that
                // they are still set in the new feature vector.
                if cfgFeat, haveCfgFeat := m.configFeatures[set]; haveCfgFeat {
                        for feature := range cfgFeat.Features() {
                                if !newFeatures.IsSet(feature) {
                                        return fmt.Errorf("%w: can't unset: "+
                                                "%d", ErrFeatureConfigured,
                                                feature)
                                }
                        }
                }

                fv := lnwire.NewFeatureVector(newFeatures, lnwire.Features)
                if err := ValidateDeps(fv); err != nil {
                        return err
                }
        }

        // Only update the current feature sets once every proposed set has
        // passed validation so that we don't partially update any sets then
        // fail out on a later set's validation.
        for set, features := range updates {
                m.setRaw(set, features.Clone())
        }

        return nil
}

1	package feature
2
3	import (
4	"errors"
5	"fmt"
6
7	"github.com/lightningnetwork/lnd/lnwire"
8	)
9
10	var (
11	// ErrUnknownSet is returned if a proposed feature vector contains a
12	// set that is unknown to LND.
13	ErrUnknownSet = errors.New("unknown feature bit set")
14
15	// ErrFeatureConfigured is returned if an attempt is made to unset a
16	// feature that was configured at startup.
17	ErrFeatureConfigured = errors.New("can't unset configured feature")
18	)
19
20	// Config houses any runtime modifications to the default set descriptors. For
21	// our purposes, this typically means disabling certain features to test legacy
22	// protocol interoperability or functionality.
23	type Config struct {
24	// NoTLVOnion unsets any optional or required TLVOnionPaylod bits from
25	// all feature sets.
26	NoTLVOnion bool
27
28	// NoStaticRemoteKey unsets any optional or required StaticRemoteKey
29	// bits from all feature sets.
30	NoStaticRemoteKey bool
31
32	// NoAnchors unsets any bits signaling support for anchor outputs.
33	NoAnchors bool
34
35	// NoWumbo unsets any bits signalling support for wumbo channels.
36	NoWumbo bool
37
38	// NoTaprootChans unsets any bits signaling support for taproot
39	// channels.
40	NoTaprootChans bool
41
42	// NoScriptEnforcementLease unsets any bits signaling support for script
43	// enforced leases.
44	NoScriptEnforcementLease bool
45
46	// NoKeysend unsets any bits signaling support for accepting keysend
47	// payments.
48	NoKeysend bool
49
50	// NoOptionScidAlias unsets any bits signalling support for
51	// option_scid_alias. This also implicitly disables zero-conf channels.
52	NoOptionScidAlias bool
53
54	// NoZeroConf unsets any bits signalling support for zero-conf
55	// channels. This should be used instead of NoOptionScidAlias to still
56	// keep option-scid-alias support.
57	NoZeroConf bool
58
59	// NoAnySegwit unsets any bits that signal support for using other
60	// segwit witness versions for co-op closes.
61	NoAnySegwit bool
62
63	// NoRouteBlinding unsets route blinding feature bits.
64	NoRouteBlinding bool
65
66	// NoQuiescence unsets quiescence feature bits.
67	NoQuiescence bool
68
69	// NoTaprootOverlay unsets the taproot overlay channel feature bits.
70	NoTaprootOverlay bool
71
72	// NoExperimentalEndorsement unsets any bits that signal support for
73	// forwarding experimental endorsement.
74	NoExperimentalEndorsement bool
75
76	// CustomFeatures is a set of custom features to advertise in each
77	// set.
78	CustomFeatures map[Set][]lnwire.FeatureBit
79	}
80
81	// Manager is responsible for generating feature vectors for different requested
82	// feature sets.
83	type Manager struct {
84	// fsets is a static map of feature set to raw feature vectors. Requests
85	// are fulfilled by cloning these internal feature vectors.
86	fsets map[Set]*lnwire.RawFeatureVector
87
88	// configFeatures is a set of custom features that were "hard set" in
89	// lnd's config that cannot be updated at runtime (as is the case with
90	// our "standard" features that are defined in LND).
91	configFeatures map[Set]*lnwire.FeatureVector
92	}
93
94	// NewManager creates a new feature Manager, applying any custom modifications
95	// to its feature sets before returning.
96	func NewManager(cfg Config) (*Manager, error) {	2✔
97	return newManager(cfg, defaultSetDesc)	2✔
98	}	2✔
99
100	// newManager creates a new feature Manager, applying any custom modifications
101	// to its feature sets before returning. This method accepts the setDesc as its
102	// own parameter so that it can be unit tested.
103	func newManager(cfg Config, desc setDesc) (*Manager, error) {	2✔
104	// First build the default feature vector for all known sets.	2✔
105	fsets := make(map[Set]*lnwire.RawFeatureVector)	2✔
106	for bit, sets := range desc {	4✔
107	for set := range sets {	4✔
108	// Fetch the feature vector for this set, allocating a	2✔
109	// new one if it doesn't exist.	2✔
110	fv, ok := fsets[set]	2✔
111	if !ok {	4✔
112	fv = lnwire.NewRawFeatureVector()	2✔
113	}	2✔
114
115	// Set the configured bit on the feature vector,
116	// ensuring that we don't set two feature bits for the
117	// same pair.
118	err := fv.SafeSet(bit)	2✔
119	if err != nil {	2✔
120	return nil, fmt.Errorf("unable to set "+	×
121	"%v in %v: %v", bit, set, err)	×
122	}	×
123
124	// Write the updated feature vector under its set.
125	fsets[set] = fv	2✔
126	}
127	}
128
129	// Now, remove any features as directed by the config.
130	configFeatures := make(map[Set]*lnwire.FeatureVector)	2✔
131	for set, raw := range fsets {	4✔
132	if cfg.NoTLVOnion {	4✔
133	raw.Unset(lnwire.TLVOnionPayloadOptional)	2✔
134	raw.Unset(lnwire.TLVOnionPayloadRequired)	2✔
135	raw.Unset(lnwire.PaymentAddrOptional)	2✔
136	raw.Unset(lnwire.PaymentAddrRequired)	2✔
137	raw.Unset(lnwire.MPPOptional)	2✔
138	raw.Unset(lnwire.MPPRequired)	2✔
139	raw.Unset(lnwire.RouteBlindingOptional)	2✔
140	raw.Unset(lnwire.RouteBlindingRequired)	2✔
141	raw.Unset(lnwire.Bolt11BlindedPathsOptional)	2✔
142	raw.Unset(lnwire.Bolt11BlindedPathsRequired)	2✔
143	raw.Unset(lnwire.AMPOptional)	2✔
144	raw.Unset(lnwire.AMPRequired)	2✔
145	raw.Unset(lnwire.KeysendOptional)	2✔
146	raw.Unset(lnwire.KeysendRequired)	2✔
147	}	2✔
148	if cfg.NoStaticRemoteKey {	4✔
149	raw.Unset(lnwire.StaticRemoteKeyOptional)	2✔
150	raw.Unset(lnwire.StaticRemoteKeyRequired)	2✔
151	}	2✔
152	if cfg.NoAnchors {	4✔
153	raw.Unset(lnwire.AnchorsZeroFeeHtlcTxOptional)	2✔
154	raw.Unset(lnwire.AnchorsZeroFeeHtlcTxRequired)	2✔
155		2✔
156	// If anchors are disabled, then we also need to	2✔
157	// disable all other features that depend on it as	2✔
158	// well, as otherwise we may create an invalid feature	2✔
159	// bit set.	2✔
160	for bit, depFeatures := range deps {	4✔
161	for depFeature := range depFeatures {	4✔
162	switch {	2✔
163	case depFeature == lnwire.AnchorsZeroFeeHtlcTxRequired:	×
164	fallthrough	×
165	case depFeature == lnwire.AnchorsZeroFeeHtlcTxOptional:	2✔
166	raw.Unset(bit)	2✔
167	}
168	}
169	}
170	}
171	if cfg.NoWumbo {	4✔
172	raw.Unset(lnwire.WumboChannelsOptional)	2✔
173	raw.Unset(lnwire.WumboChannelsRequired)	2✔
174	}	2✔
175	if cfg.NoScriptEnforcementLease {	4✔
176	raw.Unset(lnwire.ScriptEnforcedLeaseOptional)	2✔
177	raw.Unset(lnwire.ScriptEnforcedLeaseRequired)	2✔
178	}	2✔
179	if cfg.NoKeysend {	2✔
180	raw.Unset(lnwire.KeysendOptional)	×
181	raw.Unset(lnwire.KeysendRequired)	×
182	}	×
183	if cfg.NoOptionScidAlias {	4✔
184	raw.Unset(lnwire.ScidAliasOptional)	2✔
185	raw.Unset(lnwire.ScidAliasRequired)	2✔
186	}	2✔
187	if cfg.NoZeroConf {	4✔
188	raw.Unset(lnwire.ZeroConfOptional)	2✔
189	raw.Unset(lnwire.ZeroConfRequired)	2✔
190	}	2✔
191	if cfg.NoAnySegwit {	4✔
192	raw.Unset(lnwire.ShutdownAnySegwitOptional)	2✔
193	raw.Unset(lnwire.ShutdownAnySegwitRequired)	2✔
194	}	2✔
195	if cfg.NoTaprootChans {	4✔
196	raw.Unset(lnwire.SimpleTaprootChannelsOptionalStaging)	2✔
197	raw.Unset(lnwire.SimpleTaprootChannelsRequiredStaging)	2✔
198	}	2✔
199	if cfg.NoRouteBlinding {	4✔
200	raw.Unset(lnwire.RouteBlindingOptional)	2✔
201	raw.Unset(lnwire.RouteBlindingRequired)	2✔
202	raw.Unset(lnwire.Bolt11BlindedPathsOptional)	2✔
203	raw.Unset(lnwire.Bolt11BlindedPathsRequired)	2✔
204	}	2✔
205	if cfg.NoQuiescence {	2✔
206	raw.Unset(lnwire.QuiescenceOptional)	×
207	}	×
208	if cfg.NoTaprootOverlay {	4✔
209	raw.Unset(lnwire.SimpleTaprootOverlayChansOptional)	2✔
210	raw.Unset(lnwire.SimpleTaprootOverlayChansRequired)	2✔
211	}	2✔
212
213	if cfg.NoExperimentalEndorsement {	4✔
214	raw.Unset(lnwire.ExperimentalEndorsementOptional)	2✔
215	raw.Unset(lnwire.ExperimentalEndorsementRequired)	2✔
216	}	2✔
217
218	for _, custom := range cfg.CustomFeatures[set] {	4✔
219	if custom > set.Maximum() {	2✔
220	return nil, fmt.Errorf("feature bit: %v "+	×
221	"exceeds set: %v maximum: %v", custom,	×
222	set, set.Maximum())	×
223	}	×
224
225	if raw.IsSet(custom) {	2✔
226	return nil, fmt.Errorf("feature bit: %v "+	×
227	"already set", custom)	×
228	}	×
229
230	if err := raw.SafeSet(custom); err != nil {	2✔
231	return nil, fmt.Errorf("%w: could not set "+	×
232	"feature: %d", err, custom)	×
233	}	×
234	}
235
236	// Track custom features separately so that we can check that
237	// they aren't unset in subsequent updates. If there is no
238	// entry for the set, the vector will just be empty.
239	configFeatures[set] = lnwire.NewFeatureVector(	2✔
240	lnwire.NewRawFeatureVector(cfg.CustomFeatures[set]...),	2✔
241	lnwire.Features,	2✔
242	)	2✔
243		2✔
244	// Ensure that all of our feature sets properly set any	2✔
245	// dependent features.	2✔
246	fv := lnwire.NewFeatureVector(raw, lnwire.Features)	2✔
247	err := ValidateDeps(fv)	2✔
248	if err != nil {	2✔
249	return nil, fmt.Errorf("invalid feature set %v: %w",	×
250	set, err)	×
251	}	×
252	}
253
254	return &Manager{	2✔
255	fsets: fsets,	2✔
256	configFeatures: configFeatures,	2✔
257	}, nil	2✔
258	}
259
260	// GetRaw returns a raw feature vector for the passed set. If no set is known,
261	// an empty raw feature vector is returned.
262	func (m Manager) GetRaw(set Set) lnwire.RawFeatureVector {	2✔
263	if fv, ok := m.fsets[set]; ok {	4✔
264	return fv.Clone()	2✔
265	}	2✔
266
UNCOV 267	return lnwire.NewRawFeatureVector()	×
268	}
269
270	// setRaw sets a new raw feature vector for the given set.
271	func (m Manager) setRaw(set Set, raw lnwire.RawFeatureVector) {	2✔
272	m.fsets[set] = raw	2✔
273	}	2✔
274
275	// Get returns a feature vector for the passed set. If no set is known, an empty
276	// feature vector is returned.
277	func (m Manager) Get(set Set) lnwire.FeatureVector {	2✔
278	raw := m.GetRaw(set)	2✔
279	return lnwire.NewFeatureVector(raw, lnwire.Features)	2✔
280	}	2✔
281
282	// ListSets returns a list of the feature sets that our node supports.
283	func (m *Manager) ListSets() []Set {	2✔
284	var sets []Set	2✔
285		2✔
286	for set := range m.fsets {	4✔
287	sets = append(sets, set)	2✔
288	}	2✔
289
290	return sets	2✔
291	}
292
293	// UpdateFeatureSets accepts a map of new feature vectors for each of the
294	// manager's known sets, validates that the update can be applied and modifies
295	// the feature manager's internal state. If a set is not included in the update
296	// map, it is left unchanged. The feature vectors provided are expected to
297	// include the current set of features, updated with desired bits added/removed.
298	func (m *Manager) UpdateFeatureSets(
299	updates map[Set]*lnwire.RawFeatureVector) error {	2✔
300		2✔
301	for set, newFeatures := range updates {	4✔
302	if !set.valid() {	2✔
UNCOV 303	return fmt.Errorf("%w: set: %d", ErrUnknownSet, set)	×
UNCOV 304	}	×
305
306	if err := newFeatures.ValidatePairs(); err != nil {	2✔
UNCOV 307	return err	×
UNCOV 308	}	×
309
310	if err := m.Get(set).ValidateUpdate(	2✔
311	newFeatures, set.Maximum(),	2✔
312	); err != nil {	4✔
313	return err	2✔
314	}	2✔
315
316	// If any features were configured for this set, ensure that
317	// they are still set in the new feature vector.
318	if cfgFeat, haveCfgFeat := m.configFeatures[set]; haveCfgFeat {	4✔
319	for feature := range cfgFeat.Features() {	2✔
UNCOV 320	if !newFeatures.IsSet(feature) {	×
UNCOV 321	return fmt.Errorf("%w: can't unset: "+	×
UNCOV 322	"%d", ErrFeatureConfigured,	×
UNCOV 323	feature)	×
UNCOV 324	}	×
325	}
326	}
327
328	fv := lnwire.NewFeatureVector(newFeatures, lnwire.Features)	2✔
329	if err := ValidateDeps(fv); err != nil {	2✔
330	return err	×
331	}	×
332	}
333
334	// Only update the current feature sets once every proposed set has
335	// passed validation so that we don't partially update any sets then
336	// fail out on a later set's validation.
337	for set, features := range updates {	4✔
338	m.setRaw(set, features.Clone())	2✔
339	}	2✔
340
341	return nil	2✔
342	}

lightningnetwork / lnd / 13043384202

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous